Hi Peter,
Our Colibri iMX6ULL is using NXP i.MX6 ULL in USB host mode. With
4.15-rc3 and 4.16-rc1 I noticed that when a USB Hub is connected to the
USB OTG controller in host mode, Linux continuously resets the USB
device every two seconds:
[0.927567] ehci_hcd: USB 2.0 'Enhanced' Host
ux500_musb_vbus_id_status' to different enumeration
type 'enum usb_phy_events' [-Wenum-conversion]
enum usb_phy_events event = UX500_MUSB_NONE;
~ ^~~
Signed-off-by: Stefan Agner <ste...@agner.ch>
---
drivers/usb/phy/phy-ab8500-usb.c | 2 +-
1 file chan
s been
configured through struct_ep_setup. Check whether struct usb_ep name
pointer has been set instead.
Signed-off-by: Stefan Agner <ste...@agner.ch>
---
drivers/usb/gadget/udc/fsl_udc_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/fsl_u
already set it back high, which is not long enouth.
Make sure reset is asserted for at least 100us by inserting a
delay after initializing the reset pin during probe.
Signed-off-by: Stefan Agner <ste...@agner.ch>
---
drivers/usb/misc/usb3503.c | 2 ++
1 file changed, 2 insertions(+)
diff
On 2017-11-01 02:38, Peter Chen wrote:
> On Tue, Oct 31, 2017 at 06:07:39PM +0100, Stefan Agner wrote:
>> Hi Peter,
>>
>> I am currently trying to come up with a upstreamable solution for USB
>> device/host switch for our NXP i.MX 7 CoM (Colibri iMX7). My colleague
Hi Peter,
I am currently trying to come up with a upstreamable solution for USB
device/host switch for our NXP i.MX 7 CoM (Colibri iMX7). My colleague
Sanchayan already posted on the mailing list in a earlier attempt for
our Colibri VFxx modules (NXP Vybrid):
Hi Felipe,
On 2017-04-19 01:53, Krzysztof Opasiak wrote:
> On 04/15/2017 03:35 AM, Stefan Agner wrote:
>> Currently qw_sign requires UTF-8 character to set, but returns UTF-16
>> when read. This isn't obvious when simply using cat since the null
>> characters are not visible
The assignment ret = ret is redundant and can be removed.
Signed-off-by: Stefan Agner <ste...@agner.ch>
---
A very similar patch has been applied already last year, but there is
a second such assignment...
--
Stefan
drivers/usb/gadget/udc/core.c | 4 +---
1 file changed, 1 insertion
00 54 00 31 00 30 00 30 00|M.S.F.T.1.0.0.|
Make qw_sign symmetric by returning an UTF-8 string too. Also follow
common convention and add a new line at the end.
Signed-off-by: Stefan Agner <ste...@agner.ch>
---
Resend as discussed here:
https://patchwork.kernel.org/patch/954886
Other unsigned properties return hexadecimal values, follow this
convention when printing b_vendor_code too. Also add newlines to
the OS Descriptor support related properties, like other sysfs
files use.
Signed-off-by: Stefan Agner <ste...@agner.ch>
---
drivers/usb/gadget/configfs
On 2017-02-10 04:30, Felipe Balbi wrote:
> Hi,
>
> Greg KH <gre...@linuxfoundation.org> writes:
>> On Thu, Feb 09, 2017 at 10:04:43AM -0800, Stefan Agner wrote:
>>> On 2017-02-01 08:59, Stefan Agner wrote:
>>> > On 2017-02-01 00:06, Greg KH wrote:
>&
On 2017-02-01 08:59, Stefan Agner wrote:
> On 2017-02-01 00:06, Greg KH wrote:
>> On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote:
>>> Currently qw_sign requires UTF-8 character to set, but returns UTF-16
>>> when read. This isn't obvious when simp
On 2017-02-01 00:06, Greg KH wrote:
> On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote:
>> Currently qw_sign requires UTF-8 character to set, but returns UTF-16
>> when read. This isn't obvious when simply using cat since the null
>> characters are not visible
On 2017-02-01 01:02, Felipe Balbi wrote:
> Hi,
>
> Greg KH <gre...@linuxfoundation.org> writes:
>> On Tue, Jan 31, 2017 at 06:19:17PM -0800, Stefan Agner wrote:
>>> Other unsigned properties return hexadecimal values, follow this
>>> convention when printi
00 54 00 31 00 30 00 30 00|M.S.F.T.1.0.0.|
Make qw_sign symmetric by returning an UTF-8 string too. Also follow
common convention and add a new line at the end.
Signed-off-by: Stefan Agner <ste...@agner.ch>
---
drivers/usb/gadget/configfs.c | 8 ++--
1 file changed, 6 inserti
Other unsigned properties return hexadecimal values, follow this
convention when printing b_vendor_code too. Also add newlines to
the OS Descriptor support related properties, like other sysfs
files use.
Signed-off-by: Stefan Agner <ste...@agner.ch>
---
drivers/usb/gadget/configfs
On 2016-09-07 11:53, Mark Brown wrote:
> On Tue, Sep 06, 2016 at 11:01:15AM -0700, Stefan Agner wrote:
>> On 2016-09-06 01:22, Mark Brown wrote:
>
>> > This is nonsense unless the device can work without this supply. Given
>> > that the supply is called VCC tha
On 2016-09-06 01:22, Mark Brown wrote:
> On Tue, Sep 06, 2016 at 10:45:19AM +0300, Felipe Balbi wrote:
>> Stefan Agner <ste...@agner.ch> writes:
>
>> > According to the device tree bindings the vcc-supply is optional.
>
> This is nonsense unless the device can
false. This is the
correct behavior, since even if the regulator is optional, it might
get initialized later...
Signed-off-by: Stefan Agner <ste...@agner.ch>
---
This gets rid of warnings such as this (seen on i.MX 7):
3080.aips-bus:usbphynop1 supply vcc not found, using dummy reg
gt;
Tested on Vybrid. Timer interrupts went down from ~35 to ~25 per second
(just did a by eye survey using watch -n 1 cat /proc/interrupts). Not
sure what failure to expect, but things just seemed to work as normal.
Did some md5sums on USB mass storage device and used a HID device.
Tested-
On 2016-03-25 00:40, Peter Chen wrote:
> On Tue, Mar 15, 2016 at 02:08:26PM +0530, Sanchayan Maity wrote:
>> Hello Peter,
>>
>> The existing usage of extcon in Chipidea driver relies on OTG
>> registers. In case of SoC with dual role device but not a true
>> OTG controller, this does not work.
Avoid printing an error if adding the device failes with return
value EPROBE_DEFFER. This may happen e.g. due to missing GPIO for
the vbus-supply regulator.
Signed-off-by: Stefan Agner <ste...@agner.ch>
---
drivers/usb/chipidea/ci_hdrc_imx.c | 6 +++---
1 file changed, 3 insertions
On 2015-09-17 22:39, Peter Chen wrote:
> On Wed, Sep 16, 2015 at 02:48:50PM +0530, maitysancha...@gmail.com wrote:
>> On 15-09-16 15:54:21, Peter Chen wrote:
>> > On Wed, Sep 16, 2015 at 02:18:49PM +0530, maitysancha...@gmail.com wrote:
>> > > Hello Peter,
>> > >
>> > > >
>> > > > Enable
On 2015-06-23 11:22, Johan Hovold wrote:
On Mon, Jun 22, 2015 at 10:11:35PM +0200, Stefan Agner wrote:
On 2015-06-22 19:26, Johan Hovold wrote:
Instead, hang the gpio chip directly off the usb interface (not the
port), add a new config option, and keep the gpio implementation under
On 2015-06-22 19:26, Johan Hovold wrote:
On Sun, Jun 21, 2015 at 12:12:55AM +0200, Stefan Agner wrote:
snip
Bit Bang mode, the pins need to be reprogrammed to I/O mode first
(EEPROM). All three modes are supported from userspace by libftdi afaik.
Is there a way to retrieve the settings from
Hi Philipp,
On 2015-06-21 04:22, Philipp Hachtmann wrote:
Am 21.06.2015 um 00:12 schrieb Stefan Agner:
There are three GPIO modes supported by FTDI devices:
1. Asynchronous Bit Bang Mode (used in Sacha's patch)
2. Synchronous Bit Bang Mode (used in Philipp's patch)
3. CBUS Bit Bang Mode
On 2015-06-21 01:49, Peter Stuge wrote:
Stefan Agner wrote:
libftdi requires to detach the kernel driver to get access to the device
Control transfers ought to be possible without a detach.
Good to know, thanks for this input. The detach is probably a default
behavior of libftdi... Will have
Add interface to allow CBUS access. The functions set_bitmode and
read_pins use control transfers only hence should not interfere
with the serial operation mode.
Signed-off-by: Stefan Agner ste...@agner.ch
---
drivers/usb/serial/ftdi_sio.c | 41 +
drivers
.
Signed-off-by: Stefan Agner ste...@agner.ch
---
drivers/gpio/Kconfig | 10 +++
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-ftdi-cbus.c | 167 ++
drivers/usb/serial/ftdi_sio.c | 16
4 files changed, 194 insertions(+)
create mode
and still live under drivers/usb/serial/...?
I just saw that recent discussion by Grant and Linus did not approve
this approach...?
Stefan Agner (2):
USB: ftdi_sio: add CBUS mode for FT232R devices
gpio: gpio-ftdi-cbus: add driver for FTDI CBUS GPIOs
drivers/gpio/Kconfig | 10 +++
drivers
On 2015-05-18 14:16, Bjørn Mork wrote:
Stefan Agner ste...@agner.ch writes:
MAC addresses can be written without leading zeros. A popular
example is libc's ether_ntoa_r function which creates such
MAC addresses.
Example:
00:14:3d:0f:ff:fe can be written as 0:14:3d:f:ff:fe
The function
On 2015-05-04 10:42, Krzysztof Opasiak wrote:
Hi,
On 04/28/2015 07:57 PM, Stefan Agner wrote:
MAC addresses can be written without leading zeros. A popular
example is libc's ether_ntoa_r function which creates such
MAC addresses.
Example:
00:14:3d:0f:ff:fe can be written as 0:14
the opportunity and fix the
function to never parse beyond the end of the string while
allowing MAC addresses with and without leading zeros.
Signed-off-by: Stefan Agner ste...@agner.ch
---
drivers/usb/gadget/function/u_ether.c | 41 +--
1 file changed, 25 insertions
On 2015-04-28 17:00, Krzysztof Opasiak wrote:
Hi Stefan,
On 04/28/2015 01:51 PM, Stefan Agner wrote:
MAC addresses can be written without leading zeros. A popular
example is libc's ether_ntoa_r function which creates such
MAC addresses.
Example:
00:14:3d:0f:ff:fe can be written as 0:14
Hi Krzysztof,
On 2015-04-27 11:42, Krzysztof Opasiak wrote:
MAC address is often written without leading zeros.
Example:
00:14:3d:0f:ff:fe can be written as 0:14:3d:f:ff:fe
Convention of skipping leading zeros is used in libc.
enther_ntoa_r() generates MAC address without leading
zeros.
the opportunity and fix
the function to never parse beyond the end of the string while
allowing MAC addresses with and without leading zeros. Also
corner cases such as 00:14:3d:0f:ff:0 + new-line character
are parsed correctly.
Signed-off-by: Stefan Agner ste...@agner.ch
---
drivers/usb/gadget
On 2015-04-28 18:31, Felipe Balbi wrote:
On Tue, Apr 28, 2015 at 06:15:51PM +0200, Krzysztof Opasiak wrote:
On 04/28/2015 05:59 PM, Stefan Agner wrote:
On 2015-04-28 17:00, Krzysztof Opasiak wrote:
Hi Stefan,
On 04/28/2015 01:51 PM, Stefan Agner wrote:
MAC addresses can be written without
provides the format expected by the
kernel.
Signed-off-by: Stefan Agner ste...@agner.ch
---
Hi Matt,
Discovered this while trying to integrate gadget-export/import
on our Colibri VF61 module.
This bug leads to various interesting effects when using export/
import functionality, e.g.
A configuration
at drivers/usb/chipidea/bits.h [Patch 3/2]
- Change enum CI_REVISION to enum ci_revision [Patch 3/2]
- Delete one local variable when getting revision [Patch 3/2]
- Add Tested-by: Stefan Agner ste...@agner.ch [Patch 3/3]
Looks good to me now, also tested again on 3.19-rc2, works fine!
Reviewed
copies as well as adding some kernel level
latencies by pluging and unpluging a USB mass storage device. Looks good
to me as well:
Tested-by: Stefan Agner ste...@agner.ch
Btw, this was and solves now the error I was mentioning in my patchset
enabling Vybrid support:
http://lists.infradead.org
On 2014-12-19 10:55, Sanchayan Maity wrote:
Define ci_get_revision API to know the controller revision
information according to chipidea 1.1a, 2.0a, 2.4 and 2.5a
spec. Besides, add one entry in struct ci_hdrc to indicate
revision information. This can be used for adding different
code for
I think I still miss a Signed-Off-By Felipe Balbi here...
All the rest should make it into 3.18, but USB without PHY is no fun to
use ;-)
Am 2014-08-19 01:37, schrieb Stefan Agner:
This adds support for the USB PHY in Vybrid VF610. We assume that
the disconnection without VBUS is also needed
This adds Vybrid VF610 SoC support. The IP is very similar to i.MX6,
however, the non-core registers are spread in two different register
areas. Hence we support multiple instances of the USB misc driver
and add the driver instance to the imx_usbmisc_data structure.
Signed-off-by: Stefan Agner
Add USB support for Freescale Vybrid tower. The USB hosts over-current
protection signal is not connected is not connected to the PHY's over-
current protection, hence we need to disable it.
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/boot/dts/vf610-twr.dts | 10 ++
1 file
] usb usb1-port1: unable to enumerate USB device
Hence we also enable the MXS_PHY_NEED_IP_FIX flag.
Acked-by: Peter Chen peter.c...@freescale.com
Signed-off-by: Stefan Agner ste...@agner.ch
---
Documentation/devicetree/bindings/usb/mxs-phy.txt | 1 +
drivers/usb/phy/phy-mxs-usb.c
to support multiple instances
- Update DT documentation and compatible strings where necessary
- Add USB PHY flag MXS_PHY_NEED_IP_FIX
- Added patches to enable USB on Tower
Stefan Agner (7):
ARM: dts: vf610: Add USB PHY and controller
ARM: imx: clk-vf610: Add USBPHY clocks
usb: phy: mxs: Add
This commit adds PLL7 which is required for USBPHY1. It also adds
the USB PHY and USB Controller clocks and the gates to enable them.
Acked-by: Jingchang Lu jingchang...@freescale.com
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/mach-imx/clk-vf610.c | 12
Add device tree node for usbmisc which controls the non-core USB
registers. This is required to use the property to disable the over-
current detection.
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/boot/dts/vf610.dtsi | 16 +++-
1 file changed, 15 insertions(+), 1
of the anadig registers.
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/boot/dts/vf610.dtsi | 46 +---
1 file changed, 43 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index 6a6190c..f36acb5 100644
to disable the over-current functionality of the USB
controller.
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/boot/dts/vf610-colibri.dts | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-colibri.dts
b/arch/arm/boot/dts/vf610-colibri.dts
index aecc7db
Am 2014-08-02 02:36, schrieb Peter Chen:
On Mon, Jul 28, 2014 at 04:57:29PM +0200, Stefan Agner wrote:
This adds support for the USB PHY in Vybrid VF610. We assume that
the disconnection without VBUS is also needed for Vybrid.
Tests showed, without MXS_PHY_NEED_IP_FIX, enumeration of devices
patches to enable USB on Tower
Stefan Agner (7):
ARM: dts: vf610: Add USB PHY and controller
ARM: imx: clk-vf610: Add USBPHY clocks
usb: phy: mxs: Add VF610 USB PHY support
ARM: dts: vf610: Add usbmisc for non-core registers
chipidea: usbmisc_imx: Add USB support for VF610 SoCs
ARM: dts
Add USB support for Freescale Vybrid tower. The USB hosts over-current
protection signal is not connected is not connected to the PHY's over-
current protection, hence we need to disable it.
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/boot/dts/vf610-twr.dts | 10 ++
1 file
This adds Vybrid VF610 SoC support. The IP is very similar to i.MX6,
however, the non-core registers are spread in two different register
areas. Hence we support multiple instances of the USB misc driver
and add the driver instance to the imx_usbmisc_data structure.
Signed-off-by: Stefan Agner
to disable the over-current functionality of the USB
controller.
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/boot/dts/vf610-colibri.dts | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-colibri.dts
b/arch/arm/boot/dts/vf610-colibri.dts
index aecc7db
of the anadig registers.
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/boot/dts/vf610.dtsi | 46 +---
1 file changed, 43 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index 6a6190c..f36acb5 100644
Add device tree node for usbmisc which controls the non-core USB
registers. This is required to use the property to disable the over-
current detection.
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/boot/dts/vf610.dtsi | 16 +++-
1 file changed, 15 insertions(+), 1
] usb usb1-port1: unable to enumerate USB device
Hence we also enable the MXS_PHY_NEED_IP_FIX flag.
Signed-off-by: Stefan Agner ste...@agner.ch
---
Documentation/devicetree/bindings/usb/mxs-phy.txt | 1 +
drivers/usb/phy/phy-mxs-usb.c | 6 ++
2 files changed, 7 insertions
This commit adds PLL7 which is required for USBPHY1. It also adds
the USB PHY and USB Controller clocks and the gates to enable them.
Acked-by: Jingchang Lu jingchang...@freescale.com
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/mach-imx/clk-vf610.c | 12
Am 2014-07-22 02:13, schrieb Peter Chen:
On Fri, Jul 18, 2014 at 07:01:36PM +0200, Stefan Agner wrote:
This patchset adds USB support for Vybrid VF610 SoC. It extends the
clock framework to support the USB PHY cocks, extends the device
tree files and adds support for the non-core registers
Am 2014-07-22 04:22, schrieb Shawn Guo:
On Fri, Jul 18, 2014 at 07:01:37PM +0200, Stefan Agner wrote:
This adds USB PHY and USB controller nodes. Vybrid SoCs have two
independent USB cores which each supports DR (dual role). However,
real OTG is not supported since the OTG ID pin
of the anadig registers.
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/boot/dts/vf610.dtsi | 46 +---
1 file changed, 43 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index 6a6190c..f6c3f02 100644
This adds support for the USB PHY in Vybrid VF610. We assume that
the disconnection without VBUS is also needed for Vybrid. For all
other flags, the presumption of innocence applies.
Signed-off-by: Stefan Agner ste...@agner.ch
---
drivers/usb/phy/phy-mxs-usb.c | 5 +
1 file changed, 5
This commit adds PLL7 which is required for USBPHY1. It also adds
the USB PHY and USB Controller clocks and the gates to enable them.
Signed-off-by: Stefan Agner ste...@agner.ch
---
All the main PLLs are currently turned on by boot ROM or boot loader, within
the kernel we only set the fixed
This adds Vybrid VF610 SoC support. The IP is very similar to i.MX6,
however the non-core registers are spread in two different register
areas. Hence we support multiple registers which are addressed by
the index of usbmisc.
Signed-off-by: Stefan Agner ste...@agner.ch
---
I tried first to create
investigating this.
The second USB controller, running in USB host mode, showed no
issues so far.
Stefan Agner (6):
ARM: dts: vf610: add USB PHY and controller
ARM: imx: clk-vf610: add USBPHY clocks
ARM: dts: vf610: Add usbmisc for non-core registers
chipidea: usbmisc_imx: Add USB support
Add device tree node for usbmisc which controls the non-core USB
registers. This is required to use the property to disable the over-
current detection.
Signed-off-by: Stefan Agner ste...@agner.ch
---
arch/arm/boot/dts/vf610.dtsi | 11 ++-
1 file changed, 10 insertions(+), 1 deletion
67 matches
Mail list logo
