Re: [PATCH v2 1/1] usb: xhci: do not create and register shared_hcd when USB3.0 is disabled

On Mon, Mar 5, 2018 at 5:22 PM, Thang Q. Nguyen <tqngu...@apm.com> wrote: > On Mon, Jan 29, 2018 at 5:24 PM, Thang Q. Nguyen <tqngu...@apm.com> wrote: >> From: Tung Nguyen <tungu...@apm.com> >> >> Currently, hcd->shared_hcd always creates and register

Re: [PATCH v2 1/1] usb: xhci: do not create and register shared_hcd when USB3.0 is disabled

On Mon, Jan 29, 2018 at 5:24 PM, Thang Q. Nguyen <tqngu...@apm.com> wrote: > From: Tung Nguyen <tungu...@apm.com> > > Currently, hcd->shared_hcd always creates and registers to the usb-core. > If, for some reasons, USB3 downstream port is disabled, no roothub

[PATCH v2 1/1] usb: xhci: do not create and register shared_hcd when USB3.0 is disabled

From: Tung Nguyen Currently, hcd->shared_hcd always creates and registers to the usb-core. If, for some reasons, USB3 downstream port is disabled, no roothub port for USB3.0 is found. This causes kernel to display an error: hub 2-0:1.0: config failed, hub doesn't have any

Re: [PATCH v1 1/1] usb: xhci: do not create and register shared_hcd when USB3.0 is disabled

Hi, On Sat, Dec 16, 2017 at 10:45 AM, Thang Q. Nguyen <tqngu...@apm.com> wrote: > From: Tung Nguyen <tungu...@apm.com> > > Currently, hcd->shared_hcd always creates and registers to the usb-core. > If, for some reasons, USB3 downstream port is disabled, no roothub

[PATCH v1 1/1] usb: xhci: do not create and register shared_hcd when USB3.0 is disabled

any ports! (err -19) This patch checks, creates and registers shared_hcd if USB3.0 downstream port is available. Signed-off-by: Tung Nguyen <tungu...@apm.com> Signed-off-by: Thang Q. Nguyen <tqngu...@apm.com> --- drivers/usb/host/xhci-mem.c | 2 +- drivers/usb/

Re: "hub doesn't have any ports" error message on the disabled USB addressable root hub port

On Wed, Nov 1, 2017 at 4:17 PM, Thang Q. Nguyen <tqngu...@apm.com> wrote: > Hi, > > On Mon, Oct 23, 2017 at 5:27 PM, Mathias Nyman > <mathias.ny...@linux.intel.com> wrote: >> On 23.10.2017 12:37, Thang Q. Nguyen wrote: >>> >>> Hi, >>> In ou

Re: "hub doesn't have any ports" error message on the disabled USB addressable root hub port

Hi, On Mon, Oct 23, 2017 at 5:27 PM, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 23.10.2017 12:37, Thang Q. Nguyen wrote: >> >> Hi, >> In our latest ARM64-based CPU, we use the DesignWare USB which is >> xHCI-compatible. For some reasons, we

"hub doesn't have any ports" error message on the disabled USB addressable root hub port

est what approach should be used to fix this issue? Thanks, Thang Q. Nguyen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] usb:xhci: update condition to select bus->sysdev from parent device

On Sat, Aug 19, 2017 at 10:43 AM, Thang Q. Nguyen <tqngu...@apm.com> wrote: > From: "Thang Q. Nguyen" <tqngu...@apm.com> > > For commit 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA > configuration"), sysdev points to devices known to the s

[PATCH v2 1/1] usb:xhci: update condition to select bus->sysdev from parent device

From: "Thang Q. Nguyen" <tqngu...@apm.com> For commit 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA configuration"), sysdev points to devices known to the system firmware or hardware for DMA parameters. However, the parent of the system firmware/hardware device

Re: [PATCH v5 1/1] usb:host:xhci support option to disable the xHCI USB2 HW LPM

On Tue, Aug 8, 2017 at 11:27 AM, Thang Q. Nguyen <tqngu...@apm.com> wrote: > XHCI specification 1.1 does not require xHCI-compliant controllers > to always enable hardware USB2 LPM. However, the current xHCI > driver always enable it when seeing HLC=1. > This patch supports a

[PATCH v5 1/1] usb:host:xhci support option to disable the xHCI USB2 HW LPM

in case user would like to disable this feature. For example, their xHCI controller has its USB2 HW LPM broken. Signed-off-by: Tung Nguyen <tungu...@apm.com> Signed-off-by: Thang Q. Nguyen <tqngu...@apm.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes since v4: - When HW

[PATCH v4 1/1] usb:host:xhci support option to disable the xHCI USB2 HW LPM

in case user would like to disable this feature. For example, their xHCI controller has its USB2 HW LPM broken. Signed-off-by: Tung Nguyen <tungu...@apm.com> Signed-off-by: Thang Q. Nguyen <tqngu...@apm.com> --- Changes since v3: - Bypass updating LPM parameters when HW LPM is optiona

Re: [PATCH v3 1/1] usb:host:xhci support option to disable the xHCI USB2 HW LPM

On Fri, Jun 23, 2017 at 10:02 AM, Thang Q. Nguyen <tqngu...@apm.com> wrote: > XHCI specification 1.1 does not require xHCI-compliant controllers > to always enable hardware USB2 LPM. However, the current xHCI > driver always enable it when seeing HLC=1. > This patch supports a

Re: [PATCH v1 1/1] usb:xhci: update condition to select bus->sysdev from parent device

On Tue, Jun 6, 2017 at 2:11 PM, Thang Q. Nguyen <tqngu...@apm.com> wrote: > For commit 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA > configuration"), sysdev points to devices known to the system firmware > or hardware for DMA parameters. > However, the parent

[PATCH v3 1/1] usb:host:xhci support option to disable the xHCI USB2 HW LPM

in case user would like to disable this feature. For example, their xHCI controller has its USB2 HW LPM broken. Signed-off-by: Tung Nguyen <tungu...@apm.com> Signed-off-by: Thang Q. Nguyen <tqngu...@apm.com> --- Changes since v2: - Change code to disable HW LPM as an option for user whi

Re: [v2 1/1] usb:host:xhci support option to disable xHCI 1.0 USB2 HW LPM

On Tue, Jun 13, 2017 at 8:12 PM, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 06.06.2017 09:33, Thang Q. Nguyen wrote: >> >> On Mon, Jun 5, 2017 at 9:33 PM, Mathias Nyman <mathias.ny...@intel.com> >> wrote: >>> >>> On 05.06.2017 15:57

[PATCH v1 1/1] usb:xhci: update condition to select bus->sysdev from parent device

patch updates the formulation to check this case in both DT and ACPI. Signed-off-by: Tung Nguyen <tungu...@apm.com> Signed-off-by: Thang Q. Nguyen <tqngu...@apm.com> --- drivers/usb/host/xhci-plat.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/

Re: [v2 1/1] usb:host:xhci support option to disable xHCI 1.0 USB2 HW LPM

On Mon, Jun 5, 2017 at 9:33 PM, Mathias Nyman <mathias.ny...@intel.com> wrote: > On 05.06.2017 15:57, Thang Q. Nguyen wrote: >> >> On Mon, Jun 5, 2017 at 6:14 PM, Mathias Nyman >> <mathias.ny...@linux.intel.com> wrote: >>> >>> On 20.05.201

Re: [v2 1/1] usb:host:xhci support option to disable xHCI 1.0 USB2 HW LPM

On Mon, Jun 5, 2017 at 6:14 PM, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 20.05.2017 10:24, Thang Q. Nguyen wrote: >> >> XHCI specification 1.1 does not require xHCI 1.0 compliant controllers >> to always enable hardware USB2 LPM. >> However, the

[v2 1/1] usb:host:xhci support option to disable xHCI 1.0 USB2 HW LPM

to disable this feature. This patch adds support to control disabling USB2 Hardware LPM via DT/ACPI attribute. Signed-off-by: Tung Nguyen <tungu...@apm.com> Signed-off-by: Thang Q. Nguyen <tqngu...@apm.com> --- Changes since v1: - Update DT/ACPI attribute and corresponding codes fro

Re: [v1 1/1] usb:host:xhci support option to disable xHCI 1.0 USB2 HW LPM

On Fri, May 19, 2017 at 5:30 AM, Rob Herring <r...@kernel.org> wrote: > On Sat, May 13, 2017 at 07:13:14AM +0700, Thang Q. Nguyen wrote: >> XHCI specification 1.1 does not require xHCI 1.0 compliant controllers >> to always enable hardware USB2 LPM. >> However, the

[v1 1/1] usb:host:xhci support option to disable xHCI 1.0 USB2 HW LPM

to disable this feature. This patch adds support to control disabling USB2 Hardware LPM via DT/ACPI attribute. Signed-off-by: Tung Nguyen <tungu...@apm.com> Signed-off-by: Thang Q. Nguyen <tqngu...@apm.com> --- Documentation/devicetree/bindings/usb/usb-xhci.txt |1 + drivers/usb/host

Re: usb:xhci: support disable usb2 LPM Remote Wakeup

On Mon, Dec 12, 2016 at 8:00 PM, Mathias Nyman <mathias.ny...@linux.intel.com> wrote: > On 12.12.2016 06:00, Thang Q. Nguyen wrote: >> >> On Sat, Dec 10, 2016 at 4:36 AM, Rob Herring <r...@kernel.org> wrote: >>> >>> On Sun, Dec 04, 2016 at 07:42:01PM

Re: usb:xhci: support disable usb2 LPM Remote Wakeup

Hi, On Mon, Dec 12, 2016 at 3:37 PM, Felipe Balbi <felipe.ba...@linux.intel.com> wrote: > > Hi, > > "Thang Q. Nguyen" <tqngu...@apm.com> writes: >> On Sat, Dec 10, 2016 at 4:36 AM, Rob Herring <r...@kernel.org> wrote: >>> On Sun, Dec 04, 201

Re: usb:xhci: support disable usb2 LPM Remote Wakeup

On Sat, Dec 10, 2016 at 4:36 AM, Rob Herring <r...@kernel.org> wrote: > On Sun, Dec 04, 2016 at 07:42:01PM +0700, Thang Q. Nguyen wrote: >> From: Thang Nguyen <tqngu...@apm.com> >> >> As per USB 2.0 link power management addendum ECN, table 1-2, page 4, >&

Re: usb:xhci: support disable usb2 LPM Remote Wakeup

Hi, Do you have any feedback on this? Thanks, Thang Q. Nguyen On Sun, Dec 4, 2016 at 7:42 PM, Thang Q. Nguyen <tqngu...@apm.com> wrote: > From: Thang Nguyen <tqngu...@apm.com> > > As per USB 2.0 link power management addendum ECN, table 1-2, page 4, > device or h

usb:xhci: support disable usb2 LPM Remote Wakeup

From: Thang Nguyen As per USB 2.0 link power management addendum ECN, table 1-2, page 4, device or host initiated via resume signaling; device-initiated resumes can be optionally enabled/disabled by software. This patch adds support to control enabling the USB2 RWE feature via

Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child

Thanks Grygorii for information. I checked but do not see dma_init_dev_from_parent is used in linux-next repository. Can you give me more information for what branch I can checkout to use it for USB DWC3? Thanks, Thang -- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

Re: [PATCH v3 1/2] usb:dwc3: Enable support for 64-bit system

.ba...@linux.intel.com> wrote: > > Hi, > > "Thang Q. Nguyen" <tqngu...@apm.com> writes: >> From: "Thang Q. Nguyen" <tqngu...@apm.com> >> >> Add 64-bit DMA operation support to the USB DWC3 driver. >> First attempt to set the coherent

[PATCH v3 0/2] usb:dwc3: Enable USB DWC3 support for 64-bit system

From: "Thang Q. Nguyen" <tqngu...@apm.com> When CONFIG_DMA_CMA is not set, the coherent mask is not set. These patches enable the USB DWC3 driver to set the coherent mask correctly by first set coherent DMA mask to 64-bit. If this failed, attempt again with 32-bit. In addition, p

[PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child

From: "Thang Q. Nguyen" <tqngu...@apm.com> The xhci-hcd child node needs to inherit archdata attribute to use dma_ops functions and attributes. This patch enables the USB DWC3 driver to pass archdata attributes to its xhci-hcd child node. Changes from v2: - None

[PATCH v3 1/2] usb:dwc3: Enable support for 64-bit system

From: "Thang Q. Nguyen" <tqngu...@apm.com> Add 64-bit DMA operation support to the USB DWC3 driver. First attempt to set the coherent DMA mask for 64-bit DMA. If that failed, attempt again with 32-bit DMA. Changes from v2: - None. Changes from v1: - Remove WAR

RE: [PATCH v2 1/2] usb:dwc3: Enable support for 64-bit system

Thanks Felipe for your feedback. I will re-generate patches and resend. Regards, Thang Q. Nguyen - -Original Message- From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] Sent: Thursday, March 10, 2016 3:15 PM To: Thang Q. Nguyen; Thang Q. Nguyen; Felipe Balbi; Greg Kroah-Hartman

RE: [PATCH v2 2/2] usb:dwc3: pass arch data to xhci-hcd child

Hi, I would like to ask if I need to update anything else for this change? Thanks, Thang Q. Nguyen - -Original Message- From: Thang Q. Nguyen [mailto:tqngu...@apm.com] Sent: Monday, January 25, 2016 9:26 PM To: Felipe Balbi; Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux-o

RE: [PATCH v2 1/2] usb:dwc3: Enable support for 64-bit system

Hi, I would like to ask if I need to update anything else for this change? Thanks, Thang Q. Nguyen - -Original Message- From: Thang Q. Nguyen [mailto:tqngu...@apm.com] Sent: Monday, January 25, 2016 9:26 PM To: Felipe Balbi; Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux-o

RE: [PATCH v2 1/2] usb:dwc3: Enable support for 64-bit system

Hi, Do you have any more feedback on this patch? Thanks, Thang Q. Nguyen - -Original Message- From: Thang Q. Nguyen [mailto:tqngu...@apm.com] Sent: Monday, January 25, 2016 9:26 PM To: Felipe Balbi; Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux-o...@vger.kernel.org; linux-ker

RE: [PATCH v2 2/2] usb:dwc3: pass arch data to xhci-hcd child

Hi, Do you have any feedback on this change? Regards, Thang Q. Nguyen - -Original Message- From: Thang Q. Nguyen [mailto:tqngu...@apm.com] Sent: Monday, January 25, 2016 9:26 PM To: Felipe Balbi; Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux-o...@vger.kernel.org; linux-ker

[PATCH v2 1/2] usb:dwc3: Enable support for 64-bit system

Add 64-bit DMA operation support to the USB DWC3 driver. First attempt to set the coherent DMA mask for 64-bit DMA. If that failed, attempt again with 32-bit DMA. Signed-off-by: Thang Q. Nguyen <tqngu...@apm.com> --- Changes from v1: - Remove WARN_ON if dma_mask is NULL drivers/us

[PATCH v2 2/2] usb:dwc3: pass arch data to xhci-hcd child

The xhci-hcd child node needs to inherit archdata attribute to use dma_ops functions and attributes. This patch enables the USB DWC3 driver to pass archdata attributes to its xhci-hcd child node. Signed-off-by: Thang Q. Nguyen <tqngu...@apm.com> --- Changes from v1: - None drive