Re: [PATCH V3 2/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-12-28 Thread Tomasz Figa
On 10.12.2014 17:39, Vivek Gautam wrote: USB and Power regulator on Exynos7 require gpios available in BUS1 pin controller block. So adding the BUS1 pinctrl support. Signed-off-by: Naveen Krishna Ch naveenkrishna...@gmail.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Tomasz Figa

Re: [PATCH V2 1/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-12-01 Thread Tomasz Figa
Hi Vivek, Please see my comments below. 2014-11-24 22:02 GMT+09:00 Vivek Gautam gautam.vi...@samsung.com: USB and Power regulator on Exynos7 require gpios available in BUS1 pin controller block. So adding the BUS1 pinctrl support. Signed-off-by: Naveen Krishna Ch naveenkrishna...@gmail.com

Re: [PATCH v2 1/4] dwc3: exynos: Add support for SCLK present on Exynos7

2014-10-13 Thread Tomasz Figa
Hi Anton, On 13.10.2014 06:54, Anton Tikhomirov wrote: Hi Vivek, Exynos7 also has a separate special gate clock going to the IP apart from the usual AHB clock. So add support for the same. As we discussed before, Exynos7 SoCs have 7 clocks to be controlled by the driver. Adding only sclk

Re: [PATCH 3/5] usb: phy: samsung: remove old USB 2.0 PHY driver

2014-08-18 Thread Tomasz Figa
On 18.08.2014 13:02, Bartlomiej Zolnierkiewicz wrote: On Thursday, August 14, 2014 08:07:40 PM Vivek Gautam wrote: On Thursday, August 14, 2014 7:55 PM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote There's one thing that I would want to comment here, since we don't have any

Re: [PATCH v2] drivers: phy: exynos-usb2: add support for Exynos 3250

2014-07-08 Thread Tomasz Figa
++ drivers/phy/phy-samsung-usb2.h| 2 ++ 5 files changed, 31 insertions(+), 8 deletions(-) Reviewed-by: Tomasz Figa t.f...@samsung.com -- Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH] drivers: phy: exynos-usb2: add support for Exynos 3250

2014-07-04 Thread Tomasz Figa
Hi Marek, Please see my comments inline. On 04.07.2014 14:13, Marek Szyprowski wrote: This patch adds support for Exynos3250 SoC to Exynos2USB PHY driver. Although Exynos3250 has only one device phy interface, the register layout and all operations that are required to get it enabled are

Re: [PATCH v6 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-09 Thread Tomasz Figa
changed, 118 insertions(+), 16 deletions(-) Reviewed-by: Tomasz Figa t.f...@samsung.com -- Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v12 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-05-09 Thread Tomasz Figa
/ehci-exynos.c | 129 +--- 2 files changed, 124 insertions(+), 20 deletions(-) Reviewed-by: Tomasz Figa t.f...@samsung.com -- Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-09 Thread Tomasz Figa
[CCing DT maintainers] On 08.05.2014 11:03, Vivek Gautam wrote: On Thu, May 8, 2014 at 11:35 AM, Vivek Gautam gautam.vi...@samsung.com wrote: Hi Sylwester, On Tue, May 6, 2014 at 7:57 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 28/04/14 08:17, Vivek Gautam wrote: Add a new

Re: [PATCH 1/2] ARM: dts: Enable USB 3503 hub on exynos5250-snow

2014-05-08 Thread Tomasz Figa
Hi Vivek, On 05.05.2014 14:30, Vivek Gautam wrote: The exynos5250-snow has a SMSC USB3503 connected in hardware only mode like a PHY. Enable support for it, and add necessary 'reset-gpio' for it. This is in correspondance to similar patch by Mark Brown 7c1b0ec ARM: dts: Enable USB hub on

Re: [PATCH 1/2] ARM: dts: Enable USB 3503 hub on exynos5250-snow

2014-05-08 Thread Tomasz Figa
On 08.05.2014 17:59, Andreas Färber wrote: Hello, Am 05.05.2014 14:30, schrieb Vivek Gautam: The exynos5250-snow has a SMSC USB3503 connected in hardware only mode like a PHY. Enable support for it, and add necessary 'reset-gpio' for it. This is in correspondance to similar patch by Mark

Re: [PATCH v5 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Tomasz Figa
Hi Vivek, This looks much better, but there still are some issues. Please see my comments inline. On 02.05.2014 14:47, Vivek Gautam wrote: Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any

Re: [PATCH v10 4/4] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-05-01 Thread Tomasz Figa
Hi Vivek, I believe the same comments as for the patch for ohci-exynos apply for this patch as well. Best regards, Tomasz On 30.04.2014 07:19, Vivek Gautam wrote: From: Kamil Debski k.deb...@samsung.com Add the phy provider, supplied by new Exynos-usb2phy using Generic phy framework.

Re: [PATCH v5 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-25 Thread Tomasz Figa
Hi Vivek, On 22.04.2014 10:03, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3 controller present on Exynos5 series of SoCs. Thereby, removing old phy-samsung-usb3 driver and related

Re: [PATCH v6 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-25 Thread Tomasz Figa
Hi Vivek, I have reviewed v5 without noticing this one, but I think most of the comments still apply. Best regards, Tomasz On 22.04.2014 13:24, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-16 Thread Tomasz Figa
Hi Vivek, On 15.04.2014 08:09, Vivek Gautam wrote: Hi Tomasz, On Thu, Apr 10, 2014 at 5:09 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: On Wed, Apr 9, 2014 at 7:03 PM, Tomasz Figa t.f...@samsung.com wrote: On 09.04.2014 13:49, Vivek Gautam wrote: Hi, On Wed, Apr 9, 2014 at 4:36 PM

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Tomasz Figa
On 14.04.2014 15:05, Kishon Vijay Abraham I wrote: On Monday 14 April 2014 05:35 PM, Vivek Gautam wrote: Hi Kishon, On Mon, Apr 14, 2014 at 5:24 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Wednesday 09 April 2014 04:36 PM, Tomasz Figa wrote: Hi Vivek, Please see my comments

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-09 Thread Tomasz Figa
Hi Vivek, Please see my comments inline. On 08.04.2014 16:36, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3 controller present on Exynos5 series of SoCs. Thereby, removing old

Re: [PATCH v4 2/5] dt: exynos5420: Enable support for USB 3.0 PHY controller

2014-04-09 Thread Tomasz Figa
-names = phy, ref, usb30_sclk_100m; As I mentioned in another reply, please make sure that usb30_sclk_100m isn't simply a gate clock for ref clock. Otherwise, Reviewed-by: Tomasz Figa t.f...@samsung.com -- Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [PATCH V4 3/5] dt: exynos5420: Enable support for DWC3 controller

2014-04-09 Thread Tomasz Figa
-by: Tomasz Figa t.f...@samsung.com -- Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V4 4/5] dt: exynos5250: Enable support for generic USB DRD phy

2014-04-09 Thread Tomasz Figa
; + }; + usb@1211 { compatible = samsung,exynos4210-ehci; reg = 0x1211 0x100; Reviewed-by: Tomasz Figa t.f...@samsung.com -- Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH V4 5/5] usb-phy: samsung-usb3: Remove older phy-samsung-usb3 driver

2014-04-09 Thread Tomasz Figa
driver and second removing the driver. After fixing this issue, Reviewed-by: Tomasz Figa t.f...@samsung.com -- Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off

2014-04-09 Thread Tomasz Figa
Hi, On 09.04.2014 14:24, Vivek Gautam wrote: Hi Sylwester, On Wed, Apr 9, 2014 at 5:41 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi Vivek, On 09/04/14 13:54, Vivek Gautam wrote: Adding support to enable/disable VBUS hooked to a gpio to enable vbus supply on the port. Does the

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-09 Thread Tomasz Figa
On 09.04.2014 13:49, Vivek Gautam wrote: Hi, On Wed, Apr 9, 2014 at 4:36 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Vivek, Please see my comments inline. On 08.04.2014 16:36, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses

Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-05 Thread Tomasz Figa
/samsung-usb2.txt create mode 100644 drivers/phy/phy-exynos4210-usb2.c create mode 100644 drivers/phy/phy-exynos4x12-usb2.c create mode 100644 drivers/phy/phy-samsung-usb2.c create mode 100644 drivers/phy/phy-samsung-usb2.h Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz

Re: [PATCH v9 2/4] phy: core: Add devm_of_phy_get to phy-core

2014-03-05 Thread Tomasz Figa
/phy/phy.h |8 2 files changed, 39 insertions(+) Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v6 8/8] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-03-03 Thread Tomasz Figa
On 05.02.2014 18:30, Olof Johansson wrote: On Wed, Feb 5, 2014 at 7:57 AM, Kamil Debski k.deb...@samsung.com wrote: Hi Olof, Thank you for your review. From: Olof Johansson [mailto:o...@lixom.net] Sent: Wednesday, January 29, 2014 9:55 PM Hi, On Wed, Jan 29, 2014 at 9:29 AM, Kamil Debski

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-02-14 Thread Tomasz Figa
Hi Vivek, On 14.02.2014 14:53, Vivek Gautam wrote: Changes from v2: 1) Added support for multiple PHYs (UTMI+ and PIPE3) and related changes in the driver structuring. I'm a bit skeptical about this separation. Can the PHY operate with just the UTMI+ or PIPE3 part enabled alone without

Re: [PATCH v3] phy: Add new Exynos5 USB 3.0 PHY driver

2014-02-06 Thread Tomasz Figa
Hi Vivek, This patch is just adding the PHY driver. I would also like to look at some users of it, to see how this works when put together. For now, please see my comments inline. On 20.01.2014 14:42, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The

Re: [PATCH v6 8/8] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-02-04 Thread Tomasz Figa
Hi Alan, On 29.01.2014 21:42, Alan Stern wrote: On Wed, 29 Jan 2014, Kamil Debski wrote: Change the phy provider used from the old one using the USB phy framework to a new one using the Generic phy framework. Signed-off-by: Kamil Debski k.deb...@samsung.com ---

Re: [PATCH v4 0/2] ohci and ehci-platform clks, phy and dt support

2014-01-12 Thread Tomasz Figa
Hi, [Cc'ing DT maintainers directly] On 12.01.2014 04:04, Tony Prisk wrote: On 12/01/14 11:30, Alan Stern wrote: On Fri, 10 Jan 2014, Hans de Goede wrote: Hi, On 01/11/2014 12:50 AM, Sergei Shtylyov wrote: Hello. On 01/11/2014 01:46 AM, Hans de Goede wrote: Here is v4 of my ohci and

[PATCH v6 6/9] phy: Add support for S5PV210 to the Exynos USB 2.0 PHY driver

2014-01-04 Thread Tomasz Figa
to the mailing list comments] Signed-off-by: Kamil Debski k.deb...@samsung.com [tomasz.f...@gmail.com: fix compilation issues and UPHYCLK register setup] Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- .../devicetree/bindings/phy/samsung-phy.txt| 1 + drivers/phy/Kconfig

Re: [PATCH v8 3/9] usb: gadget: s3c-hsotg: enable build for other platforms

2013-12-23 Thread Tomasz Figa
On Monday 23 of December 2013 10:25:57 Felipe Balbi wrote: On Thu, Dec 19, 2013 at 09:23:04AM -0500, Matt Porter wrote: Remove unused Samsung-specific machine include and Kconfig dependency on S3C. Signed-off-by: Matt Porter mpor...@linaro.org Reviewed-by: Markus Mayer

Re: [PATCH v3] usb: ohci-at91: fix irq and iomem resource retrieval

2013-12-05 Thread Tomasz Figa
guess it's just a matter of preference, so: Reviewed-by: Tomasz Figa tomasz.f...@gmail.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 3/3] usb: ohci-at91: use device managed clk retrieval

2013-12-04 Thread Tomasz Figa
2013/12/4 Douglas Gilbert dgilb...@interlog.com: On 13-12-04 04:21 PM, Alan Stern wrote: On Wed, 4 Dec 2013, boris brezillon wrote: The patches look fine to me. But only the 1/3 patch fixes a bug; the others merely change the resource management. Do you want me to split this series ?

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-10 Thread Tomasz Figa
Hi Vivek, On Thursday 31 of October 2013 13:15:41 Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3 controller present on Exynos5 series of SoCs. Signed-off-by: Vivek Gautam

Re: [PATCH 2/4] dt: exynos5250: Enable support for generic USB 3.0 phy

2013-11-10 Thread Tomasz Figa
Hi Vivek, On Thursday 31 of October 2013 13:15:42 Vivek Gautam wrote: Update device tree bindings for DWC3 controller and USB 3.0 phy present on Exynos 5250 SoC, to start using the phy driver based on generic phy framework. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com ---

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-10 Thread Tomasz Figa
Hi Kamil, Please see my comments inline. On Tuesday 05 of November 2013 17:13:19 Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski

Re: [PATCH v3 2/3] usb: ehci-s5p: Change to use phy provided by the generic phy framework

2013-11-10 Thread Tomasz Figa
Hi Kamil, On Tuesday 05 of November 2013 17:13:20 Kamil Debski wrote: Change the phy provider used from the old usb phy specific to a new one using the generic phy framework. I believe that until Exynos5250 also gets converted to the new PHY driver, support for the old USB PHY API should

Re: [PATCH v3 3/3] usb: s3c-hsotg: Use the new Exynos USB phy driver with the generic phy framework

2013-11-10 Thread Tomasz Figa
Hi Kamil, This patch is changing a DT binding, but you haven't updated relevant documentation. Please remember about it in next version. On Tuesday 05 of November 2013 17:13:21 Kamil Debski wrote: Change the used phy driver to the new Exynos USB phy driver that uses the generic phy framework.

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
Hi Kishon On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote: Hi, On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote: Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
On Wednesday 06 of November 2013 18:20:36 Kishon Vijay Abraham I wrote: Hi, On Wednesday 06 November 2013 05:08 PM, Tomasz Figa wrote: Hi Kishon On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote: Hi, On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-06 Thread Tomasz Figa
Hi David, On Wednesday 06 of November 2013 13:03:45 David Laight wrote: I just did a diff of registers in exynos 4210 and 4212 PHY drivers [1] and couldn't find that big a difference in register layout. Of course there are a few changes in HSIC bit fields and PHYFSEL but that's only

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-05 Thread Tomasz Figa
On Tuesday 05 of November 2013 12:50:18 Vivek Gautam wrote: Hi Kishon, On Mon, Nov 4, 2013 at 6:42 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Monday 04 November 2013 03:45 PM, Kamil Debski wrote: Hi Kishon, From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent:

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-04 Thread Tomasz Figa
Hi Kishon, On Monday 04 of November 2013 12:24:42 Kishon Vijay Abraham I wrote: Hi Vivek, On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3

Re: [PATCH v2 5/9] usb: gadget: s3c-hsotg: enable generic phy support

2013-11-02 Thread Tomasz Figa
Hi Matt. On Friday 01 of November 2013 15:45:54 Matt Porter wrote: Adds support for the generic PHY subsystem. Generic PHY support is probed and then the driver falls back to checking for an old style USB PHY and pdata if not found. Signed-off-by: Matt Porter matt.por...@linaro.org ---

Re: [PATCH v2 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-11-02 Thread Tomasz Figa
Hi Matt, On Friday 01 of November 2013 15:45:50 Matt Porter wrote: This adds a pair of APIs that allows the generic PHY subsystem to provide information on the PHY bus width. The PHY provider driver may use phy_set_bus_width() to set the bus width that the PHY supports. The controller driver

Re: [PATCH v2 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-11-02 Thread Tomasz Figa
On Saturday 02 of November 2013 13:47:09 Matt Porter wrote: On Sat, Nov 02, 2013 at 10:46:55PM +0530, Kishon Vijay Abraham I wrote: Hi Tomasz, On Saturday 02 November 2013 06:44 PM, Tomasz Figa wrote: Hi Matt, On Friday 01 of November 2013 15:45:50 Matt Porter wrote: This adds

Re: [PATCH v2 1/5] phy: Add new Exynos USB PHY driver

2013-10-28 Thread Tomasz Figa
Hi Kamil, On Monday 28 of October 2013 14:52:19 Kamil Debski wrote: Hi Kishon, Thank you for your review! I will answer your comments below. [snip] + + switch (drv-cfg-cpu) { + case TYPE_EXYNOS4210: + case TYPE_EXYNOS4212: Lets not add such cpu checks inside driver. Some

[PATCH] USB: OHCI: Check the overrides pointer for NULL in ohci_init_driver()

2013-09-28 Thread Tomasz Figa
dereference for drivers that do not need any overrides. This patch fixes the problem by dereferencing the passed pointer to ohci_driver_overrides struct only if it is non-NULL. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/usb/host/ohci-hcd.c | 10 ++ 1 file changed, 6

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-09-17 Thread Tomasz Figa
Hi Felipe, On Tuesday 17 of September 2013 10:36:16 Felipe Balbi wrote: Hi, On Tue, Aug 27, 2013 at 01:27:48PM -0700, Julius Werner wrote: *Ping!* Are there still unanswered concerns left with this patch? I hope my prior mails could clear up why I think that the PMU register

[PATCH] clk: samsung: pll: Use new registration method for PLL6552 and PLL6553

2013-08-20 Thread Tomasz Figa
This patch modifies PLL6552 and PLL6553 clock drivers to use recently added common Samsung PLL registration method. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/clk/samsung/clk-pll.c | 105 +- drivers/clk/samsung/clk-pll.h | 6 +-- 2

Re: [PATCH V5 6/6] USB: OHCI: make ohci-s3c2410 a separate driver

2013-08-17 Thread Tomasz Figa
); + +MODULE_DESCRIPTION(DRIVER_DESC); +MODULE_LICENSE(GPL); MODULE_ALIAS(platform:s3c2410-ohci); Looks good. Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-16 Thread Tomasz Figa
Hi Mike, On Monday 05 of August 2013 11:06:25 Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 10:01:36) On 07/23/13 08:49, Tomasz Figa wrote: This series is an attempt to move clock support on Samsung S3C64xx SoCs to Common Clock Framework. First, support for PLL types

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-16 Thread Tomasz Figa
On Friday 16 of August 2013 14:02:03 Mike Turquette wrote: Quoting Tomasz Figa (2013-08-16 03:44:44) Hi Mike, On Monday 05 of August 2013 11:06:25 Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 10:01:36) On 07/23/13 08:49, Tomasz Figa wrote: This series

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-13 Thread Tomasz Figa
On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote: Hi, On Wednesday 31 July 2013 11:45 AM, Felipe Balbi wrote: Hi, On Wed, Jul 31, 2013 at 11:14:32AM +0530, Kishon Vijay Abraham I wrote: IMHO we need a lookup method for PHYs, just like for clocks, regulators, PWMs

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-13 Thread Tomasz Figa
On Wednesday 14 of August 2013 00:19:28 Sylwester Nawrocki wrote: W dniu 2013-08-13 14:05, Kishon Vijay Abraham I pisze: On Tuesday 13 August 2013 05:07 PM, Tomasz Figa wrote: On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote: On Wednesday 31 July 2013 11:45 AM, Felipe

Re: [PATCH V4 6/6] USB: OHCI: make ohci-s3c2410 a separate driver

2013-08-10 Thread Tomasz Figa
Hi Manjunath, On Saturday 10 of August 2013 13:07:36 Manjunath Goudar wrote: Separate the Samsung OHCI S3C host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; it would be nice to

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-08 Thread Tomasz Figa
Hi Julius, On Thursday 08 of August 2013 11:06:54 Julius Werner wrote: I'm not sure I understand. The old documentation referred to the USBDEVICE_PHY_CONTROL and USBHOST_PHY_CONTROL registers for a phy, and your new version only refers to (usb device) PHY_CONTROL. Regardless of multiple

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-06 Thread Tomasz Figa
On Tuesday 06 of August 2013 12:47:51 Mike Turquette wrote: Quoting Tomasz Figa (2013-08-05 16:42:16) On Monday 05 of August 2013 12:02:16 Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 11:13:55) On 08/06/13 03:06, Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 10

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-06 Thread Tomasz Figa
On Wednesday 07 of August 2013 07:11:40 Kukjin Kim wrote: On 08/07/13 07:06, Tomasz Figa wrote: On Tuesday 06 of August 2013 12:47:51 Mike Turquette wrote: Quoting Tomasz Figa (2013-08-05 16:42:16) On Monday 05 of August 2013 12:02:16 Mike Turquette wrote: Quoting Kukjin Kim (2013-08

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-05 Thread Tomasz Figa
On Monday 05 of August 2013 12:02:16 Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 11:13:55) On 08/06/13 03:06, Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 10:01:36) On 07/23/13 08:49, Tomasz Figa wrote: This series is an attempt to move clock support on Samsung

Re: [PATCH v2 6/8] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-07-31 Thread Tomasz Figa
Alan, Greg, On Tuesday 23 of July 2013 01:49:23 Tomasz Figa wrote: This patch modifies the ohci-s3c2410 driver to prepare and unprepare clocks in addition to enabling and disabling, since it is required by common clock framework. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com

Re: [PATCH v3 2/8] clk: samsung: pll: Add support for PLL6552 and PLL6553

2013-07-28 Thread Tomasz Figa
On Sunday 28 of July 2013 13:30:51 Mark Brown wrote: On Wed, Jul 24, 2013 at 01:52:19AM +0200, Tomasz Figa wrote: Changes since v2: - Reworked to use new PLL registration method introduced by Yadwinder Singh Brar's patch series: ( http://thread.gmane.org

Re: [PATCH v2 1/8] clk: mux: Add support for read-only muxes.

2013-07-27 Thread Tomasz Figa
Hi Mike, On Tuesday 23 of July 2013 01:49:18 Tomasz Figa wrote: Some platforms have read-only clock muxes that are preconfigured at reset and cannot be changed at runtime. This patch extends mux clock driver to allow handling such read-only muxes by adding new CLK_MUX_READ_ONLY mux flag

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
Hi Alan, On Monday 22 of July 2013 10:44:39 Alan Stern wrote: On Mon, 22 Jul 2013, Kishon Vijay Abraham I wrote: The PHY and the controller it is attached to are both physical devices. The connection between them is hardwired by the system manufacturer and cannot be

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
[Fixed address of devicetree mailing list and added more people on CC.] For reference, full thread can be found under following link: http://thread.gmane.org/gmane.linux.ports.arm.kernel/252813 Best regards, Tomasz On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, On Monday 22

Re: [PATCH 6/6] USB: OHCI: make ohci-s3c2410 a separate driver

2013-07-23 Thread Tomasz Figa
Hi Manjunath, Please see some comments inline. On Monday 22 of July 2013 14:49:30 Manjunath Goudar wrote: Separate the Samsung OHCI S3C host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels

Re: [PATCH v2 1/8] clk: mux: Add support for read-only muxes.

2013-07-23 Thread Tomasz Figa
Hi Sergei, On Tuesday 23 of July 2013 15:22:44 Sergei Shtylyov wrote: Hello. On 23-07-2013 3:49, Tomasz Figa wrote: Some platforms have read-only clock muxes that are preconfigured at reset and cannot be changed at runtime. This patch extends mux clock driver to allow handling such read

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 10:37:05 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here. Okay. Are PHYs _always_ platform devices? They can be i2c, spi or any

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 09:18:46 Greg KH wrote: On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from, then you could have just passed the original phy pointer

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids, look back earlier in this thread for details about that.)

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 15:36:00 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: IMHO it would be better if you provided some code example, but let's try to check if I understood you correctly. 8

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 11:04:14 Greg KH wrote: On Tue, Jul 23, 2013 at 07:48:11PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 16:53:55 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: That's what I was going to suggest too. The struct phy is defined in the board file, which already knows about all the PHYs that exist in the system. (Or perhaps it is allocated dynamically

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 13:50:07 Greg KH wrote: On Tue, Jul 23, 2013 at 10:07:52PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due

[PATCH v3 2/8] clk: samsung: pll: Add support for PLL6552 and PLL6553

2013-07-23 Thread Tomasz Figa
This patch adds support for PLL6552 and PLL6553 PLLs present on Samsung S3C64xx SoCs. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Acked-by: Mike Turquette mturque...@linaro.org --- drivers/clk/samsung/clk-pll.c | 77 +++ drivers/clk/samsung/clk-pll.h

[PATCH v3 3/8] clk: samsung: Add clock driver for S3C64xx SoCs

2013-07-23 Thread Tomasz Figa
This patch adds new, Common Clock Framework-based clock driver for Samsung S3C64xx SoCs. The driver is just added, without actually letting the platforms use it yet, since this requires more intermediate steps. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Acked-by: Mike Turquette mturque

[PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-07-22 Thread Tomasz Figa
board (Mini6410-compatible): Tested-by: Tomasz Figa tomasz.f...@gmail.com For v1: Acked-by: Mike Turquette mturque...@linaro.org Changes since v1: - added patch for read-only muxes, - exported configurable muxes and dividers, - defined mout_syncmux as read-only mux, - in DT-enabled case

[PATCH v2 2/8] clk: samsung: pll: Add support for PLL6552 and PLL6553

2013-07-22 Thread Tomasz Figa
This patch adds support for PLL6552 and PLL6553 PLLs present on Samsung S3C64xx SoCs. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Acked-by: Mike Turquette mturque...@linaro.org --- drivers/clk/samsung/clk-pll.c | 160 ++ drivers/clk/samsung/clk-pll.h

[PATCH v2 4/8] ARM: SAMSUNG: Add soc_is_s3c6400/s3c6410 macros

2013-07-22 Thread Tomasz Figa
This patch adds soc_is_s3c6400() and soc_is_s3c6410() macros that allow to distinguish between specific SoCs from s3c64xx series that is needed to handle differences between them. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/plat-samsung/include/plat/cpu.h | 4 1 file

[PATCH v2 3/8] clk: samsung: Add clock driver for S3C64xx SoCs

2013-07-22 Thread Tomasz Figa
This patch adds new, Common Clock Framework-based clock driver for Samsung S3C64xx SoCs. The driver is just added, without actually letting the platforms use it yet, since this requires more intermediate steps. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Acked-by: Mike Turquette mturque

[PATCH v2 7/8] ARM: s3c64xx: Migrate clock handling to Common Clock Framework

2013-07-22 Thread Tomasz Figa
This patch migrates the s3c64xx platform to use the new clock driver using Common Clock Framework. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/Kconfig | 2 +- arch/arm/mach-s3c64xx/Makefile| 2 +- arch/arm/mach-s3c64xx/common.c| 21

[PATCH v2 5/8] ARM: s3c64xx: dma: Use clk_prepare_enable/clk_disable_unprepare

2013-07-22 Thread Tomasz Figa
This patch modifies s3c64xx DMA driver to prepare and unprepare clocks in addition to enableind and disabling, since it is required by common clock framework. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/mach-s3c64xx/dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v2 8/8] ARM: s3c64xx: Remove old clock management code

2013-07-22 Thread Tomasz Figa
This patch removes old clock management code of S3C64xx, since the platform has been already moved to the new clock driver using Common Clock Framework. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/mach-s3c64xx/clock.c | 1007 --- arch/arm

Re: [PATCH v2 6/8] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-07-22 Thread Tomasz Figa
On Monday 22 of July 2013 21:15:12 Fabio Estevam wrote: On Mon, Jul 22, 2013 at 8:49 PM, Tomasz Figa tomasz.f...@gmail.com wrote: dev_dbg(dev-dev, s3c2410_start_hc:\n); - clk_enable(usb_clk); + clk_prepare_enable(usb_clk); clk_prepare_enable may fail, so you

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Tomasz Figa
Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't pass strings around, pass pointers. If you have platform data you

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Tomasz Figa
On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote: Hi, On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-07-12 Thread Tomasz Figa
the host-side HSIC initialization is also there already. I think if you think of it as reset whatever is on the other side of this PHY, it's okay to put it as an optional feature into the PHY driver. CC'ed Tomasz Figa, Dongjin Kim, Yulgon Kim Hi Tomasz, Dongjin, Julius Werner wants

[PATCH 1/4] usb: gadget: s3c-hsotg: Allow driver instantiation using device tree

2013-06-25 Thread Tomasz Figa
This patch adds OF match table to the driver to allow instantiating it using device tree. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/usb/samsung-hsotg.txt | 40 ++ drivers/usb/gadget

[PATCH 3/4] ARM: dts: exynos4: Add nodes for USB PHY block

2013-06-25 Thread Tomasz Figa
This patch adds device tree nodes for USB OTG PHYs of Exynos4210 and Exynos4x12 SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4210.dtsi | 15 +++ arch/arm/boot/dts/exynos4x12.dtsi | 15

[PATCH 0/4] Add support for Samsung HSOTG on DT-enabled platforms

2013-06-25 Thread Tomasz Figa
-by: Tomasz Figa t.f...@samsung.com Tomasz Figa (4): usb: gadget: s3c-hsotg: Allow driver instantiation using device tree ARM: dts: exynos4: Add node for hsotg ARM: dts: exynos4: Add nodes for USB PHY block ARM: dts: exynos4210-trats: Enable USB gadget functionality .../devicetree/bindings/usb

[PATCH 4/4] ARM: dts: exynos4210-trats: Enable USB gadget functionality

2013-06-25 Thread Tomasz Figa
This patch adds device tree nodes necessary to enable USB gadget functionality on Exynos4210-based Trats board. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4210-trats.dts | 10 ++ 1 file changed, 10

[PATCH 2/4] ARM: dts: exynos4: Add node for hsotg

2013-06-25 Thread Tomasz Figa
This patch adds device tree node for USB HSOTG controller present on Exynos4 SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot

Re: [PATCH 1/4] usb: gadget: s3c-hsotg: Allow driver instantiation using device tree

2013-06-25 Thread Tomasz Figa
On Tuesday 25 of June 2013 23:46:32 Felipe Balbi wrote: On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote: This patch adds OF match table to the driver to allow instantiating it using device tree. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH 1/4] usb: gadget: s3c-hsotg: Allow driver instantiation using device tree

2013-06-25 Thread Tomasz Figa
On Wednesday 26 of June 2013 00:00:44 Felipe Balbi wrote: On Tue, Jun 25, 2013 at 10:57:06PM +0200, Tomasz Figa wrote: On Tuesday 25 of June 2013 23:46:32 Felipe Balbi wrote: On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote: This patch adds OF match table to the driver

Re: [PATCH 0/7] Common Clock Framework support for Samsung S3C64xx

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 23:17:06 Kukjin Kim wrote: On 06/06/13 08:57, Tomasz Figa wrote: This series is an attempt to move clock support on Samsung S3C64xx SoCs to Common Clock Framework. Looks good :) Thanks. First, support for PLL types present on S3C64xx SoCs is added

Re: [PATCH V2 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-13 Thread Tomasz Figa
Hi Manjunath, On Thursday 13 of June 2013 14:46:24 Manjunath Goudar wrote: Suspend scenario in case of ohci-exynos glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in exynos_ohci_suspend() will ensure proper

Re: [PATCH 2/7] clk: samsung: Add clock driver for S3C64xx SoCs

2013-06-12 Thread Tomasz Figa
Hi Mike, On Tuesday 11 of June 2013 19:54:51 Mike Turquette wrote: Quoting Tomasz Figa (2013-06-05 16:57:26) This patch adds new, Common Clock Framework-based clock driver for Samsung S3C64xx SoCs. The driver is just added, without actually letting the platforms use it yet, since

  1   2   >