Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset

On 05/04/2016 06:26 PM, Thierry Reding wrote: On Wed, May 04, 2016 at 07:57:10AM -0700, Greg Kroah-Hartman wrote: On Wed, May 04, 2016 at 04:39:59PM +0200, Thierry Reding wrote: From: Thierry Reding There are three EHCI controllers on Tegra SoCs, each with its own reset

Re: [PATCH v2 4/4] USB: PHY: tegra: Call tegra_usb_phy_close only on device removal

On 10/07/14 16:48, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, On Fri, Jul 04, 2014 at 04:09:39AM +0300, Tuomas Tynkkynen wrote: tegra_usb_phy_close() is supposed to undo the effects of tegra_usb_phy_init(). It is also currently added as the USB PHY shutdown callback, which

Re: [PATCH v2 2/4] ARM: tegra: Add resets has-utmi-pad-registers flag to all USB PHYs

Thierry, Since Stephen's on a vacation, I'd like to double-check with you that the DT changes looks good. Greg has applied these to the USB tree today. Thanks, Tuomas On 04/07/14 04:09, Tuomas Tynkkynen wrote: Add new properties to all of the Tegra PHYs that are now required according

[PATCH v2 1/4] USB: tegra: Add resets has-utmi-pad-registers flag to the PHY binding

, potentially buggy behaviour. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- v2 changes: new patch, didn't exist in v1 .../bindings/usb/nvidia,tegra20-usb-phy.txt|8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra20

[PATCH v2 4/4] USB: PHY: tegra: Call tegra_usb_phy_close only on device removal

to warnings about unbalanced regulator_disable if the EHCI driver is unbound and bound again at runtime. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- v2 changes: none drivers/usb/phy/phy-tegra-usb.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/phy

[PATCH v2 2/4] ARM: tegra: Add resets has-utmi-pad-registers flag to all USB PHYs

Add new properties to all of the Tegra PHYs that are now required according to the binding. In order to stay compatible with old device trees, the USB drivers will still function without these reset properties but with the old, potentially buggy behaviour. Signed-off-by: Tuomas Tynkkynen ttynkky

[PATCH v2 0/4] Tegra USB probe order issue fix

4. Thanks, Tuomas. Tuomas Tynkkynen (4): USB: tegra: Add resets has-utmi-pad-registers flag to the PHY binding ARM: tegra: Add resets has-utmi-pad-registers flag to all USB PHYs USB: EHCI: tegra: Fix probe order issue leading to broken USB USB: PHY: tegra: Call tegra_usb_phy_close

[PATCH v2 3/4] USB: EHCI: tegra: Fix probe order issue leading to broken USB

this commit, so we'll dev_warn() them, but the driver will still keep probing successfully. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- v2 changes: assume we can find the usb1 reset from the PHY DT node, don't fail if it's not found but just issue a warning drivers/usb/host

[PATCH 0/3] Tegra USB probe order issue fix

. Thanks, Tuomas Tuomas Tynkkynen (3): reset: Re-export of_reset_control_get USB: EHCI: tegra: Fix probe order issue leading to broken USB USB: PHY: tegra: Call tegra_usb_phy_close only on device removal drivers/usb/host/ehci-tegra.c | 111 ++-- drivers/usb

[PATCH 3/3] USB: PHY: tegra: Call tegra_usb_phy_close only on device removal

to warnings about unbalanced regulator_disable if the EHCI driver is unbound and bound again at runtime. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b

[PATCH 2/3] USB: EHCI: tegra: Fix probe order issue leading to broken USB

again. The really ugly part is that the EHCI controllers don't have a reset control phandle to the 1st controller, so we have to do some device tree groveling to find the phandle to the 1st controller. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 111

[PATCH 1/3] reset: Re-export of_reset_control_get

Commit b424080a9e086e683ad5fdc624a7cf3c024e0c0f (reset: Add optional resets and stubs) accidentally dropped the declaration of of_reset_control_get from include/linux/reset.h. Add it back to the header. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- include/linux/reset.h | 8

[PATCH] USB: EHCI: tegra: Fix use-after-free in .remove()

The tegra_ehci_hcd structure is located in the private space allocated by the core USB code so it must not be accessed after the HCD is freed. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 2nd RESEND] clk: tegra30: Don't wait for PLL_U lock bit

The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com Acked

[PATCH 2nd RESEND] Clock changes for Tegra30 USB Host support

: Added swarren's Tested-by Acked-by. Tuomas Tynkkynen (1): clk: tegra30: Don't wait for PLL_U lock bit drivers/clk/tegra/clk-tegra30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.1.5 -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

[PATCH RESEND] clk: tegra30: Don't wait for PLL_U lock bit

The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/clk/tegra/clk-tegra30.c | 2 +- 1 file

[PATCH v3 5/6] usb: phy: tegra: Program new PHY parameters

value can vary between invidual boards. The boolean property nvidia,xcvr-setup-use-fuses can be used to enable this behaviour. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com --- v2: Don't touch new PHY

[PATCH v3 6/6] usb: host: tegra: Tegra30 support

to describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com --- v3: Removed useless cast drivers/usb/host/ehci-tegra.c | 34 +- 1 file changed

[PATCH v3 4/6] Documentation: New DT parameters for tegra30-usb-phy

Document the new device tree parameters for Tegra30 USB PHY. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com --- .../devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt| 15 --- 1

[PATCH v3 2/6] usb: phy: tegra: Fix wrong PHY parameters

not set properly Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com --- v2: Change register bitmasks to not contain shifted-out bits drivers/usb/phy/phy-tegra-usb.c | 20 ++-- 1 file changed

[PATCH v3 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

shifted-out bits Changed the order of patches 4 5 Patch 5: Don't touch new PHY params under T20 v3 diff: Patch 6: Removed useless cast Added Stephen's Reviewed-by Tested-by to all patches Tuomas Tynkkynen (6): usb: host: add has_tdi_phy_lpm capability bit usb: phy: tegra: Fix wrong PHY parameters

[PATCH v3 1/6] usb: host: add has_tdi_phy_lpm capability bit

(disociate chipidea PHY low power suspend control from hostpc) Inspired-by: Matthieu CASTET matthieu.cas...@parrot.com Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Acked-by: Alan Stern st...@rowland.harvard.edu Tested-by: Stephen Warren swar...@nvidia.com Reviewed-by: Stephen Warren swar

[PATCH v3 3/6] usb: phy: tegra: Tegra30 support

for this will be added in the next patch. The new tegra_phy_soc_config structure is added to describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com --- drivers/usb/phy

[PATCH v2 5/6] usb: phy: tegra: Program new PHY parameters

value can vary between invidual boards. The boolean property nvidia,xcvr-setup-use-fuses can be used to enable this behaviour. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- v2: Don't touch new PHY params under T20 v2: Change register bitmasks to not contain shifted-out bits drivers/usb/phy

[PATCH v2 3/6] usb: phy: tegra: Tegra30 support

for this will be added in the next patch. The new tegra_phy_soc_config structure is added to describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 121 +- include/linux/usb

[PATCH v2 6/6] usb: host: tegra: Tegra30 support

to describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index

[PATCH v2 2/6] usb: phy: tegra: Fix wrong PHY parameters

not set properly Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- v2: Change register bitmasks to not contain shifted-out bits drivers/usb/phy/phy-tegra-usb.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers

[PATCH v2 4/6] Documentation: New DT parameters for tegra30-usb-phy

Document the new device tree parameters for Tegra30 USB PHY. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- .../devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt| 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v2 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

shifted-out bits Changed the order of patches 4 5 Patch 5: Don't touch new PHY params under T20 Tuomas Tynkkynen (6): usb: host: add has_tdi_phy_lpm capability bit usb: phy: tegra: Fix wrong PHY parameters usb: phy: tegra: Tegra30 support Documentation: New DT parameters for tegra30-usb-phy

[PATCH v2 1/6] usb: host: add has_tdi_phy_lpm capability bit

(disociate chipidea PHY low power suspend control from hostpc) Inspired-by: Matthieu CASTET matthieu.cas...@parrot.com Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Acked-by: Alan Stern st...@rowland.harvard.edu --- v2: Add Alan's ack drivers/usb/chipidea/host.c | 1 + drivers/usb/host/ehci

Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

On 08/06/2013 09:35 PM, Sergei Shtylyov wrote: Hello. [...] +match = of_match_device(tegra_ehci_of_match, pdev-dev); +if (!match) { +dev_err(pdev-dev, Error: No device match found\n); +return -ENODEV; +} +soc_config = (struct tegra_ehci_soc_config

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

On 08/05/2013 09:38 AM, Prashant Gaikwad wrote: On Thursday 01 August 2013 02:34 AM, Stephen Warren wrote: On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove

Re: [PATCH 4/6] usb: phy: tegra: Program new PHY parameters

On 08/02/2013 12:16 AM, Stephen Warren wrote: On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: The Tegra30 TRM recommends configuration of certain PHY parameters for optimal quality. Program the following registers based on device tree parameters: - UTMIP_XCVR_HSSLEW: HS slew rate control

Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters

On 08/02/2013 12:09 AM, Stephen Warren wrote: On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: Some of the PHY parameters are not set according to the TRMs: - UTMIP_FS_PREABMLE_J should be set, not cleared - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set - UTMIP_PD_CHRG should be set

Re: [PATCH 1/6] usb: host: add has_tdi_phy_lpm capability bit

On 08/01/2013 11:05 AM, Matthieu CASTET wrote: Hi, Le Wed, 31 Jul 2013 18:41:57 +0100, Tuomas Tynkkynen ttynkky...@nvidia.com a écrit : The has_hostpc capability bit indicates that the host controller has the HOSTPC register extensions, but at the same time enables clock disabling power

[PATCH v2 2/2] ARM: dts: USB for Tegra114 Dalmore

From: Mikko Perttunen mperttu...@nvidia.com Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- arch/arm/boot/dts/tegra114-dalmore.dts | 9 +

[PATCH v2 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

Add device tree entries for the 3 USB controllers and PHYs and enable the third controller on Cardhu and Beaver boards. Fix VBUS regulator entries on Beaver. The GPIO pins were wrong. Also, internal pullups need to be enabled on those pins. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com

Re: [PATCH 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

On 08/01/2013 01:13 AM, Stephen Warren wrote: On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: Add device tree entries for the 3 USB controllers and PHYs and enable the third controller on Cardhu and Beaver boards. Fix VBUS regulator entries on Beaver. The GPIO pins were wrong. That much

[PATCH 1/6] usb: host: add has_tdi_phy_lpm capability bit

(disociate chipidea PHY low power suspend control from hostpc) Inspired-by: Matthieu CASTET matthieu.cas...@parrot.com Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/chipidea/host.c | 1 + drivers/usb/host/ehci-hub.c | 14 +++--- drivers/usb/host/ehci.h | 1 + 3

[PATCH] Clock changes for Tegra30 USB Host support

Hi all, This patch is required for USB support on Tegra30 due to a likely hardware bug in the PLL_U oscillator which clocks the USB complex. Tuomas Tynkkynen (1): clk: tegra30: Don't wait for PLL_U lock bit drivers/clk/tegra/clk-tegra30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] clk: tegra30: Don't wait for PLL_U lock bit

The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/clk/tegra/clk-tegra30.c | 2 +- 1 file

[PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

From: Mikko Perttunen mperttu...@nvidia.com Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- arch/arm/boot/dts/tegra114-dalmore.dts | 9 +

[PATCH 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

an regulator entry for that. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- arch/arm/boot/dts/tegra30-beaver.dts | 23 +- arch/arm/boot/dts/tegra30-cardhu.dtsi | 9 arch/arm/boot/dts/tegra30.dtsi| 86 +++ 3 files changed, 116 insertions

[PATCH 6/6] usb: host: tegra: Tegra30 support

to describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index

[PATCH 0/2] Device tree changes for Tegra30 and Tegra114 USB Host support

Hi all, Here's the device tree changes required for USB Host support on Tegra30 and Tegra114. This enables USB Host on the Cardhu's dock connector port and on the single built-in A-ports on Dalmore and Beaver, Mikko Perttunen (1): ARM: dts: USB for Tegra114 Dalmore Tuomas Tynkkynen (1): ARM

[PATCH 5/6] Documentation: New DT parameters for tegra30-usb-phy

Document the new device tree parameters for Tegra30 USB PHY. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- .../devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt| 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters

not set properly Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index 01c30ff..936b4a2 100644

[PATCH 4/6] usb: phy: tegra: Program new PHY parameters

value can vary between invidual boards. The boolean property nvidia,xcvr-setup-use-fuses can be used to enable this behaviour. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 75 +-- include/linux/usb/tegra_usb_phy.h

[PATCH 3/6] usb: phy: tegra: Tegra30 support

for this will be added in the next patch. The new tegra_phy_soc_config structure is added to describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 121 +- include/linux/usb

[PATCH 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

controller doesn't support those. The rest are changes to our PHY and EHCI drivers to deal with a few changed register addresses and a few additional PHY parameters that need to be set for proper signal quality. Tuomas Tynkkynen (6): usb: host: add has_tdi_phy_lpm capability bit usb: phy: tegra: Fix

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

Hello, On 31/07/13 21:18, Sergei Shtylyov wrote: Hello. On 07/31/2013 09:42 PM, Tuomas Tynkkynen wrote: From: Mikko Perttunen mperttu...@nvidia.com Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. I would have

[PATCH v3 9/9] usb: phy: tegra: Use DT helpers for dr_mode

Use the new of_usb_get_dr_mode helper function for parsing dr_mode from the device tree. Also replace the usage of the custom tegra_usb_phy_mode enum with the standard enum. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen

[PATCH v3 3/9] usb: tegra: host: Remove references to plat data

Platform data is not used in tegra-ehci anymore, so remove all references to it. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 8 1 file changed, 8

[PATCH v3 7/9] usb: phy: tegra: Remove custom PHY locating APIs

The Tegra EHCI driver is no longer using these custom functions, so they can be removed. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 24

[PATCH v3 4/9] ARM: tegra: Remove USB platform data

USB-related platform data is not used anymore in the Tegra USB drivers, so remove all of it. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com Acked-by: Stephen Warren swar...@nvidia.com --- arch/arm

[PATCH v3 8/9] usb: phy: tegra: Use DT helpers for phy_type

Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 12 1

[PATCH v3 1/9] usb: phy: tegra: Remove unnecessary 'dev' field

struct usb_phy already has a field for the device pointer, so this unnecessary field can be removed. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com --- v3 diff: A whitespace change in v3 of Mikko's

[PATCH v3 2/9] usb: host: tegra: Remove leftover code

be safe to do so. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/usb

[PATCH v3 5/9] usb: phy: tegra: Register as an USB PHY.

Register the Tegra PHY device instances with the PHY subsystem so that the Tegra EHCI driver can locate a PHY via the standard APIs. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com --- v2 diff: Do

Re: [PATCH v3 8/9] usb: phy: tegra: Use DT helpers for phy_type

Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com --- Here's the version with switch(). drivers/usb/phy/phy

[PATCH] usb: phy: tegra: Use switch instead of if-else

Use switch() instead of if-else when checking for the PHY type. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- Ah :). Here. drivers/usb/phy/phy-tegra-usb.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb

[PATCH v2 0/9] Tegra USB cleanup series

last thing in .probe Patch 9: Default to host mode if the property didn't exist Tuomas Tynkkynen (9): usb: phy: tegra: Remove unnecessary 'dev' field usb: host: tegra: Remove leftover code usb: tegra: host: Remove references to plat data ARM: tegra: Remove USB platform data usb: phy

[PATCH v2 6/9] usb: host: tegra: Locate a PHY via standard API

Use devm_get_phy_by_phandle to get a PHY device instead of the custom Tegra functions. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb

[PATCH v2 7/9] usb: phy: tegra: Remove custom PHY locating APIs

The Tegra EHCI driver is no longer using these custom functions, so they can be removed. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 24 include/linux/usb/tegra_usb_phy.h | 2 -- 2 files changed, 26 deletions(-) diff

[PATCH v2 9/9] usb: phy: tegra: Use DT helpers for dr_mode

Use the new of_usb_get_dr_mode helper function for parsing dr_mode from the device tree. Also replace the usage of the custom tegra_usb_phy_mode enum with the standard enum. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 24

[PATCH v2 8/9] usb: phy: tegra: Use DT helpers for phy_type

Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b

[PATCH v2 5/9] usb: phy: tegra: Register as an USB PHY.

Register the Tegra PHY device instances with the PHY subsystem so that the Tegra EHCI driver can locate a PHY via the standard APIs. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 17 + 1 file changed, 17 insertions(+) diff --git

[PATCH v2 1/9] usb: phy: tegra: Remove unnecessary 'dev' field

struct usb_phy already has a field for the device pointer, so this unnecessary field can be removed. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 27 +++ include/linux/usb/tegra_usb_phy.h | 1 - 2 files changed, 15

[PATCH v2 2/9] usb: host: tegra: Remove leftover code

be safe to do so. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 14c1f35..06e8feb 100644 --- a/drivers

[PATCH v2 4/9] ARM: tegra: Remove USB platform data

USB-related platform data is not used anymore in the Tegra USB drivers, so remove all of it. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- arch/arm/mach-tegra/tegra.c | 38 + include/linux/platform_data/tegra_usb.h | 32

[PATCH v2 3/9] usb: tegra: host: Remove references to plat data

Platform data is not used in tegra-ehci anymore, so remove all references to it. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index

[PATCH 0/9] Tegra USB cleanup series

Hi, Here's a few cleanup patches for the Tegra USB drivers, to be applied on top of Mikko's two patch sets. It mostly deals with removing all usage of platform data and using standard helpers and enums instead of Tegra-specific ones. Tuomas Tynkkynen (9): usb: phy: tegra: Remove unnecessary

[PATCH 5/9] usb: phy: tegra: Register as an USB PHY.

Register the Tegra PHY device instances with the PHY subsystem so that the Tegra EHCI driver can locate a PHY via the standard APIs. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH 1/9] usb: phy: tegra: Remove unnecessary 'dev' field

struct usb_phy already has a field for the device pointer, so this unnecessary field can be removed. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 27 +++ include/linux/usb/tegra_usb_phy.h | 1 - 2 files changed, 15

[PATCH 3/9] usb: tegra: host: Remove references to plat data

Platform data is not used in tegra-ehci anymore, so remove all references to it. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index

[PATCH 2/9] usb: host: tegra: Remove leftover code

be safe to do so. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 14c1f35..06e8feb 100644 --- a/drivers

[PATCH 4/9] ARM: tegra: Remove USB platform data

USB-related platform data is not used anymore in the Tegra USB drivers, so remove all of it. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- arch/arm/mach-tegra/tegra.c | 38 + include/linux/platform_data/tegra_usb.h | 32

[PATCH 9/9] usb: phy: tegra: Use DT helpers for dr_mode

Use the new of_usb_get_dr_mode helper function for parsing dr_mode from the device tree. Also replace the usage of the custom tegra_usb_phy_mode enum with the standard enum. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 20

[PATCH 6/9] usb: host: tegra: Locate a PHY via standard API

Use devm_get_phy_by_phandle to get a PHY device instead of the custom Tegra functions. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb