Re: [PATCH v6 0/8] power: add power sequence library

2016-09-19 Thread Vaibhav Hiremath
On Monday 19 September 2016 01:16 PM, Peter Chen wrote: On Mon, Sep 19, 2016 at 01:09:10PM +0530, Vaibhav Hiremath wrote: On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote: [...] We had an agreement that keep mmc's pwrseq framework unchanging. Unless Ulf and rob both agree to change

Re: [PATCH v6 0/8] power: add power sequence library

2016-09-19 Thread Vaibhav Hiremath
On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote: [...] We had an agreement that keep mmc's pwrseq framework unchanging. Unless Ulf and rob both agree to change. Why 2 separate approach for same problem ? And I see this as possible duplication of code/functionality :) How the new

Re: [PATCH v6 0/8] power: add power sequence library

2016-09-06 Thread Vaibhav Hiremath
a On Friday 02 September 2016 06:40 AM, Peter Chen wrote: On Wed, Aug 31, 2016 at 10:28:20PM +0530, Vaibhav Hiremath wrote: On Wednesday 31 August 2016 03:22 PM, Peter Chen wrote: On Wed, Aug 31, 2016 at 01:46:30PM +0530, Vaibhav Hiremath wrote: On Monday 29 August 2016 04:40 PM, Peter Chen

Re: [PATCH v6 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-09-06 Thread Vaibhav Hiremath
On Friday 02 September 2016 06:30 AM, Peter Chen wrote: On Thu, Sep 01, 2016 at 01:33:22PM +0530, Vaibhav Hiremath wrote: On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Add binding doc for generic power sequence library. Signed-off-by: Peter Chen <peter.c...@nxp.com>

Re: [PATCH 2/2] USB: hub: change the locking in hub_activate

2016-09-01 Thread Vaibhav Hiremath
a child of the hub device). Another possibility is that the mutex _was_ initialized but got corrupted somehow. Of course, that kind of thing is very hard to track down. On Thu, 1 Sep 2016, Vaibhav Hiremath wrote: I have some more update on this, It seems the culprit was my laptop USB port (I ha

Re: [PATCH 2/2] USB: hub: change the locking in hub_activate

2016-09-01 Thread Vaibhav Hiremath
On Thursday 01 September 2016 10:32 AM, Viresh Kumar wrote: On 31-08-16, 12:46, Alan Stern wrote: On Wed, 31 Aug 2016, Viresh Kumar wrote: On 05-08-16, 11:51, Alan Stern wrote: +++ usb-4.x/drivers/usb/core/hub.c @@ -1052,7 +1052,7 @@ static void hub_activate(struct usb_hub /*

Re: [PATCH v6 4/8] usb: core: add power sequence handling for USB devices

2016-09-01 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Some hard-wired USB devices need to do power sequence to let the device work normally, the typical power sequence like: enable USB PHY clock, toggle reset pin, etc. But current Linux USB driver lacks of such code to do it, it may cause some

Re: [PATCH v6 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-09-01 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel Acked-by: Rob Herring --- .../bindings/power/pwrseq/pwrseq-generic.txt

Re: [PATCH v6 2/8] power: add power sequence library

2016-09-01 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: We have an well-known problem that the device needs to do some power sequence before it can be recognized by related host, the typical example like hard-wired mmc devices and usb devices. This power sequence is hard to be described at

Re: [PATCH v6 0/8] power: add power sequence library

2016-08-31 Thread Vaibhav Hiremath
On Wednesday 31 August 2016 03:22 PM, Peter Chen wrote: On Wed, Aug 31, 2016 at 01:46:30PM +0530, Vaibhav Hiremath wrote: On Monday 29 August 2016 04:40 PM, Peter Chen wrote: On Wed, Aug 24, 2016 at 04:53:35PM +0800, Peter Chen wrote: On Tue, Aug 23, 2016 at 04:02:48PM +0530, Vaibhav

Re: [PATCH v6 0/8] power: add power sequence library

2016-08-31 Thread Vaibhav Hiremath
On Monday 29 August 2016 04:40 PM, Peter Chen wrote: On Wed, Aug 24, 2016 at 04:53:35PM +0800, Peter Chen wrote: On Tue, Aug 23, 2016 at 04:02:48PM +0530, Vaibhav Hiremath wrote: On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Hi all, This is a follow-up for my last power sequence

Re: [PATCH v2 0/6] power: add power sequence library

2016-08-23 Thread Vaibhav Hiremath
On Tuesday 23 August 2016 03:52 PM, Vaibhav Hiremath wrote: On Wednesday 13 July 2016 07:36 AM, Peter Chen wrote: Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2], I use a generic power sequence library

Re: [PATCH v6 0/8] power: add power sequence library

2016-08-23 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2], I use a generic power sequence library for parsing the power sequence elements on DT, and implement

Re: [PATCH v2 0/6] power: add power sequence library

2016-08-23 Thread Vaibhav Hiremath
On Wednesday 13 July 2016 07:36 AM, Peter Chen wrote: Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2], I use a generic power sequence library for parsing the power sequence elements on DT, and implement

Re: [PATCH] USB: core: of: Check device_node before parsing in usb_of_get_child_node()

2016-08-16 Thread Vaibhav Hiremath
On Monday 15 August 2016 06:33 PM, Peter Chen wrote: On Mon, Aug 15, 2016 at 11:31:10AM -0700, Vaibhav Hiremath wrote: In case of HUB devices connected to USB ports, we may not have DT node representing it inside USB, and when devices connected to hub gets enumerated, call

Re: [PATCH] USB: core: of: Check device_node before parsing in usb_of_get_child_node()

2016-08-15 Thread Vaibhav Hiremath
On Monday 15 August 2016 11:41 AM, Greg KH wrote: On Mon, Aug 15, 2016 at 11:31:10AM -0700, Vaibhav Hiremath wrote: In case of HUB devices connected to USB ports, we may not have DT node representing it inside USB, and when devices connected to hub gets enumerated, call

[PATCH] USB: core: of: Check device_node before parsing in usb_of_get_child_node()

2016-08-15 Thread Vaibhav Hiremath
-> Call to usb_of_get_child_node() leads to NULL pointer dereference as parent->dev.of_node = NULL, as USB HUB DTS node may be empty. Fix this NULL pointer dereference by adding check for pointer device_node inside usb_of_get_child_node() fn. Signed-off-by: Vaibhav Hiremath

Re: [PATCH v2 3/3] usb: musb: omap: Add device tree support for omap musb glue

2012-09-11 Thread Vaibhav Hiremath
On 9/11/2012 2:39 PM, Kishon Vijay Abraham I wrote: Added device tree support for omap musb driver and updated the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- Documentation/devicetree/bindings/usb/omap-usb.txt | 33

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Vaibhav Hiremath
On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: The mailbox register for usb otg in omap is present in control module. On detection of any events VBUS or ID, this register should be written to send the notification to musb core. Till we have a separate control module driver to write to