Re: [PATCH v2 05/11] usbip: tools for userspace URBs transmission

2015-04-21 Thread Valentina Manea
On Tue, Apr 14, 2015 at 10:00 AM, Nobuo Iwata nobuo.iw...@fujixerox.co.jp wrote: diff --git a/tools/usb/usbip/libsrc/usbip_ux.h b/tools/usb/usbip/libsrc/usbip_ux.h new file mode 100644 index 000..7506a1c --- /dev/null +++ b/tools/usb/usbip/libsrc/usbip_ux.h +#include

Re: [PATCH v2 00/11] usbip: features to USB over WebSocket

2015-04-21 Thread Valentina Manea
Hi, Managed to go through your series and looks like you've spent some time on this. Good job! However, given the density of the patches, I haven't really been able to go through every line of code. I did do some basic testing and made some comments where needed. Shuah, Greg, do you think more

Re: [PATCH v2 04/11] usbip: kernel module for userspace URBs transmission

2015-04-21 Thread Valentina Manea
Looks ok. Valentina -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 06/11] usbip: readme about user space URBs transmission

2015-04-21 Thread Valentina Manea
Looks good. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 01/11] usbip: exporting devices

2015-04-21 Thread Valentina Manea
Hi, I looked around your patch and tested it and looks good. However, I do have 2 nit-picks: * I noticed in some places you've used labels such as err0 and err1. Please replace them with something more relevant to their functionality, such as what you're cleaning up after. There are examples of

Re: [PATCH v2 02/11] usbip: readme and manuals about exporting devices

2015-04-21 Thread Valentina Manea
On Tue, Apr 14, 2015 at 10:00 AM, Nobuo Iwata nobuo.iw...@fujixerox.co.jp wrote: -server:# usbip bind --busid=1-2 +dev:# usbip bind --busid=1-2 - Bind usbip-host.ko to the device of busid 1-2. -- A usb device 1-2 is now exportable to other hosts! -- Use

Re: [PATCH v2 03/11] usbip: safe completion against usb_kill_urb()

2015-04-21 Thread Valentina Manea
On Tue, Apr 14, 2015 at 10:00 AM, Nobuo Iwata nobuo.iw...@fujixerox.co.jp wrote: stub_shutdown_connection() : drivers/usb/usbip/stub_dev.c stub_device_cleanup_urbs() : drivers/usb/usbip/stub_main.c requests to kill pending URBs and clears priv lists. stub_complete() :

Re: [PATCH 01/13] USB/IP: exporting devices

2015-04-19 Thread Valentina Manea
Hi, On Fri, Apr 3, 2015 at 3:33 AM, Nobuo Iwata nobuo.iw...@fujixerox.co.jp wrote: For this, export function, connection is established from device-side machine to application-side machine. Following use cases are supposed for the export function. 1) Server application or cloud service

Re:

2015-04-17 Thread Valentina Manea
Hi, Sorry for the lack of review on this series; will take care of this tomorrow. Valentina -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 21/22] usbip: vhci_hcd: use USB_DT_HUB

2015-03-31 Thread Valentina Manea
( HUB_CHAR_INDV_PORT_LPSM | HUB_CHAR_COMMON_OCPM); Acked-by: Valentina Manea valentina.mane...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 22/23] usbip: vhci_hcd: use HUB_CHAR_*

2015-01-23 Thread Valentina Manea
On Mon, Jan 19, 2015 at 1:00 AM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Fix using the bare number to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in linux/usb/ch11.h. Signed-off-by: Sergei Shtylyov

Re: [PATCH] usbip: fix error handling in stub_probe()

2014-12-01 Thread Valentina Manea
); + return rc; } static void shutdown_busid(struct bus_id_priv *busid_priv) -- 1.9.1 Nice catch. Acked-by: Valentina Manea valentina.mane...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 4/4] usbip: remove unneeded structure

2014-12-01 Thread Valentina Manea
, sizeof(req)); if (rc 0) { Acked-by: Valentina Manea valentina.mane...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] USB-IP: Deletion of unnecessary checks before the function call usb_put_dev

2014-11-21 Thread Valentina Manea
; vdev-devid = 0; - if (vdev-udev) - usb_put_dev(vdev-udev); + usb_put_dev(vdev-udev); vdev-udev = NULL; if (ud-tcp_socket) { -- 2.1.3 Acked-by: Valentina Manea valentina.mane...@gmail.com -- To unsubscribe from this list: send the line

Re: [PATCH] usb: usbip: fix usbip.h path in userspace tool

2014-09-04 Thread Valentina Manea
On Thu, Sep 4, 2014 at 2:41 AM, Greg KH gre...@linuxfoundation.org wrote: Shouldn't you be able to use the same path as ch9.h uses? It's a uapi .h file, no relative paths should be needed. For the userspace tool, the build system only looks for headers in the system default locations, such

Re: [PATCH] usb: usbip: fix usbip.h path in userspace tool

2014-09-04 Thread Valentina Manea
On Thu, Sep 4, 2014 at 5:14 AM, Greg KH gre...@linuxfoundation.org wrote: This patch is a pretty nasty hack to get it to compile within the kernel tree. I wonder whether we can make this self-contained by duplicating the header's content inside usbip_common.h. Ick, no, don't do that, use

Re: [PATCH v2] usb: usbip: fix usbip.h path in userspace tool

2014-09-04 Thread Valentina Manea
On Fri, Sep 5, 2014 at 1:58 AM, Piotr Król piotr.k...@3mdeb.com wrote: Fixes: 588b48caf65c (usbip: move usbip userspace code out of staging) which introduced build failure by not changing uapi/usbip.h include path according to new location. Signed-off-by: Piotr Król piotr.k...@3mdeb.com ---

Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Valentina Manea
On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter dan.carpen...@oracle.com wrote: This was promoted out of staging and there wasn't an email to the staging list. Normally I like to go through any remaining questions before the code is moved. The code looks pretty good, I just had one question.

Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Valentina Manea
On Tue, Aug 26, 2014 at 11:47 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Aug 26, 2014 at 09:06:17AM -0700, Valentina Manea wrote: On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter dan.carpen...@oracle.com wrote: 707 /* 708 * loop over all packets from

Re: [PATCH 1/4] usbip: move usbip userspace code out of staging

2014-08-24 Thread Valentina Manea
On Tue, Aug 19, 2014 at 9:30 PM, Valentina Manea valentina.mane...@gmail.com wrote: At this point, USB/IP userspace code is fully functional and can be moved out of staging. Signed-off-by: Valentina Manea valentina.mane...@gmail.com Bumping this in case Greg missed the patch series

Re: [PATCH 2/3] usbip: move usbip kernel code out of staging

2014-08-19 Thread Valentina Manea
On Tue, Aug 19, 2014 at 11:38 AM, Greg KH gre...@linuxfoundation.org wrote: This patch moves the code, but now it's gone from the build system as it is not hooked up and can not be built at all. So while I really wanted to apply this series right now, I can't, as this is a regression

[PATCH 3/4] usbip: remove struct usb_device_id table

2014-08-19 Thread Valentina Manea
This was used back when usbip-host was an interface device driver; after the conversion to device driver, the table remained unused. Remove it in order to stop receiving a warning about it. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/usb/usbip/stub_dev.c | 27

[PATCH 0/4] *** SUBJECT HERE ***

2014-08-19 Thread Valentina Manea
A warning generated in the kernel code is also solved and an entry in MAINTAINERS file is created for this driver. Valentina Manea (4): usbip: move usbip userspace code out of staging usbip: move usbip kernel code out of staging usbip: remove struct usb_device_id table MAINTAINERS: Add

[PATCH 1/4] usbip: move usbip userspace code out of staging

2014-08-19 Thread Valentina Manea
At this point, USB/IP userspace code is fully functional and can be moved out of staging. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- {drivers/staging/usbip/userspace = tools/usb/usbip}/.gitignore | 0 {drivers/staging/usbip/userspace = tools/usb/usbip}/AUTHORS

Re: [PATCH 0/3] usbip: move usbip out of staging

2014-08-08 Thread Valentina Manea
On Thu, Aug 7, 2014 at 1:16 PM, Greg KH gre...@linuxfoundation.org wrote: The top of the MAINTAINERS should have this information, look in the S: Status section about what type of category you are in. Basically I'd like you to be the one to handle patches that are sent in for the code, just

Re: [PATCH 0/3] usbip: move usbip out of staging

2014-08-07 Thread Valentina Manea
On Wed, Aug 6, 2014 at 10:33 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Aug 07, 2014 at 08:10:25AM +0300, Valentina Manea wrote: This is a resend of the patch series from March. After migrating userspace code to libudev, converting usbip-host to a device driver and various bug

[PATCH 3/3] usbip: remove struct usb_device_id table

2014-08-06 Thread Valentina Manea
This was used back when usbip-host was an interface device driver; after the conversion to device driver, the table remained unused. Remove it in order to stop receiving a warning about it. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/usb/usbip/stub_dev.c | 27

[PATCH 1/3] usbip: move usbip userspace code out of staging

2014-08-06 Thread Valentina Manea
At this point, USB/IP userspace code is fully functional and can be moved out of staging. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- {drivers/staging/usbip/userspace = tools/usb/usbip}/.gitignore | 0 {drivers/staging/usbip/userspace = tools/usb/usbip}/AUTHORS

[PATCH 0/3] usbip: move usbip out of staging

2014-08-06 Thread Valentina Manea
Besides this, a warning generated in the kernel code is solved. Valentina Manea (3): usbip: move usbip userspace code out of staging usbip: move usbip kernel code out of staging usbip: remove struct usb_device_id table drivers/staging/Kconfig| 2 -- drivers

[PATCH 2/3] usbip: move usbip kernel code out of staging

2014-08-06 Thread Valentina Manea
At this point, USB/IP kernel code is fully functional and can be moved out of staging. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/Kconfig| 2 -- drivers/staging/Makefile | 1 - drivers

[PATCH 0/3] usbip: move usbip out of staging

2014-08-06 Thread Valentina Manea
to tools/usb/usbip * kernel code to drivers/usb/usbip Besides this, a warning generated in the kernel code is solved. Valentina Manea (3): usbip: move usbip userspace code out of staging usbip: move usbip kernel code out of staging usbip: remove struct usb_device_id table drivers/staging

[PATCH 0/3] usbip: move usbip out of staging

2014-03-18 Thread Valentina Manea
Besides this, a warning generated in the kernel code is solved. Valentina Manea (3): usbip: move usbip userspace code out of staging usbip: move usbip kernel code out of staging usbip: remove struct usb_device_id table drivers/staging/Kconfig|2 - drivers

[PATCH 3/3] usbip: remove struct usb_device_id table

2014-03-18 Thread Valentina Manea
This was used back when usbip-host was an interface device driver; after the conversion to device driver, the table remained unused. Remove it in order to stop receiving a warning about it. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/usb/usbip/stub_dev.c | 27

[PATCH 0/2] Rename struct dev_state to struct usb_dev_state

2014-03-10 Thread Valentina Manea
Since it is needed outside usbcore and exposed in include/linux/usb.h, it conflicts with enum dev_state in rt2x00 wireless driver and breaks the build. Mark it as usb specific to avoid conflicts in the future and update USB/IP to use the new name. Valentina Manea (2): usbcore: rename struct

[PATCH 1/2] usbcore: rename struct dev_state to struct usb_dev_state

2014-03-10 Thread Valentina Manea
Since it is needed outside usbcore and exposed in include/linux/usb.h, it conflicts with enum dev_state in rt2x00 wireless driver. Mark it as usb specific to avoid conflicts in the future. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/usb/core/devio.c | 112

[PATCH 2/2] staging: usbip: rename struct dev_state to usb_dev_state

2014-03-10 Thread Valentina Manea
struct dev_state definition in usbcore conflicted with enum dev_state definition in rt2x00 driver so it was renamed to usb_dev_state. Update usbip for this change. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/stub_dev.c | 4 ++-- 1 file changed, 2

Re: [PATCH 00/18] Resend of usbip-utils migration patches and various other fixes

2014-03-09 Thread Valentina Manea
I was notified that one of the patches in the series (staging: usbip: claim ports used by shared devices) breaks the build. I take full responsability for this as I haven't compiled the kernel with allyesconfig and I am sorry. This can be fixed by moving struct dev_state, usb_hub_claim_port() and

[PATCH 13/18] staging: usbip: userspace: increase version to 2.0

2014-03-08 Thread Valentina Manea
Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/configure.ac b/drivers/staging/usbip/userspace/configure.ac index 25bf160..607d05c

[PATCH 18/18] staging: usbip: userspace: add hwdata as optional dependency in README

2014-03-08 Thread Valentina Manea
This is an optional dependency since USB/IP can fully work without it. However, it is needed to display device information such as vendor. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/README | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 15/18] staging: usbip: trigger driver probing after unbinding from usbip-host

2014-03-08 Thread Valentina Manea
A sysfs attribute is used to announce kernel space that a new driver probing session should be triggered for the just unbinded device. In order to have the address of struct device associated to this USB device, a new member has been added to struct bus_id_priv. Signed-off-by: Valentina Manea

[PATCH 17/18] staging: usbip: userspace: don't throw error when trying to read configuration specific attributes

2014-03-08 Thread Valentina Manea
When a device has just been bound to usbip-host but the client hasn't set a configuration on it, certain attributes will not exist. Don't treat this as an error. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/usbip_common.c | 17

[PATCH 16/18] staging: usbip: claim ports used by shared devices

2014-03-08 Thread Valentina Manea
A device should not be able to be used concurrently both by the server and the client. Claiming the port used by the shared device ensures no interface drivers bind to it and that it is not usable from the server. Signed-off-by: Valentina Manea valentina.mane...@gmail.com Acked-by: Alan Stern st

[PATCH 14/18] staging: usbip: let client choose device configuration

2014-03-08 Thread Valentina Manea
Since usbip-host is now a device driver and the client has full access to the shared device, it makes sense to let the client choose device configuration. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/stub_dev.c | 10 +- drivers/staging/usbip

[PATCH 12/18] staging: usbip: userspace: update dependencies in README

2014-03-08 Thread Valentina Manea
Add libudev as dependency and remove libsysfs. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/userspace/README b/drivers/staging/usbip/userspace

[PATCH 11/18] staging: usbip: userspace: remove libsysfs flag and autoconf check

2014-03-08 Thread Valentina Manea
libsysfs is now completely removed from USB/IP. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/usbip/userspace/configure.ac b/drivers/staging/usbip/userspace

[PATCH 07/18] staging: usbip: userspace: move sysfs_utils to libsrc

2014-03-08 Thread Valentina Manea
Since it offers a API to both usbip tools and libusbip, it is more appropriate to be place in the library. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 ++- .../staging/usbip/userspace/libsrc/sysfs_utils.c | 31

[PATCH 05/18] staging: usbip: userspace: re-add interface information listing

2014-03-08 Thread Valentina Manea
This was deleted in the driver conversion patch. It didn't need to be deleted; showing more information is ok. Signed-off-by: Valentina Manea valentina.mane...@gmail.com Reviewed-by: Shuah Khan shuah...@samsung.com --- drivers/staging/usbip/userspace/src/usbip_list.c | 20

[PATCH 08/18] staging: usbip: userspace: migrate usbip_host_driver to libudev

2014-03-08 Thread Valentina Manea
This patch modifies usbip_host_driver to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com Reviewed-by: Shuah Khan shuah...@samsung.com --- .../staging/usbip/userspace/libsrc/usbip_common.c | 76 ++ .../staging/usbip/userspace/libsrc/usbip_common.h | 5

[PATCH 10/18] staging: usbip: userspace: migrate vhci_driver to libudev

2014-03-08 Thread Valentina Manea
This patch migrates vhci_driver to libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com Reviewed-by: Shuah Khan shuah...@samsung.com --- .../staging/usbip/userspace/libsrc/usbip_common.h | 1 - .../staging/usbip/userspace/libsrc/vhci_driver.c | 154

[PATCH 03/18] staging: usbip: userspace: migrate usbip_unbind to libudev

2014-03-08 Thread Valentina Manea
This patch modifies usbip_unbind to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com Reviewed-by: Shuah Khan shuah...@samsung.com --- drivers/staging/usbip/userspace/src/usbip_unbind.c | 93 +++--- 1 file changed, 29 insertions(+), 64 deletions(-) diff

[PATCH 09/18] staging: usbip: userspace: remove class device infrastructure in vhci_driver

2014-03-08 Thread Valentina Manea
The class device lists were used only when being initialized, being populated and being destroyed. They had no real meaning and thus the code was useless. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- .../staging/usbip/userspace/libsrc/vhci_driver.c | 178

[PATCH 06/18] staging: usbip: userspace: add new list API

2014-03-08 Thread Valentina Manea
Take the linked list implementation from the Linux Kernel and strip it down to what it is needed. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/list.h | 136 ++ 1 file changed, 136 insertions(+) create mode 100644

[PATCH 04/18] staging: usbip: userspace: migrate usbip_list to libudev

2014-03-08 Thread Valentina Manea
This patch modifies usbip_list to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_list.c | 133 +-- 1 file changed, 50 insertions(+), 83 deletions(-) diff --git a/drivers/staging/usbip/userspace/src

[PATCH 01/18] staging: usbip: userspace: migrate usbip_bind to libudev

2014-03-08 Thread Valentina Manea
This patch adds autoconf check for libudev and migrates usbip_bind to the new library. libsysfs will still be used until all userspace is modified. Signed-off-by: Valentina Manea valentina.mane...@gmail.com Reviewed-by: Shuah Khan shuah...@samsung.com --- drivers/staging/usbip/userspace

[PATCH 02/18] staging: usbip: userspace: remove useless libsysfs includes

2014-03-08 Thread Valentina Manea
This patch removes useless libsysfs.h includes in various userspace files. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_attach.c | 1 - drivers/staging/usbip/userspace/src/usbip_detach.c | 2 -- drivers/staging/usbip/userspace/src

[PATCH 00/18] Resend of usbip-utils migration patches and various other fixes

2014-03-08 Thread Valentina Manea
This is a resend of the patches sent a few days ago, including the migration of USB/IP userspace side to use libudev instead of libsysfs and various other fixes, all ordered in a big patch series. The patches have been modified according to received feedback. Valentina Manea (18): staging

[PATCH v2] staging: usbip: claim ports used by shared devices

2014-03-05 Thread Valentina Manea
A device should not be able to be used concurrently both by the server and the client. Claiming the port used by the shared device ensures no interface drivers bind to it and that it is not usable from the server. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- Changes since v1

Re: [PATCH 01/12] staging: usbip: userspace: migrate usbip_bind to libudev

2014-03-05 Thread Valentina Manea
On Wed, Mar 5, 2014 at 12:15 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Wed, Mar 05, 2014 at 12:42:59PM +0300, Dan Carpenter wrote: On Tue, Mar 04, 2014 at 09:10:41PM +0200, Valentina Manea wrote: diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.h b/drivers/staging

Re: [PATCH] staging: usbip: userspace: increase version to 2.0

2014-03-05 Thread Valentina Manea
On Tue, Mar 4, 2014 at 9:20 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote: Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 12/12] staging: usbip: userspace: update dependencies in README

2014-03-04 Thread Valentina Manea
Add libudev as dependency and remove libsysfs. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/userspace/README b/drivers/staging/usbip/userspace

[PATCH 06/12] staging: usbip: userspace: add new list API

2014-03-04 Thread Valentina Manea
Add a new list API from CCAN. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 +- .../staging/usbip/userspace/libsrc/build_assert.h | 40 ++ .../staging/usbip/userspace/libsrc/check_type.h| 64 +++ .../staging/usbip

[PATCH 09/12] staging: usbip: userspace: remove class device infrastructure in vhci_driver

2014-03-04 Thread Valentina Manea
The class device lists were used only when being initialized, being populated and being destroyed. They had no real meaning and thus the code was useless. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- .../staging/usbip/userspace/libsrc/vhci_driver.c | 178

[PATCH 08/12] staging: usbip: userspace: migrate usbip_host_driver to libudev

2014-03-04 Thread Valentina Manea
This patch modifies usbip_host_driver to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- .../staging/usbip/userspace/libsrc/usbip_common.c | 74 ++ .../staging/usbip/userspace/libsrc/usbip_common.h | 5 +- .../usbip/userspace/libsrc/usbip_host_driver.c

[PATCH 10/12] staging: usbip: userspace: migrate vhci_driver to libudev

2014-03-04 Thread Valentina Manea
This patch migrates vhci_driver to libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- .../staging/usbip/userspace/libsrc/usbip_common.h | 1 - .../staging/usbip/userspace/libsrc/vhci_driver.c | 154 ++--- .../staging/usbip/userspace/libsrc/vhci_driver.h

[PATCH 07/12] staging: usbip: userspace: move sysfs_utils to libsrc

2014-03-04 Thread Valentina Manea
Since it offers a API to both usbip tools and libusbip, it is more appropriate to be place in the library. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 +- .../staging/usbip/userspace/libsrc/sysfs_utils.c | 36

[PATCH 03/12] staging: usbip: userspace: migrate usbip_unbind to libudev

2014-03-04 Thread Valentina Manea
This patch modifies usbip_unbind to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_unbind.c | 92 +++--- 1 file changed, 29 insertions(+), 63 deletions(-) diff --git a/drivers/staging/usbip/userspace/src

[PATCH 02/12] staging: usbip: userspace: remove useless libsysfs includes

2014-03-04 Thread Valentina Manea
This patch removes useless libsysfs.h includes in various userspace files. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_attach.c | 1 - drivers/staging/usbip/userspace/src/usbip_detach.c | 2 -- drivers/staging/usbip/userspace/src

[PATCH 05/12] staging: usbip: userspace: re-add interface information listing

2014-03-04 Thread Valentina Manea
This was deleted in the driver conversion patch. It didn't need to be deleted; showing more information is ok. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_list.c | 20 +++- drivers/staging/usbip/userspace/src/usbipd.c

[PATCH 01/12] staging: usbip: userspace: migrate usbip_bind to libudev

2014-03-04 Thread Valentina Manea
This patch adds autoconf check for libudev and migrates usbip_bind to the new library. libsysfs will still be used until all userspace is modified. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 6 + .../staging/usbip

[PATCH 04/12] staging: usbip: userspace: migrate usbip_list to libudev

2014-03-04 Thread Valentina Manea
This patch modifies usbip_list to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_list.c | 137 +-- 1 file changed, 51 insertions(+), 86 deletions(-) diff --git a/drivers/staging/usbip/userspace/src

[PATCH] staging: usbip: userspace: increase version to 2.0

2014-03-04 Thread Valentina Manea
Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/configure.ac b/drivers/staging/usbip/userspace/configure.ac index 25bf160..607d05c

[PATCH] staging: usbip: let client choose device configuration

2014-03-04 Thread Valentina Manea
Since usbip-host is now a device driver and the client has full access to the shared device, it makes sense to let the client choose device configuration. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/stub_dev.c | 10 +- drivers/staging/usbip

[PATCH] staging: usbip: trigger driver probing after unbinding from usbip-host

2014-03-04 Thread Valentina Manea
A sysfs attribute is used to announce kernel space that a new driver probing session should be triggered for the just unbinded device. In order to have the address of struct device associated to this USB device, a new member has been added to struct bus_id_priv. Signed-off-by: Valentina Manea

[PATCH] staging: usbip: claim ports used by shared devices

2014-03-04 Thread Valentina Manea
Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/stub_dev.c | 22 ++ drivers/usb/core/devio.c | 17 - drivers/usb/core/hub.c | 2 ++ drivers/usb/core/usb.h | 6 +- include/linux/usb.h

[PATCH] staging: usbip: userspace: don't throw error when trying to read configuration specific attributes

2014-03-04 Thread Valentina Manea
When a device has just been bound to usbip-host but the client hasn't set a configuration on it, certain attributes will not exist. Don't treat this as an error. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/usbip_common.c | 17

[PATCH] staging: usbip: userspace: add hwdata as optional dependency in README

2014-03-04 Thread Valentina Manea
This is an optional dependency since USB/IP can fully work without it. However, it is needed to display device information such as vendor. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/README | 4 1 file changed, 4 insertions(+) diff --git

Re: [OPW] USB subsystem questions

2014-02-18 Thread Valentina Manea
Hi, On Sun, Feb 16, 2014 at 12:42 AM, Alan Stern st...@rowland.harvard.edu wrote: That's true when it is invoked from userspace. It can also be invoked directly by a kernel driver; in that case no file is needed. I managed to get it working but I think what I did is rather flawed. The

Re: /dev entry of USB device not disappearing after detach

2014-02-15 Thread Valentina Manea
On Fri, Feb 14, 2014 at 8:21 PM, Greg KH gre...@linuxfoundation.org wrote: Also, the kernel is the one now responsible for managing the /dev node creation/removal, through devtmpfs, there shouldn't be any hotplug scripts involved in this process, so I doubt it's a userspace issue. you do

Re: [OPW] USB subsystem questions

2014-02-15 Thread Valentina Manea
On Sat, Feb 1, 2014 at 12:00 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 31 Jan 2014, Sarah Sharp wrote: Why exactly do you want the device to not show up in /dev? I would think what you really want is for the device drivers on the server side to not bind to the device, since the

[PATCH] staging: usbip: convert usbip-host driver to usb_device_driver

2014-01-23 Thread Valentina Manea
-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/stub.h | 2 +- drivers/staging/usbip/stub_dev.c | 150 - drivers/staging/usbip/stub_main.c | 6 +- drivers/staging/usbip/stub_rx.c| 2

Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device_driver

2014-01-23 Thread Valentina Manea
On Thu, Jan 23, 2014 at 9:09 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jan 23, 2014 at 08:36:46PM +0200, Valentina Manea wrote: This driver was previously an interface driver. Since USB/IP exports a whole device, not just an interface, it would make sense to be a device driver

[PATCH v2] staging: usbip: convert usbip-host driver to usb_device_driver

2014-01-23 Thread Valentina Manea
, there is no need to bind/unbind each interface, just the device as a whole. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- Changes since v1: * add extra information to the commit message * remove a comment that was no longer available * export USB functions

Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device_driver

2014-01-23 Thread Valentina Manea
If you don't bind the interfaces, they will naturally bind to their normal drivers on the host. You probably don't want that to happen. (Although, at the moment, I don't see how you can prevent it.) That's true but, the way I see USB/IP general use case, the drivers from the host the device

[PATCH v3] staging: usbip: convert usbip-host driver to usb_device_driver

2014-01-23 Thread Valentina Manea
, there is no need to bind/unbind each interface, just the device as a whole. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- Changes since v2: * re-add check for empty device list drivers/staging/usbip/stub.h | 2 +- drivers/staging/usbip/stub_dev.c

[PATCH] staging: usbip: userspace: add support for viewing imported devices

2014-01-07 Thread Valentina Manea
(1687:6211) 2-1 - usbip://192.168.122.152:3240/1-1 - remote bus/dev 001/002 Signed-off-by: Valentina Manea valentina.mane...@gmail.com Reviewed-by: Ilija Hadzic ihad...@research.bell-labs.com --- Resubmitting this patch as I still didn't get any reply from Greg after 2 weeks

[PATCH v3] staging: usbip: userspace: add support for viewing imported devices

2013-12-24 Thread Valentina Manea
(1687:6211) 2-1 - usbip://192.168.122.152:3240/1-1 - remote bus/dev 001/002 Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- Changes since v2: * fix trailing whitespace error * change commit title to reflect that this is a userspace patch .../staging

[PATCH v2] staging: usbip: add support for viewing imported devices

2013-12-23 Thread Valentina Manea
(1687:6211) 2-1 - usbip://192.168.122.152:3240/1-1 - remote bus/dev 001/002 Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- Changes since v1: * remove devid from the printed info * arrange formatting a bit * don't bail out when port file