RE: [PATCH v2 1/1] usbip: auto retry for concurrent attach

2017-08-08 Thread fx IWATA NOBUO
Hello, > -Original Message- > From: Shuah Khan [mailto:sh...@kernel.org] > Sent: Thursday, August 03, 2017 2:27 AM > To: fx IWATA NOBUO <nobuo.iw...@fujixerox.co.jp>; > valentina.mane...@gmail.com; gre...@linuxfoundation.org; > linux-usb@vger.kernel.org

RE: usbip issue in stub_shutdown_connection while stub_complete triggers

2017-05-10 Thread fx IWATA NOBUO
: Wednesday, May 10, 2017 9:54 PM > To: fx IWATA NOBUO <nobuo.iw...@fujixerox.co.jp> > Cc: linux-usb@vger.kernel.org; ker...@pengutronix.de > Subject: usbip issue in stub_shutdown_connection while stub_complete > triggers > > > Hi Nuobo, > > I am curren

RE: [PATCH v14 00/10] usbip: exporting devices

2017-02-06 Thread fx IWATA NOBUO
Hello, > > Dear all, > > > > This series of patches adds exporting device operation to USB/IP. > > > > I run through most of your series and answered with couple of comments. > > I'm not checking all patches in detail because I see that there is a lot > of remarks from previous series which you

RE: [PATCH v8 0/2] usbip: vhci number of ports extension

2017-02-06 Thread fx IWATA NOBUO
Hello, > On 12/26/2016 08:18 AM, Nobuo Iwata wrote: > > This series of patches extends number of ports limitaion in application > > (vhci) side. > > > > (...) > > > 5. Dependencies > > > > This series depends on 'usbip: exporting devices' patch set because > > this includes changes to

RE: [PATCH v14 06/10] usbip: exporting devices: modifications to attach and detach

2017-02-06 Thread fx IWATA NOBUO
Hello, > > Refactoring to attach and detach operation to reuse common portion to > > application(vhci)-side daemon. > > > > The new application(vhci)-side daemon executes same procedures as > > attach and detach. Most of common code to access vhci has been > > implemented in VHCI userspace

RE: [PATCH v14 09/10] usbip: exporting devices: chage to documenattion

2017-02-06 Thread fx IWATA NOBUO
Hello, > > This patch adds function and usage of new connect operation, > disconnect > > operation and application(vhci)-side daemon to README and manuals. > > This should be the first patch for the series. That would have saved > me lot of time. Please move this patch up. OK. I will move the

RE: [PATCH v14 04/10] usbip: exporting devices: new disconnect operation

2017-02-06 Thread fx IWATA NOBUO
Hello, > > Implementation of new disconnect operation. This is linked as a part of > > usbip command. With this patch, usbip command has following > operations. > > > > bind > > unbind > > list (local/remote) > > attach > > detach > > port > > connect ... previous patch > > disconnect ...

RE: [PATCH v14 03/10] usbip: exporting devices: new connect operation

2017-02-06 Thread fx IWATA NOBUO
Hello, > > Implementation of new connect operation. This is linked as a part of > > usbip command. With this patch, usbip command has following > operations. > > > > bind > > unbind > > list (local/remote) > > attach > > detach > > port > > connect ... this patch > > Don't include

RE: [PATCH v14 03/10] usbip: exporting devices: new connect operation

2017-01-19 Thread fx IWATA NOBUO
users. To do so, there's no need to export bind/unbind in previous patch. Thank you for your advice, Nobuo Iwata // > -Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Thursday, January 12, 2017 9:44 PM > To: fx IWATA NOBUO <nobuo.iw...@fuj

RE: [PATCH v14 02/10] usbip: exporting devices: modifications to host side libraries

2017-01-16 Thread fx IWATA NOBUO
se strcmp() because busid in refreshed edev list must be valid. > The following isn't part of this patch, hence shouldn't be included in > the change log. I will remove. Best Regards, Nobuo Iwata // > -Original Message- > From: Shuah Khan [mailto:shua...@osg.samsung.com] &

RE: [PATCH v14 02/10] usbip: exporting devices: modifications to host side libraries

2017-01-16 Thread fx IWATA NOBUO
strncmp() instead of strcmp() here? No. Both busid and edev->udev.busid must be valid string here. > s/respactively/respectively Yes. Thanks. Best Regards, Nobuo Iwata // > -Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Thursday, Jan

RE: [PATCH v14 01/10] usbip: exporting devices: modifications to network header

2017-01-16 Thread fx IWATA NOBUO
ebug message is changed to use the new status strings. The 'returncode' of export and un-export reply are removed. --- Best Regards, Nobuo Iwata // > -Original Message- > From: Shuah Khan [mailto:shua...@osg.samsung.com] > Sent: Friday, January 13, 2017 2:44 AM > To: fx IWATA

RE: [PATCH v1 1/1] usbip: auto retry for concurrent attach

2017-01-15 Thread fx IWATA NOBUO
- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Thursday, January 12, 2017 8:02 PM > To: fx IWATA NOBUO <nobuo.iw...@fujixerox.co.jp>; > valentina.mane...@gmail.com; sh...@kernel.org; > gre...@linuxfoundation.org; linux-usb@vger.kernel.org >

RE: [PATCH v8 2/2] usbip: vhci extension: dynamic extension

2017-01-10 Thread fx IWATA NOBUO
Shuah Khan [mailto:shua...@osg.samsung.com] > Sent: Tuesday, January 10, 2017 9:42 AM > To: fx IWATA NOBUO <nobuo.iw...@fujixerox.co.jp>; > valentina.mane...@gmail.com; sh...@kernel.org; > gre...@linuxfoundation.org; linux-usb@vger.kernel.org > Cc: fx MICHIMURA TADAO <m

RE: [PATCH v8 1/2] usbip: vhci extension: modifications to userspace

2017-01-10 Thread fx IWATA NOBUO
across the controllers. --- Best Regards, Nobuo Iwata // > -Original Message- > From: Shuah Khan [mailto:shua...@osg.samsung.com] > Sent: Tuesday, January 10, 2017 9:03 AM > To: fx IWATA NOBUO <nobuo.iw...@fujixerox.co.jp>; > valentina.mane...@gmail.com; sh

RE: [PATCH v13 05/10] usbip: exporting devices: modifications to daemon

2017-01-03 Thread fx IWATA NOBUO
.*() is fit to this case. Thank you for your help, nobuo iwata // > -Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Wednesday, December 07, 2016 5:57 PM > To: fx IWATA NOBUO <nobuo.iw...@fujixerox.co.jp>; > valentina.man

RE: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-08 Thread fx IWATA NOBUO
e to check 'exporting devices' e-mails so I was late to read this e-mail. Thank you for your help, nobuo.iwata // > -Original Message- > From: Shuah Khan [mailto:shua...@osg.samsung.com] > Sent: Thursday, December 08, 2016 11:32 PM > To: fx IWATA NOBUO; Andrey Konovalov > Cc: Greg

RE: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-07 Thread fx IWATA NOBUO
s idiomatic order. Best Regards, nobuo.iwata // > -Original Message- > From: Shuah Khan [mailto:shua...@osg.samsung.com] > Sent: Thursday, December 08, 2016 11:51 AM > To: fx IWATA NOBUO; Andrey Konovalov > Cc: Greg Kroah-Hartman; Valentina Manea; Shuah Khan; > linux-usb@vge

RE: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-07 Thread fx IWATA NOBUO
Dear Shuah, I'm afraid there's one thing I have concerned. I think it's better to move sysfs_attr_init() before status->attr.attr.name = status->name; Best Regards, nobuo.iwata // > -Original Message- > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On

RE: [PATCH v13 00/10] usbip: exporting devices

2016-12-07 Thread fx IWATA NOBUO
make new patches. > 4) In most patches there are some mistakes which should be fixed > before applying. I will create v14. Best Regards, n.iwata // > -Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Saturday, December 03, 2016 3:10 AM &

RE: [PATCH v13 08/10] usbip: exporting devices: change to usbip_list.c

2016-12-06 Thread fx IWATA NOBUO
this set is re-arranged. I will remind it. I may include this patch because (it can be said that) this caused by introducing export request. Thank you for your help, n.iwata // > -Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Saturday, December 03,

RE: [PATCH v13 00/10] usbip: exporting devices

2016-12-06 Thread fx IWATA NOBUO
essage- > From: Shuah Khan [mailto:shuah...@samsung.com] > Sent: Saturday, December 03, 2016 12:49 AM > To: fx IWATA NOBUO; valentina.mane...@gmail.com; > gre...@linuxfoundation.org; linux-usb@vger.kernel.org > Cc: fx MICHIMURA TADAO; Shuah Khan; Shuah Khan > Subject:

RE: [PATCH v13 05/10] usbip: exporting devices: modifications to daemon

2016-12-06 Thread fx IWATA NOBUO
you, n.iwata // > -Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Tuesday, December 06, 2016 6:51 PM > To: fx IWATA NOBUO; valentina.mane...@gmail.com; shuah...@samsung.com; > gre...@linuxfoundation.org; linux-usb@vger.kernel.org > Cc: fx MICH

RE: [PATCH v13 07/10] usbip: exporting devices: new application-side daemon

2016-12-06 Thread fx IWATA NOBUO
only values changed in switch. How about sharing this code and add > only callback which will be used based on received op_code? usbip_refresh_device_list(), usbip_vhci_refresh_device_list() must be wrapped as same as open, close. Is usbip_meta_refresh_device_list() acceptable? Thank you for rev

RE: [PATCH v13 05/10] usbip: exporting devices: modifications to daemon

2016-12-05 Thread fx IWATA NOBUO
// > -----Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Friday, December 02, 2016 11:20 PM > To: fx IWATA NOBUO; valentina.mane...@gmail.com; shuah...@samsung.com; > gre...@linuxfoundation.org; linux-usb@vger.kernel.org > Cc: fx MICHIMUR

RE: [PATCH v13 00/10] usbip: exporting devices

2016-12-02 Thread fx IWATA NOBUO
have server daemon. I'd like to confirm the definition to answer rest of questions. Best Regards, n.iwata // > -Original Message- > From: Shuah Khan [mailto:shuah...@samsung.com] > Sent: Friday, December 02, 2016 9:39 AM > To: fx IWATA NOBUO; valentina.mane...@gmail.co

RE: [PATCH v13 05/10] usbip: exporting devices: modifications to daemon

2016-12-02 Thread fx IWATA NOBUO
0 > are we waiting here for message of size 0 or I missed something? No. It's just moved from usbipd.c. I will remove it. Thank you, n.iwata // > -Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Friday, December 02, 2016 6:19 AM > To: fx IWAT

RE: [PATCH v13 04/10] usbip: exporting devices: new disconnect operation

2016-12-01 Thread fx IWATA NOBUO
t, busid, unbind); > > + goto out; > > This looks a little bit weird... why you use goto out instead of just return > ret? err_out has usbip_disconnect_usage(). Each usbip_.c has same pattern. Thank you, n.iwata // > -Original Message----- > From: Krzysztof Opasi

RE: [PATCH v13 03/10] usbip: exporting devices: new connect operation

2016-12-01 Thread fx IWATA NOBUO
will fix it. usbip_attach.c has same logic so I will add refactoring patch to usbip_attach.c. regarding memset() and multiple driver_close. Thank you for your help, n.iwata // > -Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Friday, December 02, 2016

RE: [PATCH v13 02/10] usbip: exporting devices: modifications to host side libraries

2016-12-01 Thread fx IWATA NOBUO
nerally not a good idea and so on. OK. I will improve the commit message. Thank you, n.iwata // > -Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Friday, December 02, 2016 4:57 AM > To: fx IWATA NOBUO; shuah...@samsung.com; vale

RE: [PATCH v13 01/10] usbip: exporting devices: modifications to network header

2016-12-01 Thread fx IWATA NOBUO
ld: op_devlist_request. Thank you for reviewing, n.iwata // > -Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Friday, December 02, 2016 4:11 AM > To: fx IWATA NOBUO; valentina.mane...@gmail.com; shuah...@samsung.com; > gre...@linuxfou

RE: [PATCH v13 03/10] usbip: exporting devices: new connect operation

2016-11-23 Thread fx IWATA NOBUO
s not good. I will move it below. Thank you, nobuo.iwata // > -Original Message- > From: Shuah Khan [mailto:shuah...@samsung.com] > Sent: Thursday, November 24, 2016 6:52 AM > To: fx IWATA NOBUO; valentina.mane...@gmail.com; > gre...@linuxfoundation.org; linux-usb@vger.kernel.org &g

RE: [PATCH v13 02/10] usbip: exporting devices: modifications to host side libraries

2016-11-23 Thread fx IWATA NOBUO
usbip_find_device() and leave the unused function once. Please, let me know how should I do. Best Regards, nobuo.iwata // > -Original Message- > From: Shuah Khan [mailto:shuah...@samsung.com] > Sent: Thursday, November 24, 2016 6:02 AM > To: fx IWATA NOBUO; valentina.mane.

RE: [PATCH v13 00/10] usbip: exporting devices

2016-11-23 Thread fx IWATA NOBUO
ions send submit and unlink, devices process them. Your comment is at goal #1. I'm also considering goal #2. Thanks for reviewing, nobuo.iwata // > -Original Message- > From: Shuah Khan [mailto:shuah...@samsung.com] > Sent: Thursday, November 24, 2016 1:43 AM > To: fx IWATA NOB

RE: [PATCH v12 8/9] usbip: exporting devices: change to usbip_list.c

2016-11-14 Thread fx IWATA NOBUO
:11 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > linux-usb@vger.kernel.org; fx MICHIMURA TADAO > Subject: Re: [PATCH v12 8/9] usbip: exporting devices: change to > usbip_list.c > > On Thu, Oct 13, 2016 at 12:52:12PM +0900, Nobuo Iw

RE: [PATCH v12 6/9] usbip: exporting devices: modifications to attach and detach

2016-11-13 Thread fx IWATA NOBUO
ach and application(vhci)-side daemon using a diagram. Thank you for your comment, nobuo.iwata // > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, November 10, 2016 9:11 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsun

RE: [PATCH v12 5/9] usbip: exporting devices: modifications to daemon

2016-11-13 Thread fx IWATA NOBUO
alf Of Greg KH > Sent: Thursday, November 10, 2016 9:11 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > linux-usb@vger.kernel.org; fx MICHIMURA TADAO > Subject: Re: [PATCH v12 5/9] usbip: exporting devices: modifications to > daemon > > On Thu,

RE: [PATCH v12 3/9] usbip: exporting devices: new connect operation

2016-11-13 Thread fx IWATA NOBUO
> Again, we need more text. I will add text in next version. Thank you, nobuo.iwata // > -Original Message- > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Greg KH > Sent: Thursday, November 10, 2016 9:12 PM > To: f

RE: [PATCH v12 4/9] usbip: exporting devices: new disconnect operation

2016-11-13 Thread fx IWATA NOBUO
0, 2016 9:10 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > linux-usb@vger.kernel.org; fx MICHIMURA TADAO > Subject: Re: [PATCH v12 4/9] usbip: exporting devices: new disconnect > operation > > On Thu, Oct 13, 2016 at 12:52:08PM +0900, Nobuo Iwata

RE: [PATCH v12 2/9] usbip: exporting devices: modifications to host side libraries

2016-11-13 Thread fx IWATA NOBUO
dation.org] > Sent: Thursday, November 10, 2016 9:09 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > linux-usb@vger.kernel.org; fx MICHIMURA TADAO > Subject: Re: [PATCH v12 2/9] usbip: exporting devices: modifications to > host side libraries >

RE: [PATCH v12 1/9] usbip: exporting devices: modifications to network header

2016-11-13 Thread fx IWATA NOBUO
:08 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > linux-usb@vger.kernel.org; fx MICHIMURA TADAO > Subject: Re: [PATCH v12 1/9] usbip: exporting devices: modifications to > network header > > On Thu, Oct 13, 2016 at 12:52:05PM +0900, Nobuo Iwa

RE: [PATCH v6 2/2] usbip: vhci extension: dynamic extension

2016-11-13 Thread fx IWATA NOBUO
Thank you, nobuo.iwata // > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, November 10, 2016 9:05 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > linux-usb@vger.kernel.org; fx MICHIMURA TADAO > Sub

RE: [PATCH v12 0/9] usbip: exporting devices

2016-11-13 Thread fx IWATA NOBUO
linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Greg KH > Sent: Thursday, November 10, 2016 9:06 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > linux-usb@vger.kernel.org; fx MICHIMURA TADAO > Subject: Re: [PATCH v12

RE: usbip device reset

2016-11-06 Thread fx IWATA NOBUO
Sorry. I missed the mail archive URL. Merged patch is : http://www.mail-archive.com/linux-usb@vger.kernel.org/msg73658.html nobuo.iwata // > -Original Message- > From: fx IWATA NOBUO > Sent: Monday, November 07, 2016 10:02 AM > To: 'lars.taeu...@web.de'; linux-usb@vge

RE: usbip device reset

2016-11-06 Thread fx IWATA NOBUO
Hello, I'm not clear but my patch is related to the server (stub) side situation. http://www.mail-archive.com/linux-usb@vger.kernel.org/msg58989.html It was merged at 4.7-rc1. nobuo.iwata // > -Original Message- > From: linux-usb-ow...@vger.kernel.org >

RE: usbip: vhci extension: modifications to vhci driver

2016-10-12 Thread fx IWATA NOBUO
com] > Sent: Wednesday, October 12, 2016 5:57 PM > To: fx IWATA NOBUO > Cc: linux-usb@vger.kernel.org > Subject: Re: usbip: vhci extension: modifications to vhci driver > > On Wed, Oct 12, 2016 at 05:24:31AM +, fx IWATA NOBUO wrote: > > Hello, > > > > I wi

RE: usbip: vhci extension: modifications to vhci driver

2016-10-11 Thread fx IWATA NOBUO
of source pointer of the container_of(). Thank you, n.iwata // > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Tuesday, October 11, 2016 4:03 PM > To: fx IWATA NOBUO > Cc: linux-usb@vger.kernel.org > Subject: re: usbip: vhci extens

RE: [PATCH v9 0/9] usbip: exporting devices

2016-10-05 Thread fx IWATA NOBUO
dnesday, August 10, 2016 2:28 AM > To: fx IWATA NOBUO; valentina.mane...@gmail.com; shuah...@samsung.com; > gre...@linuxfoundation.org; linux-usb@vger.kernel.org > Cc: fx MICHIMURA TADAO > Subject: Re: [PATCH v9 0/9] usbip: exporting devices > > > > On 07/11/2016 09

RE: [PATCH v1 1/1] usbip: deletion of incorrect socket descriptor checking

2016-10-02 Thread fx IWATA NOBUO
-Original Message- > From: David Laight [mailto:david.lai...@aculab.com] > Sent: Friday, September 30, 2016 8:08 PM > To: fx IWATA NOBUO; valentina.mane...@gmail.com; shuah...@samsung.com; > gre...@linuxfoundation.org; linux-usb@vger.kernel.org > Cc: fx MICHIMURA TADAO > Subject: RE

RE: [PATCH v4 2/3] usbip: vhci extension: modifications to userspace

2016-08-12 Thread fx IWATA NOBUO
-- > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Greg KH > Sent: Thursday, August 11, 2016 4:56 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > linux-usb@vger.kernel.org; fx MICHIMURA TADAO > Sub

RE: [PATCH v4 2/3] usbip: vhci extension: modifications to userspace

2016-08-10 Thread fx IWATA NOBUO
s patch does not apply to my tree, can you refresh the series and > > resend it please? > > Yes, I will send update. > > Thank you, > > n.iwata > // > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: T

RE: [PATCH v9 0/9] usbip: exporting devices

2016-08-09 Thread fx IWATA NOBUO
ast, we conveniently use the new operation including small peer-to-peer environments. I hope it will be of some help. Best Regards, n.iwata // > -Original Message- > From: Krzysztof Opasiak [mailto:k.opas...@samsung.com] > Sent: Wednesday, August 10, 2016 2:28 AM > To: fx IWAT

RE: [PATCH v9 0/9] usbip: exporting devices

2016-08-09 Thread fx IWATA NOBUO
August 10, 2016 3:30 AM > To: Krzysztof Opasiak > Cc: fx IWATA NOBUO; valentina.mane...@gmail.com; shuah...@samsung.com; > gre...@linuxfoundation.org; linux-usb@vger.kernel.org; fx MICHIMURA > TADAO > Subject: Re: [PATCH v9 0/9] usbip: exporting devices > > Krzysztof Opasiak

RE: [PATCH v4 2/3] usbip: vhci extension: modifications to userspace

2016-08-09 Thread fx IWATA NOBUO
> This patch does not apply to my tree, can you refresh the series and resend > it please? Yes, I will send update. Thank you, n.iwata // > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, August 09, 2016 11:21 PM > To: f

RE: [PATCH v1 1/1] usbip: adding names db to port operation

2016-05-01 Thread fx IWATA NOBUO
-- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday, April 29, 2016 4:55 AM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > linux-usb@vger.kernel.org; fx MICHIMURA TADAO > Subject: Re: [PATCH v1 1/1] usbip: adding names db to port op

RE: [PATCH v2 1/1] usbip: safe completion against unbind operation

2016-04-26 Thread fx IWATA NOBUO
Dear Greg, Very sorry. I made mistake. I will send update with changelog separator. Thank you, n.iwata // > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, April 27, 2016 12:41 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@g

RE: [PATCH v1 1/1] usbip: safe completion against unbind operation

2016-04-26 Thread fx IWATA NOBUO
rom: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, April 27, 2016 7:02 AM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > linux-usb@vger.kernel.org; fx MICHIMURA TADAO > Subject: Re: [PATCH v1 1/1] usbip: safe completion against unbind

RE: [PATCH v1 1/2] usbip: modifications to event handler

2016-03-22 Thread fx IWATA NOBUO
n.iwata // > -Original Message- > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of > gre...@linuxfoundation.org > Sent: Wednesday, March 23, 2016 11:15 AM > To: fx IWATA NOBUO > Cc: kbuild test robot; kbuild-...@01.org; valentina.

RE: [PATCH v1 1/2] usbip: modifications to event handler

2016-03-22 Thread fx IWATA NOBUO
Nobuo // > -Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, March 23, 2016 10:40 AM > To: fx IWATA NOBUO > Cc: kbuild test robot; kbuild-...@01.org; valentina.mane...@gmail.com; > shuah...@samsung.com; linux-usb@vger.kernel

RE: [PATCH v1 1/2] usbip: modifications to event handler

2016-03-22 Thread fx IWATA NOBUO
Hi, The errors are cleared by patch 2/2. Should I complete in patch 1/2? // > -Original Message- > From: kbuild test robot [mailto:l...@intel.com] > Sent: Tuesday, March 22, 2016 5:21 PM > To: fx IWATA NOBUO > Cc: kbuild-...@01.org; valentina.mane...@gmail.com; > shuah..

RE: [PATCH v3 0/2] usbip: vhci number of ports extension

2016-02-15 Thread fx IWATA NOBUO
> > > What limitation? Why change it? What's the problem here... > > > > In original code, number of devices to be able to attach is 8. > > It's came from VHCI_NPORTS, the default is 8. > > It can be changed with compile option -DVHCI_NPORTS The maximum number > > is limited to USB_MAXCHILDREN

RE: [PATCH v7 1/3] usbip: exporting devices

2016-02-15 Thread fx IWATA NOBUO
> Why isn't this in the changelog itself? But more importantly, I don't see > how this patch makes your "goal" implemented... Sorry. I think almost same thing is in cover letter but version info is getting long. Anyway I will improve the log. > Anyway, please break this all up into smaller,

RE: [PATCH v7 3/3] usbip: safe completion against usb_kill_urb()

2016-02-14 Thread fx IWATA NOBUO
> Why this one tiny bugfix at the end of this series? Is this something that > could be applied without the huge 1/3 patch here? If so, please send it > on its own. If not, then please fix it in the place where you made this > bug happen. OK. I will send it separately. I will send it as V1

RE: [PATCH v7 1/3] usbip: exporting devices

2016-02-14 Thread fx IWATA NOBUO
> I don't see any benifit here at all, please explain it better. > You are saying what your patch does, but not why we would want it. It may not be better than cover letter but I try. My use case is a) a service in internet with VHCI b) distributed small Linux nodes with STUB and IoT devices.

RE: [PATCH v7 2/3] usbip: readme and manuals about exporting devices

2016-02-14 Thread fx IWATA NOBUO
> > This patch adds function and usage of export to README and manuals. > > > > The wording, 'server' and 'client' are changed. > > That sounds like a mistake, why would you do that? You just reversed > everything? Why? I'd like to add reverse connection. Originally both IMPORT and EXPORT

RE: [PATCH v7 1/3] usbip: exporting devices

2016-02-14 Thread fx IWATA NOBUO
> That's too much code to review, especially for something that I have no > idea what it is, or why it is needed at all. > > Please be more descriptive here, and hopefully, break this patch down into > smaller steps. OK. I will divide. Best Regards, n.iwata // -- To unsubscribe from this list:

RE: [PATCH v3 1/2] usbip: vhci number of ports extension

2016-02-14 Thread fx IWATA NOBUO
> > ex) # insmod vhci_hcd.ko num_controllers=4 > > I hate module parameters, please don't do that, create these dynamically > as needed some other way. OK. > > Also, ports per controller is changed from 8 to USB_MAXCHILDREN (31). > > Why? All in one patch? Not good. I will remove the

RE: [PATCH v7 0/3] usbip: exporting devices

2016-02-14 Thread fx IWATA NOBUO
> I have no idea what you mean by "exporting devices" :( It's at line 86 of original tools/usb/usbip/src/usbip_network.h // -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

RE: [PATCH v6 04/11] usbip: kernel module for userspace URBs transmission

2016-01-06 Thread fx IWATA NOBUO
constants. I will fix. > Is this really compat-safe? I used these pointers for debug messages in userspace to identify connection instead of sockfd. I will change the interface. Thank you spending time, nobuo iwata // > -Original Message- > From: Bjørn Mork [mailto:bj...@mork.no]

RE: [PATCH v2 1/2] usbip: vhci number of ports extension

2016-01-06 Thread fx IWATA NOBUO
nk you for your help, nobuo.iwata // > -Original Message- > From: Bjørn Mork [mailto:bj...@mork.no] > Sent: Tuesday, January 05, 2016 9:05 PM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > gre...@linuxfoundation.org; linux-usb@vger.kernel.org; fx MICHIMU

RE: [PATCH v5 04/11] usbip: kernel module for userspace URBs transmission

2016-01-04 Thread fx IWATA NOBUO
iver Neukum > Sent: Sunday, January 03, 2016 2:07 AM > To: fx IWATA NOBUO > Cc: valentina.mane...@gmail.com; shuah...@samsung.com; > gre...@linuxfoundation.org; linux-usb@vger.kernel.org; fx MICHIMURA > TADAO; Alan Stern > Subject: Re: [PATCH v5 04/11] usbip: kernel module for users

RE: [PATCH v4 00/11] usbip: features to USB over WebSocket

2015-07-16 Thread fx IWATA NOBUO
To: fx IWATA NOBUO Cc: Shuah Khan; Greg KH; linux-usb@vger.kernel.org; fx MICHIMURA TADAO Subject: Re: [PATCH v4 00/11] usbip: features to USB over WebSocket --- snip --- Acked-by: Valentina Manea valentina.mane...@gmail.com mailto:valentina.mane...@gmail.com

RE: [PATCH v4 00/11] usbip: features to USB over WebSocket

2015-05-28 Thread fx IWATA NOBUO
Hi, how do you avoid deadlocking under memory pressure? It seems to me that under these semantics you can no longer guarantee GFP_NOIO if usb-storage or UAS are used, because you have no control over memory allocations user space makes. Sorry, I haven't cared the case. I found GFP_NOIO

RE: [PATCH v3 00/11] usbip: features to USB over WebSocket

2015-05-25 Thread fx IWATA NOBUO
Hi, Maybe with other daemon or if you write your own one you will get better performance. It is obvious that it will never be as fast as dedicated implementation but the difference may be small enough. Yes. If there's any other trick other than TCP/IP loopback, please, let me know. Thank

RE: [PATCH v3 00/11] usbip: features to USB over WebSocket

2015-05-24 Thread fx IWATA NOBUO
Hello, I see your point and what you have done in patches. I'm only showing you that you may achieve almost the same effect without any changes in kernel. I tested wstunnel. The performance comparison in my environment is as following. Round trip time of keyboard key down and up URBs at

RE: [PATCH v3 00/11] usbip: features to USB over WebSocket

2015-04-28 Thread fx IWATA NOBUO
Hello, As far as I understand your design you have kernel stub driver which is sending and receiving data via socket fd received from userspace. Now after this series you are exporting all messages to userspace where daemon is sending them using web sockets. Am I right? Yes. I don't see

RE: [PATCH v2 11/11] usbip: USB over WebSocket

2015-04-23 Thread fx IWATA NOBUO
Hi Steve, If you are looking for a good C websockets library, gpl etc try: https://libwebsockets.org/trac/libwebsockets I used it in a project and was very pleased with how it worked and the support where it is hosted. I checked libwebsockets ago but I misunderstood it doesn't support

RE: [PATCH v2 11/11] usbip: USB over WebSocket

2015-04-23 Thread fx IWATA NOBUO
Hi Bjørn This cannot possibly be necessary. Pointing to the toplevel COPYING file should be more than enough, if anything at all. And BTW, the same goes for the tools/usb/usbip/COPYING that seems to have snuck in somehow. I also wonder a bit about the AUTHORS file both places. We have

RE: [PATCH v2 05/11] usbip: tools for userspace URBs transmission

2015-04-23 Thread fx IWATA NOBUO
+#include ../../../../include/uapi/linux/usbip_ux.h So you can just refer this as linux/usbip_ux.h I will fix in v3. Thank you, n.iwata //

RE: [PATCH v2 01/11] usbip: exporting devices

2015-04-23 Thread fx IWATA NOBUO
Hi Valentina, * I noticed in some places you've used labels such as err0 and err1. Please replace them with something more relevant to their functionality, such as what you're cleaning up after. There are examples of this both in USB/IP code and throughout the kernel. I will fix all in

RE: [PATCH v2 02/11] usbip: readme and manuals about exporting devices

2015-04-23 Thread fx IWATA NOBUO
I see various parameters, such as --busid, followed by an = sign. This looks like a thing thoughout the manual. Although this syntax works as well, I think we should be consistent and not include =. I, personally, prefer having --busid busid instead of --busid=busid. I agree. I checked

RE: [PATCH 01/13] USB/IP: exporting devices

2015-04-19 Thread fx IWATA NOBUO
Dear Valentina, Thank you for reviewing. For this, export function, connection is established from device-side machine to application-side machine. Following use cases are supposed for the export function. 1) Server application or cloud service serves distributed ubiquitous devices.

RE: [PATCH 04/13] USB/IP: kernel module for userspace URBs transmission

2015-04-13 Thread fx IWATA NOBUO
: Greg KH [mailto:g...@kroah.com] Sent: Friday, April 10, 2015 9:00 PM To: fx IWATA NOBUO Cc: valentina.mane...@gmail.com; shuah...@samsung.com; linux-usb@vger.kernel.org; fx MICHIMURA TADAO Subject: Re: [PATCH 04/13] USB/IP: kernel module for userspace URBs transmission On Mon, Apr 06, 2015

RE: [PATCH 04/13] USB/IP: kernel module for userspace URBs transmission

2015-04-06 Thread fx IWATA NOBUO
patch because I couldn't search in the linux-usb mail archive. I will study it and send my SSL patch later if it has some other effect. Thanks, n.iwata // -Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Friday, April 03, 2015 5:07 PM To: fx IWATA NOBUO Cc