Re: [PATCH] USB: fix coding style issue

2017-08-30 Thread pierre kuo
hi Greg > Note, not all subsystems appreciate coding style cleanups, so be aware > of that if you do start to do this type of work outside of > drivers/staging/ Got it. thanks for your friendly reminder. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: [PATCH] USB: fix coding style issue

2017-08-30 Thread pierre kuo
hi Greg: 2017-08-16 23:46 GMT+08:00 Greg KH <gre...@linuxfoundation.org>: > On Wed, Aug 16, 2017 at 11:01:20AM +0800, pierre Kuo wrote: >> try to fix some codeing style issue, such as "space prohibited" and "not >> initialise statics". > > Onl

[PATCH] USB: fix coding style issue

2017-08-15 Thread pierre Kuo
try to fix some codeing style issue, such as "space prohibited" and "not initialise statics". Signed-off-by: pierre Kuo <vichy@gmail.com> --- drivers/usb/host/ehci-hcd.c | 6 ++--- drivers/usb/host/ehci-hub.c | 22 - drivers/

Re: [PATCH 1/1] usb: ehci: put wmb at the end sitd/itd_link memory access

2017-04-10 Thread pierre kuo
hi Alan >> > If you need to flush something, wmb() is the wrong primitive. >> > It merely ensures ordering. It is not guaranteed to flush writes >> Not guaranteed to flush writes?that makes me curious. >> As far as I know, wmb() make sure any write operation before the wmb() >> is completed and

Re: [PATCH 1/1] usb: ehci: put wmb at the end sitd/itd_link memory access

2017-03-25 Thread pierre kuo
hi Oliver: 2017-03-23 17:33 GMT+08:00 Oliver Neukum <oneu...@suse.com>: > Am Donnerstag, den 23.03.2017, 16:39 +0800 schrieb pierre Kuo: > > Hi, > >> for sitd_link and itd_link, put wmb after the last memory access to make >> sure ehci->period[frame] is

[PATCH 1/1] usb: ehci: put wmb at the end sitd/itd_link memory access

2017-03-23 Thread pierre Kuo
for sitd_link and itd_link, put wmb after the last memory access to make sure ehci->period[frame] is visible by host before scheduling the descriptors Signed-off-by: pierre Kuo <vichy@gmail.com> --- drivers/usb/host/ehci-sched.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [PATCH 1/1] usb: ehci: put wmb at the end sitd/itd_link memory access

2017-03-23 Thread pierre kuo
2017-03-23 15:55 GMT+08:00 Greg KH <gre...@linuxfoundation.org>: > On Thu, Mar 23, 2017 at 03:39:20PM +0800, pierre kuo wrote: >> hi Greg: >> >> 2017-03-23 15:15 GMT+08:00 Greg KH <gre...@linuxfoundation.org>: >> > On Thu, Mar 23, 2017 at 03:09:05PM +0

Re: [PATCH 1/1] usb: ehci: put wmb at the end sitd/itd_link memory access

2017-03-23 Thread pierre kuo
hi Greg: 2017-03-23 15:15 GMT+08:00 Greg KH <gre...@linuxfoundation.org>: > On Thu, Mar 23, 2017 at 03:09:05PM +0800, pierre Kuo wrote: >> for sitd_link and itd_link, put wmb after the last memory access to make >> sure ehci->period[frame] is visible before

[PATCH 1/1] usb: ehci: put wmb at the end sitd/itd_link memory access

2017-03-23 Thread pierre Kuo
for sitd_link and itd_link, put wmb after the last memory access to make sure ehci->period[frame] is visible before starting period schedule Signed-off-by: pierre Kuo <vichy@gmail.com> --- drivers/usb/host/ehci-sched.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) d