Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-03 Thread Felipe Balbi
Hi, On Fri, May 03, 2013 at 12:13:53AM +0100, Russell King - ARM Linux wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-03 Thread Felipe Balbi
Hi, On Fri, May 03, 2013 at 09:21:51AM +0300, Felipe Balbi wrote: This is exactly why we have platform_device_alloc(), platform_device_register_full() and friends - so that people don't have to fsck around with kzalloc themselves and get it wrong like the above does. Would you like me

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-03 Thread Felipe Balbi
On Fri, May 03, 2013 at 09:25:06AM +0300, Felipe Balbi wrote: This is exactly why we have platform_device_alloc(), platform_device_register_full() and friends - so that people don't have to fsck around with kzalloc themselves and get it wrong like the above does. Would you like me

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-03 Thread Russell King - ARM Linux
On Fri, May 03, 2013 at 09:21:51AM +0300, Felipe Balbi wrote: Hi, On Fri, May 03, 2013 at 12:13:53AM +0100, Russell King - ARM Linux wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21 + 1 file changed,

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-03 Thread Felipe Balbi
Hi, On Fri, May 03, 2013 at 09:15:10AM +0100, Russell King - ARM Linux wrote: This is exactly why we have platform_device_alloc(), platform_device_register_full() and friends - so that people don't have to fsck around with kzalloc themselves and get it wrong like the above does.

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-03 Thread Russell King - ARM Linux
On Fri, May 03, 2013 at 09:21:51AM +0300, Felipe Balbi wrote: How about we pass yours for not reading the patch before flaming ? And another thing. If you want to be flamed, continue with that tone. The problem here is that *you* have not been flamed in the previous message. The previous

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-03 Thread Russell King - ARM Linux
On Fri, May 03, 2013 at 11:30:09AM +0300, Felipe Balbi wrote: Hi, On Fri, May 03, 2013 at 09:15:10AM +0100, Russell King - ARM Linux wrote: This is exactly why we have platform_device_alloc(), platform_device_register_full() and friends - so that people don't have to fsck

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-03 Thread Felipe Balbi
Hi, On Fri, May 03, 2013 at 09:32:06AM +0100, Russell King - ARM Linux wrote: On Fri, May 03, 2013 at 09:21:51AM +0300, Felipe Balbi wrote: How about we pass yours for not reading the patch before flaming ? And another thing. If you want to be flamed, continue with that tone. The problem

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-03 Thread Russell King - ARM Linux
On Fri, May 03, 2013 at 11:39:00AM +0300, Felipe Balbi wrote: Hi, On Fri, May 03, 2013 at 09:32:06AM +0100, Russell King - ARM Linux wrote: On Fri, May 03, 2013 at 09:21:51AM +0300, Felipe Balbi wrote: How about we pass yours for not reading the patch before flaming ? And another

[PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-02 Thread Alexander Shiyan
Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c index aa27d7f..8d17a0d 100644 ---

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-02 Thread Nishanth Menon
On 20:03-20130502, Alexander Shiyan wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c index

Re[2]: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-02 Thread Alexander Shiyan
On 20:03-20130502, Alexander Shiyan wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-02 Thread Felipe Balbi
Hi, On Thu, May 02, 2013 at 08:28:44PM +0400, Alexander Shiyan wrote: On 20:03-20130502, Alexander Shiyan wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-)

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-02 Thread Russell King - ARM Linux
On Thu, May 02, 2013 at 07:40:58PM +0300, Felipe Balbi wrote: Hi, On Thu, May 02, 2013 at 08:28:44PM +0400, Alexander Shiyan wrote: On 20:03-20130502, Alexander Shiyan wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21