Re: [PATCH] Revert "usb: typec: fusb302: Fix debugfs issue"

2018-09-21 Thread Michael Gebhard
Also, sorry for the cc messup, I'll put my two previous mails here, just so they'll appear in the archives. As heikki just pointed out, there already is a fix for this problem. === I do have a couple of questions on how to best make sure is always NULL or pointing to a valid dentry. Other

Re: [PATCH] Revert "usb: typec: fusb302: Fix debugfs issue"

2018-09-21 Thread Michael Gebhard
> Try this patch: > https://patchwork.kernel.org/patch/10607509/ > > It should fix the broblem. Let us know if it works. It does fix the null pointers on boot. As far as i can tell, the rootdir pointer still becomes invalid after fusb302_remove(), and it should crash if fusb302_probe() is called

Re: [PATCH] Revert "usb: typec: fusb302: Fix debugfs issue"

2018-09-21 Thread Heikki Krogerus
Hi Michael, On Fri, Sep 21, 2018 at 11:49:23AM +0200, Michael Gebhard wrote: > This reverts commit c9359f416207 ("usb: typec: fusb302: Fix debugfs issue") > > Removing debugfs directory leaves pointing at > freed memory. The next subsequent call to fusb302_probe() causes a > NULL pointer derenf