Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-16 Thread Johan Hovold
On Tue, Nov 03, 2015 at 11:25:28AM +0100, Petr Štetiar wrote: > It seems like this device has same vendor and product IDs as G2K > devices, but it has different number of interfaces(4 vs 5) and also > different interface layout which makes it currently unusable: > > usbcore: registered new i

Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-04 Thread Dan Williams
On Wed, 2015-11-04 at 16:57 +0100, Bjørn Mork wrote: > Petr Štetiar writes: > > > Bjørn Mork [2015-11-04 13:15:10]: > > > >> Based on that, I wonder if it wouldn't be more appropriate to simply do > >> this as a device specific quirk in the qmi_wwan probe? > > > > So rather something like this?

Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-04 Thread Petr Štetiar
Bjørn Mork [2015-11-04 16:57:06]: > > +#define QUECTEL_EC20_VENDORID 0x05c6 > > +#define QUECTEL_EC20_PRODUCTID 0x9215 > > +#define QUECTEL_EC20_NINTERFACES 5 > > +#define QUECTEL_EC20_QMI_IFACE_FIX 4 > > Not directly related to the issue at hand, but I sort of hate macros > like

Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-04 Thread Bjørn Mork
Petr Štetiar writes: > Bjørn Mork [2015-11-04 13:15:10]: > >> Based on that, I wonder if it wouldn't be more appropriate to simply do >> this as a device specific quirk in the qmi_wwan probe? > > So rather something like this? > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/q

Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-04 Thread Petr Štetiar
Bjørn Mork [2015-11-04 13:15:10]: > Based on that, I wonder if it wouldn't be more appropriate to simply do > this as a device specific quirk in the qmi_wwan probe? So rather something like this? diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 2a7c1be.

Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-04 Thread Bjørn Mork
Petr Štetiar writes: > Bjørn Mork [2015-11-03 13:37:56]: > >> I guess this means that we need to add an interface count quirk to the >> qmi_wwan driver as well? I assume there are devices out there with the >> same device ID, the same ff/ff/ff interface descriptors, but with >> QMI/net on interf

Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-04 Thread Petr Štetiar
Bjørn Mork [2015-11-03 13:37:56]: > I guess this means that we need to add an interface count quirk to the > qmi_wwan driver as well? I assume there are devices out there with the > same device ID, the same ff/ff/ff interface descriptors, but with > QMI/net on interface #0. Indeed, your guess i

Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-03 Thread Petr Štetiar
Bjørn Mork [2015-11-03 13:37:56]: > > + case 4: > > + /* Don't claim the QMI/net interface */ > > + altsetting = -1; > > + break; > > + } > > I guess this means that we need to add an interface count quirk to the > qmi_wwan driver as well? I assume there are de

Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-03 Thread Bjørn Mork
Petr Štetiar writes: > It seems like this device has same vendor and product IDs as G2K > devices, but it has different number of interfaces(4 vs 5) and also > different interface layout which makes it currently unusable: > > usbcore: registered new interface driver qcserial > usbseri

[PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-03 Thread Petr Štetiar
It seems like this device has same vendor and product IDs as G2K devices, but it has different number of interfaces(4 vs 5) and also different interface layout which makes it currently unusable: usbcore: registered new interface driver qcserial usbserial: USB Serial support registe