Re: [PATCH] USB: usbtmc: Add support for missing USBTMC-USB488 spec

Hi Oliver, On Wed, Oct 14, 2015 at 3:33 PM, Oliver Neukum wrote: > On Wed, 2015-10-14 at 15:13 +0200, dave penkler wrote: > > Hi, > > just a few remarks. thank you. > >> >> +static int usbtmc488_ioctl_read_stb(struct usbtmc_device_data *data, >> +

Re: [PATCH] USB: usbtmc: Add support for missing USBTMC-USB488 spec

Hi dave, [auto build test WARNING on usb/usb-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/dave-penkler/USB-usbtmc-Add-support-for-missing-USBTMC-USB488-spec/20151014-211711 reproduce: #

Re: [PATCH] USB: usbtmc: Add support for missing USBTMC-USB488 spec

On Wed, 2015-10-14 at 15:13 +0200, dave penkler wrote: Hi, just a few remarks. > > +static int usbtmc488_ioctl_read_stb(struct usbtmc_device_data *data, > + unsigned long arg) > +{ > + u8 *buffer; > + struct device *dev; > + int rv; > + u8 tag, stb;

[PATCH] USB: usbtmc: Add support for missing USBTMC-USB488 spec

Implement support for the USB488 defined READ_STATUS_BYTE and SRQ notifications with ioctl, fasync and poll/select in order to be able to synchronize with variable duration instrument operations. Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and LOCAL_LOCKOUT. Add convenience