Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue

2013-08-01 Thread Dan Carpenter
On Wed, Jul 31, 2013 at 10:26:15PM +0200, Julia Lawall wrote: On Wed, 31 Jul 2013, Kumar Gaurav wrote: Fixed String splitted into multiple line issue using macro I'm not an expert on this kind of style issue, but I prefer strings that look like strings. Yeah. This patch makes the

Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue

2013-08-01 Thread Kumar Gaurav
On Thursday 01 August 2013 10:27 AM, Jiany Wu wrote: I have the same idea with julia. It is more difficult to check the log if we use MACRO instead of the strings. If we search in the system log, according to the string, we will find out the macro first. later we also need to find out where

Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue

2013-08-01 Thread Julia Lawall
Thanks you all for suggestions. I'll try finding some other way. If the strings don't fit, you can just go over 80 characters. julia -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue

2013-07-31 Thread Kumar Gaurav
Fixed String splitted into multiple line issue using macro Signed-off-by: Kumar Gaurav kumargauravgup...@gmail.com --- drivers/staging/usbip/stub_dev.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/usbip/stub_dev.c

Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue

2013-07-31 Thread Julia Lawall
On Wed, 31 Jul 2013, Kumar Gaurav wrote: Fixed String splitted into multiple line issue using macro I'm not an expert on this kind of style issue, but I prefer strings that look like strings. julia Signed-off-by: Kumar Gaurav kumargauravgup...@gmail.com ---