Re: [PATCH] hid: migrate Dream Cheeky LED driver from USB misc to HID

2016-06-14 Thread Heiner Kallweit
Am 14.06.2016 um 21:57 schrieb Oliver Neukum: > On Tue, 2016-06-14 at 21:34 +0200, Heiner Kallweit wrote: >> Am 14.06.2016 um 10:05 schrieb Oliver Neukum: >>> On Tue, 2016-06-14 at 07:51 +0200, Heiner Kallweit wrote: >>> + ret = hid_hw_start(hdev, HID_CONNECT_HIDRAW); + if (ret) +

Re: [PATCH] hid: migrate Dream Cheeky LED driver from USB misc to HID

2016-06-14 Thread Oliver Neukum
On Tue, 2016-06-14 at 21:34 +0200, Heiner Kallweit wrote: > Am 14.06.2016 um 10:05 schrieb Oliver Neukum: > > On Tue, 2016-06-14 at 07:51 +0200, Heiner Kallweit wrote: > > > >> + ret = hid_hw_start(hdev, HID_CONNECT_HIDRAW); > >> + if (ret) > >> + return ret; > >> + > >> + minor =

Re: [PATCH] hid: migrate Dream Cheeky LED driver from USB misc to HID

2016-06-14 Thread Heiner Kallweit
Am 14.06.2016 um 10:05 schrieb Oliver Neukum: > On Tue, 2016-06-14 at 07:51 +0200, Heiner Kallweit wrote: > >> +ret = hid_hw_start(hdev, HID_CONNECT_HIDRAW); >> +if (ret) >> +return ret; >> + >> +minor = ((struct hidraw *) hdev->hidraw)->minor; >> + >> +ret =

Re: [PATCH] hid: migrate Dream Cheeky LED driver from USB misc to HID

2016-06-14 Thread Oliver Neukum
On Tue, 2016-06-14 at 07:51 +0200, Heiner Kallweit wrote: > + ret = hid_hw_start(hdev, HID_CONNECT_HIDRAW); > + if (ret) > + return ret; > + > + minor = ((struct hidraw *) hdev->hidraw)->minor; > + > + ret = dc_init_device(dcdev); That is a race condition. You

[PATCH] hid: migrate Dream Cheeky LED driver from USB misc to HID

2016-06-13 Thread Heiner Kallweit
The Dream Cheeky Webmail Notifier and Friends Alert are supported as part of usb/misc/usbled driver currently. This patch migrates the driver for these devices to the HID subsystem. Benefits: - Avoid using USB low-level calls and use the HID subsystem instead (as this device provides a USB HID