Re: [PATCH] musb: Kill __init from function that are called at other times as well.

On Thu, Sep 06, 2012 at 05:01:46PM +0300, Pantelis Antoniou wrote: Marking functions as __init or __devinit and calling them at other times leads to predictable crashes (if you're lucky). Remove them for now. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com ---

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

Hi Felipe, A proper answer required some instrumentation printks(). So what I did is that I peppered each function marked with a removed __init or __devinit with a printk(KERN_INFO %s:%d (%s) %s\n, __FILE__, __LINE__, KBUILD_MODNAME, __func__); Both omap2430 musb_hdrc are compiled as

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

Hi, On Thu, Sep 06, 2012 at 05:58:27PM +0300, Pantelis Antoniou wrote: Hi Felipe, A proper answer required some instrumentation printks(). So what I did is that I peppered each function marked with a removed __init or __devinit with a printk(KERN_INFO %s:%d (%s) %s\n, __FILE__,

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

Hi Felipe I see about __devinit. There's no crash because in those logs the __init modifiers are gone. Regards -- Pantelis On Sep 6, 2012, at 8:07 PM, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 05:58:27PM +0300, Pantelis Antoniou wrote: Hi Felipe, A proper answer required some

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

Hi, On Thu, Sep 06, 2012 at 08:36:39PM +0300, Pantelis Antoniou wrote: Hi Felipe I see about __devinit. There's no crash because in those logs the __init modifiers are gone. it'd be cool to see the crash, though ;-) -- balbi signature.asc Description: Digital signature

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

On Sep 6, 2012, at 8:37 PM, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 08:36:39PM +0300, Pantelis Antoniou wrote: Hi Felipe I see about __devinit. There's no crash because in those logs the __init modifiers are gone. it'd be cool to see the crash, though ;-) -- balbi Heh,

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

Hi, On Thu, Sep 06, 2012 at 08:42:56PM +0300, Pantelis Antoniou wrote: On Sep 6, 2012, at 8:37 PM, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 08:36:39PM +0300, Pantelis Antoniou wrote: Hi Felipe I see about __devinit. There's no crash because in those logs the __init

[PATCH] musb: Kill __init from function that are called at other times as well.

Marking functions as __init or __devinit and calling them at other times leads to predictable crashes (if you're lucky). Remove them for now. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- drivers/usb/musb/musb_core.c| 16 drivers/usb/musb/musb_debugfs.c