Re: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

Hi, John Youn writes: >> Felipe Balbi writes: >>> At least macOS seems to be sending >>> ClearFeature(ENDPOINT_HALT) to endpoints which >>> aren't Halted. This makes DWC3's CLEARSTALL command >>> time out which causes several issues for the

Re: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

On 04/04/2017 01:09 AM, Felipe Balbi wrote: > > Hi John, > > Felipe Balbi writes: >> At least macOS seems to be sending >> ClearFeature(ENDPOINT_HALT) to endpoints which >> aren't Halted. This makes DWC3's CLEARSTALL command >> time out which causes several issues

Re: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

Hi John, Felipe Balbi writes: > At least macOS seems to be sending > ClearFeature(ENDPOINT_HALT) to endpoints which > aren't Halted. This makes DWC3's CLEARSTALL command > time out which causes several issues for the driver. > > Instead, let's just return 0 and

RE: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

Hi, Felipe Balbi writes: >>> I've been looking at this and based on sniffer and dwc3 tracepoints, it >>> seems like dwc3 is behaving properly. The real issue seems to be that >>> g_mass_storage isn't queueing a new request to IN endpoint. >>> >>> I'll continue

RE: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

Hi, Felipe Balbi writes: >> Thinh Nguyen writes: drivers/usb/dwc3/gadget.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index

RE: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

Hi Thinh, Thinh Nguyen writes: >> drivers/usb/dwc3/gadget.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 6faf484e5dfc..0a664d8eba3f 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++

RE: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

Felipe Balbi writes: > Hi Thinh, > > Thinh Nguyen writes: >>> drivers/usb/dwc3/gadget.c | 5 + >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >>> index

[PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

At least macOS seems to be sending ClearFeature(ENDPOINT_HALT) to endpoints which aren't Halted. This makes DWC3's CLEARSTALL command time out which causes several issues for the driver. Instead, let's just return 0 and bail out early. Cc: Signed-off-by: Felipe Balbi