clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/usb/gadget/udc/mv_udc_core.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/udc/mv_udc_core.c 
b/drivers/usb/gadget/udc/mv_udc_core.c
index 76f56c5..8a708d0 100644
--- a/drivers/usb/gadget/udc/mv_udc_core.c
+++ b/drivers/usb/gadget/udc/mv_udc_core.c
@@ -960,9 +960,9 @@ static int mv_ep_set_wedge(struct usb_ep *_ep)
        .fifo_flush     = mv_ep_fifo_flush,     /* flush fifo */
 };
 
-static void udc_clock_enable(struct mv_udc *udc)
+static int udc_clock_enable(struct mv_udc *udc)
 {
-       clk_prepare_enable(udc->clk);
+       return clk_prepare_enable(udc->clk);
 }
 
 static void udc_clock_disable(struct mv_udc *udc)
@@ -1070,7 +1070,10 @@ static int mv_udc_enable_internal(struct mv_udc *udc)
                return 0;
 
        dev_dbg(&udc->dev->dev, "enable udc\n");
-       udc_clock_enable(udc);
+       retval = udc_clock_enable(udc);
+       if (retval)
+               return retval;
+
        if (udc->pdata->phy_init) {
                retval = udc->pdata->phy_init(udc->phy_regs);
                if (retval) {
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to