Re: [PATCH] usb: gadget zero: avoid unnecessary reinit of data in f_sourcesink

2012-12-18 Thread Sebastian Andrzej Siewior
On Mon, Dec 17, 2012 at 06:21:16PM +0100, Armando Visconti wrote: Besides that the patch looks fine :) Do you mean that 'inited' should be changed with 'initialized'? Yes, I do. Oh ... my poor english... :( Don't worry. Others, including myself, do this from time to time as well :) Rgds,

Re: [PATCH] usb: gadget zero: avoid unnecessary reinit of data in f_sourcesink

2012-12-17 Thread Sebastian Andrzej Siewior
On Thu, Dec 13, 2012 at 03:11:19PM +0100, Armando Visconti wrote: In the IN case, since the USB request is allocated only when the source/sink function is started and never freed, the USB ept buffer needs to be inited only at the beginning. This change ^^ results into

Re: [PATCH] usb: gadget zero: avoid unnecessary reinit of data in f_sourcesink

2012-12-17 Thread Armando Visconti
On 12/17/2012 04:45 PM, Sebastian Andrzej Siewior wrote: On Thu, Dec 13, 2012 at 03:11:19PM +0100, Armando Visconti wrote: In the IN case, since the USB request is allocated only when the source/sink function is started and never freed, the USB ept buffer needs to be inited only at the

[PATCH] usb: gadget zero: avoid unnecessary reinit of data in f_sourcesink

2012-12-13 Thread Armando Visconti
In the IN case, since the USB request is allocated only when the source/sink function is started and never freed, the USB ept buffer needs to be inited only at the beginning. This change results into a more performant g_zero module, especially when 'pattern=1' is selected. Signed-off-by: Armando