Re: [PATCH] usb: host: Add MAX3421E HCD support.

2014-03-24 Thread Felipe Balbi
Hi, On Fri, Mar 21, 2014 at 09:55:25PM -0600, David Mosberger wrote: Felipe, Thanks for your feedback, I'll take that into consideration. On Fri, Mar 21, 2014 at 9:44 PM, Felipe Balbi ba...@ti.com wrote: + max3421_hcd-spi_thread = kthread_run(max3421_spi_thread, hcd, +

Re: [PATCH] usb: host: Add MAX3421E HCD support.

2014-03-24 Thread David Mosberger
Felipe, On Mon, Mar 24, 2014 at 7:31 AM, Felipe Balbi ba...@ti.com wrote: Why do you need to run your IRQ handler when an URQ gets enqueued ? That doesn't make much sense :-s Please see the comments at the start of the file: spi_sync() is blocking and must not be called while holding

Re: [PATCH] usb: host: Add MAX3421E HCD support.

2014-03-24 Thread Felipe Balbi
Hi, On Mon, Mar 24, 2014 at 09:21:40AM -0600, David Mosberger wrote: Felipe, On Mon, Mar 24, 2014 at 7:31 AM, Felipe Balbi ba...@ti.com wrote: Why do you need to run your IRQ handler when an URQ gets enqueued ? That doesn't make much sense :-s Please see the comments at the start of

Re: [PATCH] usb: host: Add MAX3421E HCD support.

2014-03-24 Thread Alan Stern
On Mon, 24 Mar 2014, Felipe Balbi wrote: Hi, On Mon, Mar 24, 2014 at 09:21:40AM -0600, David Mosberger wrote: Felipe, On Mon, Mar 24, 2014 at 7:31 AM, Felipe Balbi ba...@ti.com wrote: Why do you need to run your IRQ handler when an URQ gets enqueued ? That doesn't make much

Re: [PATCH] usb: host: Add MAX3421E HCD support.

2014-03-24 Thread Felipe Balbi
On Mon, Mar 24, 2014 at 03:22:10PM -0400, Alan Stern wrote: On Mon, 24 Mar 2014, Felipe Balbi wrote: Hi, On Mon, Mar 24, 2014 at 09:21:40AM -0600, David Mosberger wrote: Felipe, On Mon, Mar 24, 2014 at 7:31 AM, Felipe Balbi ba...@ti.com wrote: Why do you need to run

Re: [PATCH] usb: host: Add MAX3421E HCD support.

2014-03-24 Thread David Mosberger
On Mon, Mar 24, 2014 at 1:35 PM, Felipe Balbi ba...@ti.com wrote: looking at the driver, there's still quite a bit of duplication between his kthread implementation and what threaded IRQs would give for free... Well, let's count: hard irq handler: static irqreturn_t max3421_irq_handler(int

[PATCH] usb: host: Add MAX3421E HCD support.

2014-03-21 Thread David Mosberger
Sorry, I keep forgetting how bad gmail is in handling patches... Here is a retransmit in plain-text format (really). The patch is relative to linux-next. The Maxim MAX3421E is a USB-over-SPI chip that can operate either in peripheral or host mode. This driver adds support for the host-mode

Re: [PATCH] usb: host: Add MAX3421E HCD support.

2014-03-21 Thread David Mosberger
Felipe, Thanks for your feedback, I'll take that into consideration. On Fri, Mar 21, 2014 at 9:44 PM, Felipe Balbi ba...@ti.com wrote: + max3421_hcd-spi_thread = kthread_run(max3421_spi_thread, hcd, + max3421_spi_thread); why do you need this