Re: [PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Robert Jarzmik
Felipe Balbi ba...@ti.com writes: At the same time, declare the interrupt as one shot so that it is masked until the end of the threaded handler. This prevents the irq core from spitting out an error : Threaded irq requested with handler=NULL and !ONESHOT for irq 63 Shouldn't this be

Re: [PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Sören Brinkmann
On Wed, 2015-01-28 at 09:29AM +0100, Robert Jarzmik wrote: All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit usb: phy: generic: migrate to gpio_desc. At the same time,

Re: [PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Fabio Estevam
On Wed, Jan 28, 2015 at 6:29 AM, Robert Jarzmik robert.jarz...@free.fr wrote: All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit usb: phy: generic: migrate to gpio_desc. At

Re: [PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Felipe Balbi
On Wed, Jan 28, 2015 at 10:21:11AM -0800, Sören Brinkmann wrote: On Wed, 2015-01-28 at 09:29AM +0100, Robert Jarzmik wrote: All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by

Re: [PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Felipe Balbi
On Wed, Jan 28, 2015 at 08:04:20PM +0100, Robert Jarzmik wrote: Felipe Balbi ba...@ti.com writes: At the same time, declare the interrupt as one shot so that it is masked until the end of the threaded handler. This prevents the irq core from spitting out an error : Threaded irq

[PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Robert Jarzmik
All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit usb: phy: generic: migrate to gpio_desc. At the same time, declare the interrupt as one shot so that it is masked until the end