Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-12-02 Thread Julius Werner
*ping* Is anyone still reading this or should I resubmit? Sorry for being annoying, just please let me know if this is already considered to get picked up at the next opportunity or if you've intentionally decided against it for now. I want to make sure it didn't fall through the cracks

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-11-06 Thread Julius Werner
*bump* Hi Sarah, is there anything else that needs to be resolved to pick this patch up? Looks like Matthias' recent LPM fixes are all in now so there should be no way this could cause any trouble? -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-29 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 04:08:12PM -0700, Julius Werner wrote: So the 2.41a has BESL support, but may not set the BLC flag. What happens if we use the HIRD encoding instead? Will things break? It seems like we would need to disable USB 2.0 LPM on that host all together, if it expects

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-29 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 10:15:34PM +, Paul Zimmerman wrote: From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] Sent: Wednesday, August 28, 2013 2:52 PM On Mon, Aug 26, 2013 at 07:37:56PM +, Paul Zimmerman wrote: From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com]

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-29 Thread Julius Werner
If you take a look at Table 13: BESL/HIRD Encoding from the xHCI spec version including errata to 08/14/2012 Could you please provide a link to that errata? I still cannot find it... but from your explanation, that design decision sounds pretty horrible. Why didn't they just choose not to set

RE: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-29 Thread Paul Zimmerman
From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] Sent: Thursday, August 29, 2013 10:42 AM On Wed, Aug 28, 2013 at 10:15:34PM +, Paul Zimmerman wrote: From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] Sent: Wednesday, August 28, 2013 2:52 PM On Mon, Aug 26, 2013

RE: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-29 Thread Paul Zimmerman
From: jwer...@google.com [mailto:jwer...@google.com] On Behalf Of Julius Werner Sent: Thursday, August 29, 2013 11:07 AM If you take a look at Table 13: BESL/HIRD Encoding from the xHCI spec version including errata to 08/14/2012 Could you please provide a link to that errata? I

RE: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-28 Thread Paul Zimmerman
From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] Sent: Wednesday, August 28, 2013 2:52 PM On Mon, Aug 26, 2013 at 07:37:56PM +, Paul Zimmerman wrote: From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] Sent: Monday, August 26, 2013 12:14 PM On Thu, Aug 22, 2013 at

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-28 Thread Julius Werner
So the 2.41a has BESL support, but may not set the BLC flag. What happens if we use the HIRD encoding instead? Will things break? It seems like we would need to disable USB 2.0 LPM on that host all together, if it expects BESL encoding, but advertises HIRD encoding. Wait a second, just for

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-26 Thread Sarah Sharp
On Thu, Aug 22, 2013 at 05:11:49AM +, Paul Zimmerman wrote: From: Julius Werner Sent: Wednesday, August 21, 2013 9:22 PM You need the USB 2.0 spec errata from 2011-11 that describes the changes made for BESL as well. It's in the USB2-LPM-Errata-final.pdf and

RE: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-26 Thread Paul Zimmerman
From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] Sent: Monday, August 26, 2013 12:14 PM On Thu, Aug 22, 2013 at 05:11:49AM +, Paul Zimmerman wrote: From: Julius Werner Sent: Wednesday, August 21, 2013 9:22 PM You need the USB 2.0 spec errata from 2011-11 that

RE: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-26 Thread Paul Zimmerman
From: Paul Zimmerman Sent: Monday, August 26, 2013 12:38 PM ... So it may be safer to say that the feature is present starting with 2.50a. In 2.51a it has been well-tested in simulation. In actual hardware, it That should have said: In 2.50a it has been well-tested in simulation... --

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-21 Thread Sarah Sharp
Hi Julius, Thanks for the patch! Did you test with a USB analyzer to see if the device was actually going into USB 2.0 Link PM? I'd like to confirm we really aren't breaking anything for DW3 hosts by enabling this. Sarah Sharp On Tue, Aug 20, 2013 at 04:21:49PM -0700, Julius Werner wrote:

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-21 Thread Julius Werner
Thanks for the patch! Did you test with a USB analyzer to see if the device was actually going into USB 2.0 Link PM? I'd like to confirm we really aren't breaking anything for DW3 hosts by enabling this. Yes, I did. The LPM transfers on the analyzer look good and the device works as

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-21 Thread Sarah Sharp
On Wed, Aug 21, 2013 at 02:43:55PM -0700, Julius Werner wrote: Thanks for the patch! Did you test with a USB analyzer to see if the device was actually going into USB 2.0 Link PM? I'd like to confirm we really aren't breaking anything for DW3 hosts by enabling this. Yes, I did. The LPM

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-21 Thread Greg Kroah-Hartman
On Wed, Aug 21, 2013 at 05:45:14PM -0700, Sarah Sharp wrote: On Wed, Aug 21, 2013 at 02:43:55PM -0700, Julius Werner wrote: Thanks for the patch! Did you test with a USB analyzer to see if the device was actually going into USB 2.0 Link PM? I'd like to confirm we really aren't breaking

RE: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-21 Thread Paul Zimmerman
From: Julius Werner Sent: Wednesday, August 21, 2013 9:22 PM You need the USB 2.0 spec errata from 2011-11 that describes the changes made for BESL as well. It's in the USB2-LPM-Errata-final.pdf and USB2_LinkPowerMangement_ECN[final].pdf files in this zip file:

[PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-20 Thread Julius Werner
The driver methods required for hardware LPM have only been added to the PCI version of the XHCI driver, for no apparent reason. They seem to work just as well with the platform driver, so let's add them to give more devices the chance for additional power savings. Tested on the DWC3 xHC of an