Re: [PATCH] usb-core bInterval quirks

2014-07-23 Thread Alan Stern
On Tue, 22 Jul 2014, James P Michels III wrote: This patch adds usb quirks to improve support for devices with non standard bInterval values. Quirks are added to support devices with bInterval values expressed as microframes or frames. The quirks cause the parse endpoint function to modify

Re: [PATCH] usb-core bInterval quirks

2014-07-23 Thread James Michels
The Razer reports a bInterval of 8 which the current driver ultimately interprets as 16ms. The keyboard is an anti-ghosting gaming keyboard and needs to be polled at 1ms. This corresponds to a corrected bInterval of 4. I'm not sure why this doesn't make sense to you, but I do agree that there is

Re: [PATCH] usb-core bInterval quirks

2014-07-23 Thread Greg Kroah-Hartman
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Jul 23, 2014 at 11:48:48AM -0400, James Michels wrote: The Razer reports a bInterval of 8 which the current driver ultimately interprets as 16ms. The keyboard is an anti-ghosting gaming

Re: [PATCH] usb-core bInterval quirks

2014-07-23 Thread Alan Stern
On Wed, 23 Jul 2014, James Michels wrote: The Razer reports a bInterval of 8 which the current driver ultimately interprets as 16ms. The keyboard is an anti-ghosting gaming keyboard and needs to be polled at 1ms. This corresponds to a corrected bInterval of 4. Okay, that's reasonable. A

Re: [PATCH] usb-core bInterval quirks

2014-07-23 Thread James Michels
I must disagree, the device driver most certainly does guess. See the code snipet below. Particularly the part about guessed and try to fix. FWIW, it's the try to fix part that doesn't catch this scenario. /* Fix up bInterval values outside the legal range. Use 32 ms if no * proper value can be

Re: [PATCH] usb-core bInterval quirks

2014-07-23 Thread Alan Stern
On Wed, 23 Jul 2014, James Michels wrote: I must disagree, the device driver most certainly does guess. See the code snipet below. Particularly the part about guessed and try to fix. FWIW, it's the try to fix part that doesn't catch this scenario. You didn't read what I wrote in context.

Re: [PATCH] usb-core bInterval quirks

2014-07-23 Thread James Michels
OK, will do. Thanks Jim -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb-core bInterval quirks

2014-07-22 Thread James P Michels III
This patch adds usb quirks to improve support for devices with non standard bInterval values. Quirks are added to support devices with bInterval values expressed as microframes or frames. The quirks cause the parse endpoint function to modify the reported bInterval to the standards conforming

Re: [PATCH] usb-core bInterval quirks

2014-07-22 Thread Greg KH
On Tue, Jul 22, 2014 at 08:02:10PM -0400, James P Michels III wrote: This patch adds usb quirks to improve support for devices with non standard bInterval values. Quirks are added to support devices with bInterval values expressed as microframes or frames. The quirks cause the parse

Re: [PATCH] usb-core bInterval quirks

2014-07-22 Thread James Michels
I do believe that I did. + /* Razer - Razer Blade Keyboard */ + { USB_DEVICE(0x1532, 0x0116), .driver_info = + USB_QUIRK_INTERVAL_AS_MICROFRAMES }, + Am I missing something still? Regards Jim On Tue, Jul 22, 2014 at 8:17 PM, Greg KH g...@kroah.com wrote: On

Re: [PATCH] usb-core bInterval quirks

2014-07-22 Thread James Michels
I think I understand your concern now. You mean that I am only adding a quirk for the devices with their interval reported as microframes. After reading the code comments about many other vendors having similar issues, I thought it was more complete, and potentially less confusing, for the