Re: [PATCH] usbip: vudc: Refactor init_vudc_hw() to be more obvious

2016-12-02 Thread Krzysztof Opasiak
On 12/02/2016 04:37 PM, Shuah Khan wrote: > On 12/02/2016 08:27 AM, Krzysztof Opasiak wrote: >> >> >> On 12/02/2016 04:15 PM, Shuah Khan wrote: >>> Hi Krzysztof, >>> >>> Thanks for the patch. >>> >>> On 12/01/2016 10:02 AM, Krzysztof Opasiak wrote: Current implementation of init_vudc_hw()

Re: [PATCH] usbip: vudc: Refactor init_vudc_hw() to be more obvious

2016-12-02 Thread Shuah Khan
Hi Krzysztof, Thanks for the patch. On 12/01/2016 10:02 AM, Krzysztof Opasiak wrote: > Current implementation of init_vudc_hw() adds ep0 to ep_list > and then after looping through all endpoints removes it from > that list. > > As this may be misleading let's refactor this function > and avoid

Re: [PATCH] usbip: vudc: Refactor init_vudc_hw() to be more obvious

2016-12-02 Thread Shuah Khan
On 12/02/2016 08:27 AM, Krzysztof Opasiak wrote: > > > On 12/02/2016 04:15 PM, Shuah Khan wrote: >> Hi Krzysztof, >> >> Thanks for the patch. >> >> On 12/01/2016 10:02 AM, Krzysztof Opasiak wrote: >>> Current implementation of init_vudc_hw() adds ep0 to ep_list >>> and then after looping through

Re: [PATCH] usbip: vudc: Refactor init_vudc_hw() to be more obvious

2016-12-02 Thread Krzysztof Opasiak
On 12/02/2016 04:15 PM, Shuah Khan wrote: > Hi Krzysztof, > > Thanks for the patch. > > On 12/01/2016 10:02 AM, Krzysztof Opasiak wrote: >> Current implementation of init_vudc_hw() adds ep0 to ep_list >> and then after looping through all endpoints removes it from >> that list. >> >> As this

[PATCH] usbip: vudc: Refactor init_vudc_hw() to be more obvious

2016-12-01 Thread Krzysztof Opasiak
Current implementation of init_vudc_hw() adds ep0 to ep_list and then after looping through all endpoints removes it from that list. As this may be misleading let's refactor this function and avoid adding and removing ep0 to eplist and place it immediately in correct place. Signed-off-by: