Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-12-05 Thread Alan Stern
On Wed, 5 Dec 2012, Lan Tianyu wrote: Hi Alan: how about following patch? Index: usb/drivers/usb/core/hub.c === --- usb.orig/drivers/usb/core/hub.c +++ usb/drivers/usb/core/hub.c +void

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-12-05 Thread Lan Tianyu
On 2012年12月05日 23:58, Alan Stern wrote: On Wed, 5 Dec 2012, Lan Tianyu wrote: Hi Alan: how about following patch? Index: usb/drivers/usb/core/hub.c === --- usb.orig/drivers/usb/core/hub.c +++ usb/drivers/usb/core/hub.c

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-12-04 Thread Lan Tianyu
On 2012年11月29日 08:08, Alan Stern wrote: On Wed, 28 Nov 2012, Sarah Sharp wrote: The shared code to overwrite the bits should probably print a warning if the host and ACPI bits differ. I'm not so sure about that. For one thing, who wants warnings to be logged every time they run lsusb -v?

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-28 Thread Alan Stern
On Sat, 17 Nov 2012, Lan Tianyu wrote: ACPI provide _PLD and _UPC aml methods to describe usb port visibility and connectability. This patch is to use those information to change ehci root hub descriptors and set usb hub port's DeviceRemovable in the hub_configure(). When hub descriptor

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-28 Thread Sarah Sharp
On Wed, Nov 28, 2012 at 12:39:14PM -0500, Alan Stern wrote: On Sat, 17 Nov 2012, Lan Tianyu wrote: --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1546,6 +1546,25 @@ static int hub_configure(struct usb_hub *hub, dev_err(hub-intfdev,

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-28 Thread Alan Stern
On Wed, 28 Nov 2012, Sarah Sharp wrote: On Wed, Nov 28, 2012 at 12:39:14PM -0500, Alan Stern wrote: On Sat, 17 Nov 2012, Lan Tianyu wrote: --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1546,6 +1546,25 @@ static int hub_configure(struct usb_hub *hub,

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-28 Thread Sarah Sharp
On Wed, Nov 28, 2012 at 01:56:46PM -0500, Alan Stern wrote: On Wed, 28 Nov 2012, Sarah Sharp wrote: On Wed, Nov 28, 2012 at 12:39:14PM -0500, Alan Stern wrote: Instead, how about sticking the new code into a separate function: void hub_adjust_DeviceRemovable(struct usb_device

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-28 Thread Alan Stern
On Wed, 28 Nov 2012, Sarah Sharp wrote: The shared code to overwrite the bits should probably print a warning if the host and ACPI bits differ. I'm not so sure about that. For one thing, who wants warnings to be logged every time they run lsusb -v? Yeah, that's probably not a

[PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-17 Thread Lan Tianyu
ACPI provide _PLD and _UPC aml methods to describe usb port visibility and connectability. This patch is to use those information to change ehci root hub descriptors and set usb hub port's DeviceRemovable in the hub_configure(). When hub descriptor request is issued at first time, usb port device