[PATCH 09/21] USB: serial: digi_acceleport: simplify endpoint check

[Johan Hovold]

Simplify the endpoint sanity check by letting core verify that the
required endpoints are present.

Note that this driver uses an additional bulk-endpoint pair as an
out-of-band port.

Signed-off-by: Johan Hovold <jo...@kernel.org>
---
 drivers/usb/serial/digi_acceleport.c | 23 ++++-------------------
 1 file changed, 4 insertions(+), 19 deletions(-)

diff --git a/drivers/usb/serial/digi_acceleport.c 
b/drivers/usb/serial/digi_acceleport.c
index eb433922598c..dc44c38525e1 100644
--- a/drivers/usb/serial/digi_acceleport.c
+++ b/drivers/usb/serial/digi_acceleport.c
@@ -272,6 +272,8 @@ static struct usb_serial_driver digi_acceleport_2_device = {
        .description =                  "Digi 2 port USB adapter",
        .id_table =                     id_table_2,
        .num_ports =                    3,
+       .num_bulk_in =                  4,
+       .num_bulk_out =                 4,
        .open =                         digi_open,
        .close =                        digi_close,
        .dtr_rts =                      digi_dtr_rts,
@@ -301,6 +303,8 @@ static struct usb_serial_driver digi_acceleport_4_device = {
        .description =                  "Digi 4 port USB adapter",
        .id_table =                     id_table_4,
        .num_ports =                    4,
+       .num_bulk_in =                  5,
+       .num_bulk_out =                 5,
        .open =                         digi_open,
        .close =                        digi_close,
        .write =                        digi_write,
@@ -1250,27 +1254,8 @@ static int digi_port_init(struct usb_serial_port *port, 
unsigned port_num)
 
 static int digi_startup(struct usb_serial *serial)
 {
-       struct device *dev = &serial->interface->dev;
        struct digi_serial *serial_priv;
        int ret;
-       int i;
-
-       /* check whether the device has the expected number of endpoints */
-       if (serial->num_port_pointers < serial->type->num_ports + 1) {
-               dev_err(dev, "OOB endpoints missing\n");
-               return -ENODEV;
-       }
-
-       for (i = 0; i < serial->type->num_ports + 1 ; i++) {
-               if (!serial->port[i]->read_urb) {
-                       dev_err(dev, "bulk-in endpoint missing\n");
-                       return -ENODEV;
-               }
-               if (!serial->port[i]->write_urb) {
-                       dev_err(dev, "bulk-out endpoint missing\n");
-                       return -ENODEV;
-               }
-       }
 
        serial_priv = kzalloc(sizeof(*serial_priv), GFP_KERNEL);
        if (!serial_priv)
-- 
2.12.0

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html