Re: [PATCH 1/1] USB-SERIAL : Changing usb_serial_generic_open prototype

2015-06-02 Thread Abhishek bist
Yes, I gone through this warning. It is because if i want to make this compilation warning free than i have to change the prototype of a open function pointer described in usb_serial_driver and changing the prototype over there would affect all the device driver lying in usb-serial category ,

Re: [PATCH 1/1] USB-SERIAL : Changing usb_serial_generic_open prototype

2015-06-02 Thread Johan Hovold
[ Please avoid top-posting. ] On Tue, Jun 02, 2015 at 02:49:30PM +0530, Abhishek bist wrote: Yes, I gone through this warning. It is because if i want to make this compilation warning free than i have to change the prototype of a open function pointer described in usb_serial_driver and

Re: [PATCH 1/1] USB-SERIAL : Changing usb_serial_generic_open prototype

2015-06-01 Thread Johan Hovold
On Sat, May 30, 2015 at 06:47:20PM +0530, Abhishek Bist wrote: While designing a usb to uart converter driver open function I am using usb_serial_generic_open, but wouldn't find need to pass tty as an argument. As it is not performing any task for further significance. So, This patch

[PATCH 1/1] USB-SERIAL : Changing usb_serial_generic_open prototype

2015-05-30 Thread Abhishek Bist
While designing a usb to uart converter driver open function I am using usb_serial_generic_open, but wouldn't find need to pass tty as an argument. As it is not performing any task for further significance. So, This patch proposed a change in usb_serial_generic_open function prototype