Re: [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect

2017-10-09 Thread Johan Hovold
On Mon, Oct 09, 2017 at 01:05:30PM +0200, Andrey Konovalov wrote: > On Wed, Oct 4, 2017 at 11:01 AM, Johan Hovold wrote: > > A clean-up patch removing removing two redundant NULL-checks from the > > console disconnect handler inadvertently also removed a third check. > > This

Re: [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect

2017-10-09 Thread Andrey Konovalov
On Wed, Oct 4, 2017 at 11:01 AM, Johan Hovold wrote: > A clean-up patch removing removing two redundant NULL-checks from the > console disconnect handler inadvertently also removed a third check. > This could lead to the struct usb_serial being prematurely freed by the > console

Re: [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect

2017-10-09 Thread Johan Hovold
On Sat, Oct 07, 2017 at 05:56:17PM +0900, Jaejoong Kim wrote: > Hi > > 2017-10-04 18:01 GMT+09:00 Johan Hovold : > > A clean-up patch removing removing two redundant NULL-checks from the >^^ > The word 'removing' was written twice.

Re: [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect

2017-10-07 Thread Jaejoong Kim
Hi 2017-10-04 18:01 GMT+09:00 Johan Hovold : > A clean-up patch removing removing two redundant NULL-checks from the ^^ The word 'removing' was written twice. :) > console disconnect handler inadvertently also removed a third

Re: [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect

2017-10-04 Thread Greg KH
On Wed, Oct 04, 2017 at 11:01:12AM +0200, Johan Hovold wrote: > A clean-up patch removing removing two redundant NULL-checks from the > console disconnect handler inadvertently also removed a third check. > This could lead to the struct usb_serial being prematurely freed by the > console code when

[PATCH 1/2] USB: serial: console: fix use-after-free on disconnect

2017-10-04 Thread Johan Hovold
A clean-up patch removing removing two redundant NULL-checks from the console disconnect handler inadvertently also removed a third check. This could lead to the struct usb_serial being prematurely freed by the console code when a driver accepts but does not register any ports for an interface