Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-20 Thread Pavel Machek
In current state I review all 3 patches as: Rejected-by: Pali Rohár pali.ro...@gmail.com [It breaks booting Nokia N900 device] next step, figure why it's broken. Working just fine here on AM335x which has the same musb IP. Why is broken? That is

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-20 Thread Felipe Balbi
On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: In current state I review all 3 patches as: Rejected-by: Pali Rohár pali.ro...@gmail.com [It breaks booting Nokia N900 device] next step, figure why it's broken. Working just fine here on

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-20 Thread Pavel Machek
On Fri 2015-02-20 08:39:06, Felipe Balbi wrote: On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: In current state I review all 3 patches as: Rejected-by: Pali Rohár pali.ro...@gmail.com [It breaks booting Nokia N900 device] next step,

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-20 Thread Felipe Balbi
On Sat, Feb 21, 2015 at 01:14:00AM -0600, Felipe Balbi wrote: Hi, On Fri, Feb 20, 2015 at 10:15:52PM +0100, Pavel Machek wrote: On Fri 2015-02-20 08:39:06, Felipe Balbi wrote: On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: In current state I review all 3 patches

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-20 Thread Felipe Balbi
Hi, On Fri, Feb 20, 2015 at 10:15:52PM +0100, Pavel Machek wrote: On Fri 2015-02-20 08:39:06, Felipe Balbi wrote: On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote: In current state I review all 3 patches as: Rejected-by: Pali Rohár pali.ro...@gmail.com

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-19 Thread Pali Rohár
On Thursday 05 February 2015 13:38:58 Pali Rohár wrote: On Tuesday 03 February 2015 20:57:11 Pali Rohár wrote: On Tuesday 03 February 2015 20:35:25 Felipe Balbi wrote: On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote:

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-19 Thread Felipe Balbi
On Fri, Feb 20, 2015 at 01:09:48AM +0100, Pali Rohár wrote: On Thursday 05 February 2015 13:38:58 Pali Rohár wrote: On Tuesday 03 February 2015 20:57:11 Pali Rohár wrote: On Tuesday 03 February 2015 20:35:25 Felipe Balbi wrote: On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote:

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-05 Thread Pali Rohár
On Tuesday 03 February 2015 20:57:11 Pali Rohár wrote: On Tuesday 03 February 2015 20:35:25 Felipe Balbi wrote: On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-04 Thread Pavel Machek
On Tue 2015-02-03 13:18:59, Felipe Balbi wrote: On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: Hi, On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 00:15:19 Felipe Balbi

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Pali Rohár
On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: f_phonet's -set_alt() method will call usb_ep_disable() potentially on an endpoint which is already disabled. That's something the gadget/function driver must guarantee that it's always balanced. In order to balance the calls, just

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Pali Rohár
On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: Hi, On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: f_phonet's -set_alt() method will call usb_ep_disable() potentially on an endpoint which is already

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Felipe Balbi
Hi, On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: f_phonet's -set_alt() method will call usb_ep_disable() potentially on an endpoint which is already disabled. That's something the gadget/function driver must guarantee

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Felipe Balbi
On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: Hi, On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: f_phonet's -set_alt() method will call

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Pali Rohár
On Tuesday 03 February 2015 20:51:34 Felipe Balbi wrote: On Tue, Feb 03, 2015 at 01:35:25PM -0600, Felipe Balbi wrote: On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Pali Rohár
On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: Hi, On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 00:15:19 Felipe

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Felipe Balbi
On Tue, Feb 03, 2015 at 01:35:25PM -0600, Felipe Balbi wrote: On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 16:43:45 Felipe Balbi

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Felipe Balbi
Hi, On Tue, Feb 03, 2015 at 08:57:11PM +0100, Pali Rohár wrote: f_phonet's -set_alt() method will call usb_ep_disable() potentially on an endpoint which is already disabled. That's something the gadget/function driver must guarantee that it's always

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Felipe Balbi
On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: Hi, On Tue, Feb 03, 2015 at 04:31:51PM +0100,

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Pali Rohár
On Tuesday 03 February 2015 20:35:25 Felipe Balbi wrote: On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: On Tuesday 03 February 2015 16:43:45 Felipe Balbi

[PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-02 Thread Felipe Balbi
f_phonet's -set_alt() method will call usb_ep_disable() potentially on an endpoint which is already disabled. That's something the gadget/function driver must guarantee that it's always balanced. In order to balance the calls, just make sure the endpoint was enabled before by means of checking