Re: [PATCH 1/3] usb: musb: convert printk to pr_*

2015-11-30 Thread Rasmus Villemoes
On Sat, Nov 28 2015, Sergei Shtylyov wrote: > On 11/28/2015 3:04 AM, Greg Kroah-Hartman wrote: > This file already uses pr_debug in a few places; this converts the remaining printks. >>> >>> Are you aware that printk(KERN_DEBUG, ...) and

Re: [PATCH 1/3] usb: musb: convert printk to pr_*

2015-11-28 Thread Sergei Shtylyov
On 11/28/2015 3:04 AM, Greg Kroah-Hartman wrote: This file already uses pr_debug in a few places; this converts the remaining printks. Are you aware that printk(KERN_DEBUG, ...) and pr_debug() are not equivalent? Yes, and that is a good thing, you should be using pr_debug() instead of

Re: [PATCH 1/3] usb: musb: convert printk to pr_*

2015-11-27 Thread Sergei Shtylyov
Hello. On 11/27/2015 1:38 PM, Rasmus Villemoes wrote: This file already uses pr_debug in a few places; this converts the remaining printks. Are you aware that printk(KERN_DEBUG, ...) and pr_debug() are not equivalent? Signed-off-by: Rasmus Villemoes [...]

Re: [PATCH 1/3] usb: musb: convert printk to pr_*

2015-11-27 Thread Greg Kroah-Hartman
On Fri, Nov 27, 2015 at 03:23:33PM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/27/2015 1:38 PM, Rasmus Villemoes wrote: > > >This file already uses pr_debug in a few places; this converts the > >remaining printks. > >Are you aware that printk(KERN_DEBUG, ...) and pr_debug() are not >

[PATCH 1/3] usb: musb: convert printk to pr_*

2015-11-27 Thread Rasmus Villemoes
This file already uses pr_debug in a few places; this converts the remaining printks. Signed-off-by: Rasmus Villemoes --- drivers/usb/musb/musb_core.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/usb/musb/musb_core.c