Re: [PATCH 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

2016-06-03 Thread Hans de Goede
Hi, On 03-06-16 15:12, Bin Liu wrote: Hi, On Fri, Jun 03, 2016 at 01:39:26PM +0200, Hans de Goede wrote: Hi, On 03-06-16 13:20, Kishon Vijay Abraham I wrote: Hi, On Thursday 02 June 2016 11:01 PM, Hans de Goede wrote: Some SoCs have a single phy-hw-block with multiple phys, this is

Re: [PATCH 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

2016-06-03 Thread Bin Liu
Hi, On Fri, Jun 03, 2016 at 01:39:26PM +0200, Hans de Goede wrote: > Hi, > > On 03-06-16 13:20, Kishon Vijay Abraham I wrote: > >Hi, > > > >On Thursday 02 June 2016 11:01 PM, Hans de Goede wrote: > >>Some SoCs have a single phy-hw-block with multiple phys, this is > >>modelled by a single phy

Re: [PATCH 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

2016-06-03 Thread Hans de Goede
Hi, On 03-06-16 15:04, Bin Liu wrote: Hi, On Fri, Jun 03, 2016 at 12:34:35PM +0200, Hans de Goede wrote: Hi, On 02-06-16 20:16, Bin Liu wrote: Hi, On Thu, Jun 02, 2016 at 07:31:03PM +0200, Hans de Goede wrote: Some SoCs have a single phy-hw-block with multiple phys, this is modelled by a

Re: [PATCH 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

2016-06-03 Thread Bin Liu
Hi, On Fri, Jun 03, 2016 at 12:34:35PM +0200, Hans de Goede wrote: > Hi, > > On 02-06-16 20:16, Bin Liu wrote: > >Hi, > > > >On Thu, Jun 02, 2016 at 07:31:03PM +0200, Hans de Goede wrote: > >>Some SoCs have a single phy-hw-block with multiple phys, this is > >>modelled by a single phy dts node,

Re: [PATCH 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

2016-06-03 Thread Hans de Goede
Hi, On 03-06-16 13:20, Kishon Vijay Abraham I wrote: Hi, On Thursday 02 June 2016 11:01 PM, Hans de Goede wrote: Some SoCs have a single phy-hw-block with multiple phys, this is modelled by a single phy dts node, so we end up with multiple controller nodes with a phys property pointing to the

Re: [PATCH 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

2016-06-03 Thread Kishon Vijay Abraham I
Hi, On Thursday 02 June 2016 11:01 PM, Hans de Goede wrote: > Some SoCs have a single phy-hw-block with multiple phys, this is > modelled by a single phy dts node, so we end up with multiple > controller nodes with a phys property pointing to the phy-node > of the otg-phy. Maybe we should try to

Re: [PATCH 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

2016-06-03 Thread Hans de Goede
Hi, On 02-06-16 20:16, Bin Liu wrote: Hi, On Thu, Jun 02, 2016 at 07:31:03PM +0200, Hans de Goede wrote: Some SoCs have a single phy-hw-block with multiple phys, this is modelled by a single phy dts node, so we end up with multiple controller nodes with a phys property pointing to the

Re: [PATCH 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

2016-06-02 Thread Bin Liu
Hi, On Thu, Jun 02, 2016 at 07:31:03PM +0200, Hans de Goede wrote: > Some SoCs have a single phy-hw-block with multiple phys, this is > modelled by a single phy dts node, so we end up with multiple > controller nodes with a phys property pointing to the phy-node > of the otg-phy. > > Only one of

[PATCH 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

2016-06-02 Thread Hans de Goede
Some SoCs have a single phy-hw-block with multiple phys, this is modelled by a single phy dts node, so we end up with multiple controller nodes with a phys property pointing to the phy-node of the otg-phy. Only one of these controllers typically is an otg controller, yet we were checking the