Re: [PATCH 1/4] uas: new function to cancel data urbs

2012-11-29 Thread Alan Stern
On Thu, 29 Nov 2012, Gerd Hoffmann wrote: > Is it safe to call urb_unlink_urb twice on the same urb? Or must I take > care to not do that? It is safe. You only have to make certain that the URB is not deallocated before usb_unlink_urb returns. Alan Stern -- To unsubscribe from this list: sen

Re: [PATCH 1/4] uas: new function to cancel data urbs

2012-11-29 Thread Gerd Hoffmann
+static void uas_unlink_data_urbs(struct uas_dev_info *devinfo, + struct uas_cmd_info *cmdinfo) +{ + unsigned long flags; + + spin_lock_irqsave(&devinfo->lock, flags); + if (cmdinfo->state & DATA_IN_URB_INFLIGHT) { + spin

Re: [PATCH 1/4] uas: new function to cancel data urbs

2012-11-29 Thread Oliver Neukum
On Thursday 29 November 2012 15:31:54 Gerd Hoffmann wrote: > On 11/29/12 14:20, Oliver Neukum wrote: > > On Thursday 29 November 2012 14:06:12 Gerd Hoffmann wrote: > >> Add uas_unlink_data_urbs function to cancel in-flight data urbs. > >> Moves existing code into a separate function. > >> > >> Sign

Re: [PATCH 1/4] uas: new function to cancel data urbs

2012-11-29 Thread Gerd Hoffmann
On 11/29/12 14:20, Oliver Neukum wrote: > On Thursday 29 November 2012 14:06:12 Gerd Hoffmann wrote: >> Add uas_unlink_data_urbs function to cancel in-flight data urbs. >> Moves existing code into a separate function. >> >> Signed-off-by: Gerd Hoffmann >> --- >> drivers/usb/storage/uas.c | 32 +

Re: [PATCH 1/4] uas: new function to cancel data urbs

2012-11-29 Thread Oliver Neukum
On Thursday 29 November 2012 14:06:12 Gerd Hoffmann wrote: > Add uas_unlink_data_urbs function to cancel in-flight data urbs. > Moves existing code into a separate function. > > Signed-off-by: Gerd Hoffmann > --- > drivers/usb/storage/uas.c | 32 ++-- > 1 files chan

[PATCH 1/4] uas: new function to cancel data urbs

2012-11-29 Thread Gerd Hoffmann
Add uas_unlink_data_urbs function to cancel in-flight data urbs. Moves existing code into a separate function. Signed-off-by: Gerd Hoffmann --- drivers/usb/storage/uas.c | 32 ++-- 1 files changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/usb/storage/