Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-20 Thread Arnd Bergmann
On Wednesday 20 February 2013, Greg KH wrote: > On Tue, Feb 19, 2013 at 08:24:38AM +0100, Andrew Lunn wrote: > > > > GregKH: Please can you drop this patch from usb-next. It breaks more > > than it fixes. > > I've now reverted both of these, and the follow-on patch that Arnd sent > in. > > Arnd,

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-20 Thread Greg KH
On Tue, Feb 19, 2013 at 08:24:38AM +0100, Andrew Lunn wrote: > > GregKH: Please can you drop this patch from usb-next. It breaks more > than it fixes. I've now reverted both of these, and the follow-on patch that Arnd sent in. Arnd, sorry, but please be more careful, especially when you ask for

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-20 Thread Jason Cooper
Alan, On Wed, Feb 20, 2013 at 04:27:04PM +, Arnd Bergmann wrote: > On Wednesday 20 February 2013, Alan Stern wrote: > > Currently there is no Kconfig option to control specifically whether > > the ehci-orion driver gets built; it always gets built whenever > > CONFIG_PLAT_ORION and CONFIG_USB_

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-20 Thread Arnd Bergmann
On Wednesday 20 February 2013, Alan Stern wrote: > Currently there is no Kconfig option to control specifically whether > the ehci-orion driver gets built; it always gets built whenever > CONFIG_PLAT_ORION and CONFIG_USB_EHCI_HCD are both enabled. > > Do you think it is a good idea to add an optio

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-20 Thread Alan Stern
On Fri, 15 Feb 2013, Arnd Bergmann wrote: > From: Manjunath Goudar > > With the multiplatform changes in arm-soc tree, it becomes > possible to enable the mvebu platform (which uses > ehci-orion) at the same time as other platforms that require > a conflicting EHCI bus glue. At the moment, this

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-19 Thread Alan Stern
On Tue, 19 Feb 2013, Arnd Bergmann wrote: > On Tuesday 19 February 2013, Manjunath Goudar wrote: > > > This is not necessary; ehci_setup is the default value anyway. This > > > structure can be omitted. > > > > > > > ehci_init_driver function we are passing orion_overrides,if we are removing > >

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2013, Manjunath Goudar wrote: > > This is not necessary; ehci_setup is the default value anyway. This > > structure can be omitted. > > > > ehci_init_driver function we are passing orion_overrides,if we are removing > above struct initialization, what should we need to pass

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-19 Thread Rtp
Andrew Lunn writes: Hi, [...] >> > + >> > +static const char hcd_name[] = "ehci-orion"; [...] >> > } >> > >> > -MODULE_ALIAS("platform:orion-ehci"); >> > - >> > static const struct of_device_id ehci_orion_dt_ids[] = { >> >{ .compatible = "marvell,orion-ehci", }, orion-ehci here ... >

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-18 Thread Andrew Lunn
On Mon, Feb 18, 2013 at 05:34:35PM -0500, Alan Stern wrote: > On Fri, 15 Feb 2013, Arnd Bergmann wrote: > > > From: Manjunath Goudar > > > > With the multiplatform changes in arm-soc tree, it becomes > > possible to enable the mvebu platform (which uses > > ehci-orion) at the same time as other

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-18 Thread Alan Stern
On Fri, 15 Feb 2013, Arnd Bergmann wrote: > From: Manjunath Goudar > > With the multiplatform changes in arm-soc tree, it becomes > possible to enable the mvebu platform (which uses > ehci-orion) at the same time as other platforms that require > a conflicting EHCI bus glue. At the moment, this

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-16 Thread Ezequiel Garcia
Hi Arnd, On Fri, Feb 15, 2013 at 11:12:29PM +0100, Arnd Bergmann wrote: > From: Manjunath Goudar > > With the multiplatform changes in arm-soc tree, it becomes > possible to enable the mvebu platform (which uses > ehci-orion) at the same time as other platforms that require > a conflicting EHCI

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-16 Thread Andrew Lunn
On Fri, Feb 15, 2013 at 11:12:29PM +0100, Arnd Bergmann wrote: > From: Manjunath Goudar > > With the multiplatform changes in arm-soc tree, it becomes > possible to enable the mvebu platform (which uses > ehci-orion) at the same time as other platforms that require > a conflicting EHCI bus glue.

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-15 Thread Jason Cooper
On Fri, Feb 15, 2013 at 11:12:29PM +0100, Arnd Bergmann wrote: > From: Manjunath Goudar > > With the multiplatform changes in arm-soc tree, it becomes > possible to enable the mvebu platform (which uses > ehci-orion) at the same time as other platforms that require > a conflicting EHCI bus glue.

[PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-15 Thread Arnd Bergmann
From: Manjunath Goudar With the multiplatform changes in arm-soc tree, it becomes possible to enable the mvebu platform (which uses ehci-orion) at the same time as other platforms that require a conflicting EHCI bus glue. At the moment, this results in a warning like drivers/usb/host/ehci-hcd.c: