Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-04-02 Thread Sarah Sharp
On Tue, Apr 02, 2013 at 07:07:36PM +0100, David Howells wrote: > Sarah Sharp wrote: > > > I guess my question is a deeper one: do we need to rename all the xHCI > > macros to have the XHCI_ prefix, in order to avoid future collision? > > For example, one of the macros is MAX_HC_PORTS, which could

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-04-02 Thread David Howells
Sarah Sharp wrote: > I guess my question is a deeper one: do we need to rename all the xHCI > macros to have the XHCI_ prefix, in order to avoid future collision? > For example, one of the macros is MAX_HC_PORTS, which could possibly be > used by other host drivers in the future. Hmmm... I susp

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 10:32:53PM +, David Howells wrote: > Sarah Sharp wrote: > > > I'm a little bit confused about your description for the second one. > > Did you need to change the #defines names because they could conflict > > with other drivers when the xHCI driver is built in? Or is

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread David Howells
Sarah Sharp wrote: > I'm a little bit confused about your description for the second one. > Did you need to change the #defines names because they could conflict > with other drivers when the xHCI driver is built in? Or is there some > other point I'm missing? Sorry, I should say. I'm trying t

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread Sarah Sharp
Hi Dave, I'm a little bit confused about your description for the second one. Did you need to change the #defines names because they could conflict with other drivers when the xHCI driver is built in? Or is there some other point I'm missing? Are these feature patches for 3.10, or bug fixes for

[PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread David Howells
Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h. Signed-off-by: David Howells cc: Sarah Sharp cc: Greg Kroah-Hartman cc: linux-usb@vger.kernel.org --- drivers/usb/host/xhci-mem.c | 16 drivers/usb/host/xhci.h |4 ++-- 2 files changed, 10 inser