Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-22 Thread Felipe Balbi
Hi, John Youn writes: > I haven't checked, but Thinh looked and couldn't find anything > relating to the macOS issue. Which is why we want more information > about the problem. > > I can take a look at it too later today when I get a chance. >

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-21 Thread John Youn
On 6/21/2017 3:38 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: > > > I haven't checked, but Thinh looked and couldn't find anything relating to the macOS issue. Which is why we want more information about the problem. I can take a look at

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-13 Thread John Youn
On 6/13/2017 3:31 PM, Paul Zimmerman wrote: > On Tue, 13 Jun 2017 21:57:42 +, John Youn wrote: > >> On 6/13/2017 2:39 PM, Paul Zimmerman wrote: >>> On Tue, 13 Jun 2017 18:33:09 +, John Youn >>> wrote: >>> On 6/13/2017 12:32 AM, Felipe

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-13 Thread Paul Zimmerman
On Tue, 13 Jun 2017 21:57:42 +, John Youn wrote: > On 6/13/2017 2:39 PM, Paul Zimmerman wrote: > > On Tue, 13 Jun 2017 18:33:09 +, John Youn > > wrote: > > > >> On 6/13/2017 12:32 AM, Felipe Balbi wrote: > >>> > >>> Hi, > >>> > >>> Thinh

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-13 Thread John Youn
On 6/13/2017 2:39 PM, Paul Zimmerman wrote: > On Tue, 13 Jun 2017 18:33:09 +, John Youn wrote: > >> On 6/13/2017 12:32 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Thinh Nguyen writes: >> this could be, I don't remember if I

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-13 Thread Paul Zimmerman
On Tue, 13 Jun 2017 18:33:09 +, John Youn wrote: > On 6/13/2017 12:32 AM, Felipe Balbi wrote: > > > > Hi, > > > > Thinh Nguyen writes: > this could be, I don't remember if I checked this or not :-) > >

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-13 Thread John Youn
On 6/13/2017 12:32 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: this could be, I don't remember if I checked this or not :-) Really, the best way here, IMHO, would be to re-verify what's going on

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-13 Thread Thinh Nguyen
Hi, On 6/13/2017 12:32 AM, Felipe Balbi wrote: > Thinh Nguyen writes: this could be, I don't remember if I checked this or not :-) Really, the best way here, IMHO, would be to re-verify what's going on

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-13 Thread Felipe Balbi
Hi, Thinh Nguyen writes: >>> this could be, I don't remember if I checked this or not :-) >>> >>> Really, the best way here, IMHO, would be to re-verify what's going >>> on >>> with macOS and revert my orignal patch since it's,

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-12 Thread Thinh Nguyen
Hi Felipe, On 6/6/2017 11:52 AM, Thinh Nguyen wrote: > On 6/4/2017 11:08 PM, Felipe Balbi wrote: >> Paul Zimmerman writes: >>> Forgot to CC linux-usb, doing that now >>> >>> On Fri, 2 Jun 2017 16:27:56 -0700, Paul Zimmerman >>> wrote: >>> Felipe

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-06 Thread Thinh Nguyen
Hi Felipe, On 6/4/2017 11:08 PM, Felipe Balbi wrote: > Paul Zimmerman writes: >> Forgot to CC linux-usb, doing that now >> >> On Fri, 2 Jun 2017 16:27:56 -0700, Paul Zimmerman wrote: >> >>> Felipe Balbi writes: Thinh Nguyen

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-05 Thread Felipe Balbi
Hi, Paul Zimmerman writes: > Forgot to CC linux-usb, doing that now > > On Fri, 2 Jun 2017 16:27:56 -0700, Paul Zimmerman wrote: > >> Felipe Balbi writes: >> > Thinh Nguyen writes: >> >> this could be, I

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-02 Thread Paul Zimmerman
Forgot to CC linux-usb, doing that now On Fri, 2 Jun 2017 16:27:56 -0700, Paul Zimmerman wrote: > Felipe Balbi writes: > > Thinh Nguyen writes: > >> this could be, I don't remember if I checked this or not :-) > >> >

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-02 Thread Felipe Balbi
Hi, Thinh Nguyen writes: > this could be, I don't remember if I checked this or not :-) > > Really, the best way here, IMHO, would be to re-verify what's going on > with macOS and revert my orignal patch since it's, rather clearly, > wrong. >

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-05-23 Thread Thinh Nguyen
Hi Felipe, On 5/11/2017 6:12 PM, Thinh Nguyen wrote: > On 4/11/2017 11:03 PM, Felipe Balbi wrote: >> Thinh Nguyen writes: >> Felipe Balbi writes: >>> Thinh Nguyen writes: This patch fixes a commit that

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-05-11 Thread Thinh Nguyen
Hi Felipe, On 4/11/2017 11:03 PM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: > Felipe Balbi writes: >> Thinh Nguyen writes: >>> This patch fixes a commit that causes a hang from device waiting for

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-04-12 Thread Felipe Balbi
Hi, Thinh Nguyen writes: Felipe Balbi writes: > Thinh Nguyen writes: >> This patch fixes a commit that causes a hang from device waiting for >> data with the wrong sequence number. The commit ffb80fc672c3

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-04-11 Thread Thinh Nguyen
On 4/11/2017 12:36 AM, Felipe Balbi wrote: Hi, Thinh Nguyen writes: Felipe Balbi writes: Thinh Nguyen writes: This patch fixes a commit that causes a hang from device waiting for data with the wrong sequence number.

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-04-11 Thread Felipe Balbi
Hi, Thinh Nguyen writes: >> Felipe Balbi writes: >>> Thinh Nguyen writes: This patch fixes a commit that causes a hang from device waiting for data with the wrong sequence number. The commit ffb80fc672c3 ("usb:

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-04-10 Thread Thinh Nguyen
Hi Felipe, On 4/10/2017 12:04 AM, Felipe Balbi wrote: Hi again, Felipe Balbi writes: Thinh Nguyen writes: This patch fixes a commit that causes a hang from device waiting for data with the wrong sequence number. The commit ffb80fc672c3 ("usb:

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-04-10 Thread Felipe Balbi
Hi again, Felipe Balbi writes: > Thinh Nguyen writes: >> This patch fixes a commit that causes a hang from device waiting for >> data with the wrong sequence number. The commit ffb80fc672c3 ("usb: >> dwc3: gadget: skip Set/Clear Halt when invalid")

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-04-10 Thread Felipe Balbi
Hi, Thinh Nguyen writes: > This patch fixes a commit that causes a hang from device waiting for > data with the wrong sequence number. The commit ffb80fc672c3 ("usb: > dwc3: gadget: skip Set/Clear Halt when invalid") adds a check to return > early depending on

[PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-04-07 Thread Thinh Nguyen
This patch fixes a commit that causes a hang from device waiting for data with the wrong sequence number. The commit ffb80fc672c3 ("usb: dwc3: gadget: skip Set/Clear Halt when invalid") adds a check to return early depending on DWC3_EP_STALL is set or not, prevent sending the ep halt command to HW