Re: query on [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-25 Thread Marc Kleine-Budde
Hi Afzal, On 09/25/2012 10:47 AM, Mohammed, Afzal wrote: This is a query regarding patch, usb: otg: add device tree support to otg library [1] It seems there is so far no consensus on this change. After I have posted this patch, Kishon had posted a better solution [2]. We discussed the

Re: query on [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 25, 2012 at 2:24 PM, Marc Kleine-Budde m...@pengutronix.de wrote: Hi Afzal, On 09/25/2012 10:47 AM, Mohammed, Afzal wrote: This is a query regarding patch, usb: otg: add device tree support to otg library [1] It seems there is so far no consensus on this change. After I

RE: query on [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-25 Thread Mohammed, Afzal
On Tue, Sep 25, 2012 at 16:21:39, ABRAHAM, KISHON VIJAY wrote: On Tue, Sep 25, 2012 at 2:24 PM, Marc Kleine-Budde m...@pengutronix.de wrote: I'm interested in to get these patches into the kernel soon. Kishon any news on this patch? Something like this would be required for USB support

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-12 Thread Marc Kleine-Budde
On 09/06/2012 05:27 PM, Marc Kleine-Budde wrote: We can use something like -phy as the phandle name. And the users can get the phy by using devm_usb_get_phy_by_phandle(dev, ). (So the frwrk appends *-phy* to the name and searches). Or we don't have any restriction on the phandle

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-06 Thread Felipe Balbi
On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote: On 09/04/2012 07:51 PM, ABRAHAM, KISHON VIJAY wrote: Since it's already a common function, we may give phandler property a common name too. So we will not need phandle argument. Please also don't forget to document the

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-06 Thread Richard Zhao
On Thu, Sep 06, 2012 at 05:30:02PM +0300, Felipe Balbi wrote: On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote: On 09/04/2012 07:51 PM, ABRAHAM, KISHON VIJAY wrote: Since it's already a common function, we may give phandler property a common name too. So we will not

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-06 Thread Felipe Balbi
Hi, We should at least add Grant to the loop, I guess. On Thu, Sep 06, 2012 at 10:46:13PM +0800, Richard Zhao wrote: On Thu, Sep 06, 2012 at 05:30:02PM +0300, Felipe Balbi wrote: On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote: On 09/04/2012 07:51 PM, ABRAHAM, KISHON

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-06 Thread Marc Kleine-Budde
On 09/06/2012 04:46 PM, Felipe Balbi wrote: Hi, We should at least add Grant to the loop, I guess. On Thu, Sep 06, 2012 at 10:46:13PM +0800, Richard Zhao wrote: On Thu, Sep 06, 2012 at 05:30:02PM +0300, Felipe Balbi wrote: On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote:

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-04 Thread Marc Kleine-Budde
On 08/29/2012 10:11 PM, Marc Kleine-Budde wrote: [...] +struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev, +const char *phandle) Since it's already a common function, we may give phandler property a common name too. So we will not need phandle argument. Please also don't

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-04 Thread Marc Kleine-Budde
On 09/04/2012 03:45 PM, Felipe Balbi wrote: On Tue, Sep 04, 2012 at 12:31:14PM +0200, Marc Kleine-Budde wrote: On 08/29/2012 10:11 PM, Marc Kleine-Budde wrote: [...] +struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev, +const char *phandle) Since it's already a common

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-04 Thread Richard Zhao
On Tue, Sep 04, 2012 at 03:58:50PM +0200, Marc Kleine-Budde wrote: On 09/04/2012 03:45 PM, Felipe Balbi wrote: On Tue, Sep 04, 2012 at 12:31:14PM +0200, Marc Kleine-Budde wrote: On 08/29/2012 10:11 PM, Marc Kleine-Budde wrote: [...] +struct usb_phy *devm_usb_get_phy_by_phandle(struct

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-04 Thread Marc Kleine-Budde
On 09/04/2012 04:07 PM, Richard Zhao wrote: +struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev, +const char *phandle) Since it's already a common function, we may give phandler property a common name too. So we will not need phandle argument. Please also don't forget to

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-04 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 4, 2012 at 7:46 PM, Marc Kleine-Budde m...@pengutronix.de wrote: On 09/04/2012 04:07 PM, Richard Zhao wrote: +struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev, +const char *phandle) Since it's already a common function, we may give phandler property a

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-04 Thread Marc Kleine-Budde
On 09/04/2012 07:51 PM, ABRAHAM, KISHON VIJAY wrote: Since it's already a common function, we may give phandler property a common name too. So we will not need phandle argument. Please also don't forget to document the devm_xxx and dt binding. I don't think this is a good idea. If we hardcode

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-08-29 Thread Marc Kleine-Budde
On 08/29/2012 05:14 AM, Richard Zhao wrote: On Tue, Aug 28, 2012 at 07:43:11PM +0530, ABRAHAM, KISHON VIJAY wrote: Hi, On Tue, Aug 28, 2012 at 7:11 PM, Marc Kleine-Budde m...@pengutronix.de wrote: On 08/24/2012 08:46 AM, Richard Zhao wrote: [...] /** + * devm_usb_get_phy_by_phandle -

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-08-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Aug 28, 2012 at 7:11 PM, Marc Kleine-Budde m...@pengutronix.de wrote: On 08/24/2012 08:46 AM, Richard Zhao wrote: [...] /** + * devm_usb_get_phy_by_phandle - find the USB PHY by phandle + * @dev - device that requests this phy + * @phandle - name of the property holding the phy

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-08-26 Thread ABRAHAM, KISHON VIJAY
Hi, On Sat, Aug 25, 2012 at 11:43 PM, Marc Kleine-Budde m...@pengutronix.de wrote: On 08/24/2012 08:46 AM, Richard Zhao wrote: Did you try both enableing and disabing DT pass build? Impossible on mx28 :) The platform always selects USE_DT, but on imx it builds without DT support. On Thu,

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-08-25 Thread Marc Kleine-Budde
On 08/24/2012 08:46 AM, Richard Zhao wrote: Did you try both enableing and disabing DT pass build? Impossible on mx28 :) The platform always selects USE_DT, but on imx it builds without DT support. On Thu, Aug 23, 2012 at 07:22:53PM +0200, Marc Kleine-Budde wrote: From: Kishon Vijay Abraham I