Re: [PATCH 2/3] usb: typec: Add support for UCSI interface

2017-06-03 Thread Greg KH
On Thu, May 25, 2017 at 06:20:16AM -0700, Guenter Roeck wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > Any preference in usb about alphabetic order of include files ? Nope, whatever order the author wants to put them in is fine

Re: [PATCH 2/3] usb: typec: Add support for UCSI interface

2017-05-29 Thread Guenter Roeck
On 05/29/2017 05:33 AM, Heikki Krogerus wrote: On Fri, May 26, 2017 at 06:26:01AM -0700, Guenter Roeck wrote: What happens if trace is not enabled ? If I recall discussions around CLANG correctly, it complains about unused static inline functions. Nothing happens if trace is not enable.

Re: [PATCH 2/3] usb: typec: Add support for UCSI interface

2017-05-29 Thread Heikki Krogerus
On Fri, May 26, 2017 at 06:26:01AM -0700, Guenter Roeck wrote: > > > What happens if trace is not enabled ? If I recall discussions around > > > CLANG > > > correctly, it complains about unused static inline functions. > > > > Nothing happens if trace is not enable. Everything continues to > >

Re: [PATCH 2/3] usb: typec: Add support for UCSI interface

2017-05-26 Thread Guenter Roeck
On 05/26/2017 04:02 AM, Heikki Krogerus wrote: Hi, On Thu, May 25, 2017 at 06:20:16AM -0700, Guenter Roeck wrote: On 05/16/2017 05:26 AM, Heikki Krogerus wrote: UCSI - USB Type-C Connector System Software Interface - is a specification that defines set of registers and data structures for

Re: [PATCH 2/3] usb: typec: Add support for UCSI interface

2017-05-26 Thread Heikki Krogerus
Hi, On Thu, May 25, 2017 at 06:20:16AM -0700, Guenter Roeck wrote: > On 05/16/2017 05:26 AM, Heikki Krogerus wrote: > > UCSI - USB Type-C Connector System Software Interface - is a > > specification that defines set of registers and data > > structures for controlling the USB Type-C ports. It's >

Re: [PATCH 2/3] usb: typec: Add support for UCSI interface

2017-05-25 Thread Guenter Roeck
On 05/16/2017 05:26 AM, Heikki Krogerus wrote: UCSI - USB Type-C Connector System Software Interface - is a specification that defines set of registers and data structures for controlling the USB Type-C ports. It's designed for systems where an embedded controller (EC) is in charge of the USB

[PATCH 2/3] usb: typec: Add support for UCSI interface

2017-05-16 Thread Heikki Krogerus
UCSI - USB Type-C Connector System Software Interface - is a specification that defines set of registers and data structures for controlling the USB Type-C ports. It's designed for systems where an embedded controller (EC) is in charge of the USB Type-C PHY or USB Power Delivery controller. It is