Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-08-02 Thread Tuomas Tynkkynen
On 08/02/2013 12:09 AM, Stephen Warren wrote: On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: Some of the PHY parameters are not set according to the TRMs: - UTMIP_FS_PREABMLE_J should be set, not cleared - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set - UTMIP_PD_CHRG should be set in

Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-08-01 Thread Stephen Warren
On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: Some of the PHY parameters are not set according to the TRMs: - UTMIP_FS_PREABMLE_J should be set, not cleared - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set - UTMIP_PD_CHRG should be set in host mode and cleared in device mode -

[PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-07-31 Thread Tuomas Tynkkynen
Some of the PHY parameters are not set according to the TRMs: - UTMIP_FS_PREABMLE_J should be set, not cleared - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set - UTMIP_PD_CHRG should be set in host mode and cleared in device mode - UTMIP_XCVR_SETUP is a two-part field; the upper bits were not