Re: [PATCH 3/3] dm9601: add support ethtool style utility

2016-03-11 Thread Ben Hutchings
On Fri, 2016-03-11 at 11:33 +, Ben Hutchings wrote: > On Fri, 2016-03-11 at 19:08 +0800, Joseph Chang wrote: > > > > I tested by > >  ./ethtool -E eth0 magic 0x9620 offset 0 length 3 value 0xf1 value 0xf2 > > value 0xf3 > > > > I think ethtool need [ value N ] for each byte (so need three

Re: [PATCH 3/3] dm9601: add support ethtool style utility

2016-03-11 Thread Ben Hutchings
On Fri, 2016-03-11 at 19:08 +0800, Joseph Chang wrote: > I tested by >  ./ethtool -E eth0 magic 0x9620 offset 0 length 3 value 0xf1 value 0xf2 value > 0xf3 > > I think ethtool need [ value N ] for each byte (so need three "value xx" in > above command line),  > am I right? > > Oh, I can see it

RE: [PATCH 3/3] dm9601: add support ethtool style utility

2016-03-11 Thread Joseph Chang
/3] dm9601: add support ethtool style utility On Thu, 2016-03-10 at 20:51 +0800, Joseph Chang wrote: > I did verify to dump EEPROM data and also write EEPROM by per byte. > > 1.Plug dm9601/dm9621 adapter and has get dm9601.ko be 'insmod' to have 'eht0', > 2.Run ethtool v3.7 (as attached ex

Re: [PATCH 3/3] dm9601: add support ethtool style utility

2016-03-10 Thread Ben Hutchings
On Thu, 2016-03-10 at 20:51 +0800, Joseph Chang wrote: > I did verify to dump EEPROM data and also write EEPROM by per byte. > > 1.Plug dm9601/dm9621 adapter and has get dm9601.ko be 'insmod' to have 'eht0', > 2.Run ethtool v3.7 (as attached executable file and it's help display.) > 3. Commands:

Re: [PATCH 3/3] dm9601: add support ethtool style utility

2016-03-10 Thread Ben Hutchings
The subject line on this is very vague; it should say which ethtool operation you're implementing. On Thu, 2016-03-10 at 19:24 +0800, Joseph CHANG wrote: > Add function dm9601_set_eeprom which tested good with ethtool > utility, include the eeprom words dump and the eeprom byte write. > >

[PATCH 3/3] dm9601: add support ethtool style utility

2016-03-10 Thread Joseph CHANG
Add function dm9601_set_eeprom which tested good with ethtool utility, include the eeprom words dump and the eeprom byte write. Signed-off-by: Joseph CHANG --- drivers/net/usb/dm9601.c | 39 +++ 1 file changed, 39 insertions(+) diff