Re: [PATCH 3/3] page-flags: rectify forward declaration

2015-09-24 Thread Sudip Mukherjee
> > > > Also, I'm finding that the patch series introduces a pretty large > > bisection hole: > > > > include/linux/page-flags.h: In function 'PageYoung': > > include/linux/page-flags.h:327: error: implicit declaration of function > > 'PF_ANY' > > include/linux/page-flags.h:327: error: invalid

Re: [PATCH 3/3] page-flags: rectify forward declaration

2015-09-22 Thread Sudip Mukherjee
On Mon, Sep 21, 2015 at 03:35:09PM -0700, Andrew Morton wrote: > On Sat, 19 Sep 2015 22:42:59 +0530 Sudip Mukherjee > wrote: > > > Is it fixable? Can we use the traditional define-before-using structure? How about this: diff --git a/include/linux/page-flags.h

Re: [PATCH 3/3] page-flags: rectify forward declaration

2015-09-21 Thread Andrew Morton
On Sat, 19 Sep 2015 22:42:59 +0530 Sudip Mukherjee wrote: > compound_head is defined as inline in page-flags.h but in the forward > declaration of compound_head in the same file missed "inline". As a result > we got plenty of build warnings while building for some

[PATCH 3/3] page-flags: rectify forward declaration

2015-09-19 Thread Sudip Mukherjee
compound_head is defined as inline in page-flags.h but in the forward declaration of compound_head in the same file missed "inline". As a result we got plenty of build warnings while building for some architecture like avr32. The warning showed as: warning: 'compound_head' declared inline after