Re: [PATCH 3/3] usb host/MIPS: Remove hard-coded OCTEON platform information.

2014-05-29 Thread David Daney
On 05/29/2014 01:55 PM, Alan Stern wrote: On Thu, 29 May 2014, David Daney wrote: Several points of clarification: 1) I wrote the patch in question, not Florian. 2) I agree that OCTEON ehci/ohci support could probably be refactored along the lines of Alan's suggestion. 3) This patch is a rel

Re: [PATCH 3/3] usb host/MIPS: Remove hard-coded OCTEON platform information.

2014-05-29 Thread Alan Stern
On Thu, 29 May 2014, David Daney wrote: > Several points of clarification: > > 1) I wrote the patch in question, not Florian. > > 2) I agree that OCTEON ehci/ohci support could probably be refactored > along the lines of Alan's suggestion. > > 3) This patch is a relatively minor change to an *

Re: [PATCH 3/3] usb host/MIPS: Remove hard-coded OCTEON platform information.

2014-05-29 Thread David Daney
On 05/29/2014 10:37 AM, Greg KH wrote: On Thu, May 29, 2014 at 09:55:08AM -0700, Florian Fainelli wrote: 2014-05-29 8:03 GMT-07:00 Alan Stern : On Thu, 29 May 2014, Alex Smith wrote: From: David Daney The device tree will *always* have correct ehci/ohci clock configuration, so use it. This

Re: [PATCH 3/3] usb host/MIPS: Remove hard-coded OCTEON platform information.

2014-05-29 Thread Greg KH
On Thu, May 29, 2014 at 09:55:08AM -0700, Florian Fainelli wrote: > 2014-05-29 8:03 GMT-07:00 Alan Stern : > > On Thu, 29 May 2014, Alex Smith wrote: > > > >> From: David Daney > >> > >> The device tree will *always* have correct ehci/ohci clock > >> configuration, so use it. This allows us to re

Re: [PATCH 3/3] usb host/MIPS: Remove hard-coded OCTEON platform information.

2014-05-29 Thread Florian Fainelli
2014-05-29 8:03 GMT-07:00 Alan Stern : > On Thu, 29 May 2014, Alex Smith wrote: > >> From: David Daney >> >> The device tree will *always* have correct ehci/ohci clock >> configuration, so use it. This allows us to remove a big chunk of >> platform configuration code from octeon-platform.c. > > I

Re: [PATCH 3/3] usb host/MIPS: Remove hard-coded OCTEON platform information.

2014-05-29 Thread Alan Stern
On Thu, 29 May 2014, Alex Smith wrote: > From: David Daney > > The device tree will *always* have correct ehci/ohci clock > configuration, so use it. This allows us to remove a big chunk of > platform configuration code from octeon-platform.c. Instead of doing this, how about moving the octeon

[PATCH 3/3] usb host/MIPS: Remove hard-coded OCTEON platform information.

2014-05-29 Thread Alex Smith
From: David Daney The device tree will *always* have correct ehci/ohci clock configuration, so use it. This allows us to remove a big chunk of platform configuration code from octeon-platform.c. Tested-by: Alex Smith Signed-off-by: David Daney Signed-off-by: Alex Smith Cc: linux-usb@vger.ker