Re: [PATCH 3/6] staging: octeon-usb: cvmx-usbcx-defs.h: avoid long lines in CVMX_USBCX macros

2013-06-05 Thread Dan Carpenter
On Wed, Jun 05, 2013 at 12:31:32AM +0300, Aaro Koskinen wrote: -#define CVMX_USBCX_DAINT(block_id) (CVMX_ADD_IO_SEG(0x00016F001818ull) + ((block_id) 1) * 0x1000ull) There should be a few helper macros. I don't know the names for these: #define bid_to_xxx1(block_id) ((block_id)

Re: [PATCH 3/6] staging: octeon-usb: cvmx-usbcx-defs.h: avoid long lines in CVMX_USBCX macros

2013-06-05 Thread Aaro Koskinen
Hi, On Wed, Jun 05, 2013 at 11:36:46AM +0300, Dan Carpenter wrote: On Wed, Jun 05, 2013 at 12:31:32AM +0300, Aaro Koskinen wrote: -#define CVMX_USBCX_DAINT(block_id) (CVMX_ADD_IO_SEG(0x00016F001818ull) + ((block_id) 1) * 0x1000ull) There should be a few helper macros. OK,

[PATCH 3/6] staging: octeon-usb: cvmx-usbcx-defs.h: avoid long lines in CVMX_USBCX macros

2013-06-04 Thread Aaro Koskinen
Avoid long lines in CVMX_USBCX macros. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/staging/octeon-usb/cvmx-usbcx-defs.h | 208 +++--- 1 file changed, 156 insertions(+), 52 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usbcx-defs.h