Hi guys!! :)
First of all - I would like to thank both of you for your interest and time in
my patches.
I agree with Joe's point of view, completely. The Coding style document tries
to leverage on the developer's good sense, even when defining some rules.
Apart from that - checkpatch.po
From: Enrico Mioso mrkiko...@gmail.com
Date: Fri, 23 Aug 2013 09:56:29 +0200
+ if ((on atomic_add_return(1, drvstate-pmcount) == 1) || (!on
atomic_dec_and_test(drvstate-pmcount))) {
These line significantly exceeds 80 columns.
+ subdriver =
On Mon, 2013-08-26 at 16:31 -0400, David Miller wrote:
From: Enrico Mioso mrkiko...@gmail.com
[]
+ int ret = 0;
+ struct usbnet *usbnet_dev = usb_get_intfdata(intf);
+ struct huawei_cdc_ncm_state *drvstate = (void *)usbnet_dev-data;
+ struct cdc_ncm_ctx *ctx =
From: Joe Perches j...@perches.com
Date: Mon, 26 Aug 2013 13:45:13 -0700
I think the premise of local variable
declaration by line length is flawed.
I disagree.
It can't work when local variables are
dependent on initialization order as
above.
Move the initialization below the
On Mon, 2013-08-26 at 16:58 -0400, David Miller wrote:
From: Joe Perches j...@perches.com
Date: Mon, 26 Aug 2013 13:45:13 -0700
I think the premise of local variable
declaration by line length is flawed.
I disagree.
It can't work when local variables are
dependent on
From: Joe Perches j...@perches.com
Date: Mon, 26 Aug 2013 14:05:55 -0700
On Mon, 2013-08-26 at 16:58 -0400, David Miller wrote:
From: Joe Perches j...@perches.com
Date: Mon, 26 Aug 2013 13:45:13 -0700
I think the premise of local variable
declaration by line length is flawed.
I
On Mon, 2013-08-26 at 17:09 -0400, David Miller wrote:
From: Joe Perches j...@perches.com
[]
Don't try to over-simplify things and act as if they are black
and white when they aren't.
It wasn't me simplifying.
I commented on your request to:
order local function variable declarations by line
This driver supports devices using the NCM protocol as an encapsulation layer
for other protocols, like the E3131 Huawei 3G modem. This drivers approach was
heavily inspired by the qmi_wwan approach code model.
Suggested-by: Bjorn Mork bj...@mork.no
Signed-off-by: Enrico Mioso
