Re: [PATCH RESEND V4 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-10-30 Thread Thierry Reding
On Wed, Oct 29, 2014 at 11:02:36AM -0700, Andrew Bresticker wrote: [...] Maybe something like this patch would be more correct in handling this: diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index afcb430508ec..85691a7d8ca6 100644 --- a/drivers/mailbox/mailbox.c

Re: [PATCH RESEND V4 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-10-30 Thread Andrew Bresticker
On Thu, Oct 30, 2014 at 6:22 AM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Oct 29, 2014 at 11:02:36AM -0700, Andrew Bresticker wrote: [...] Maybe something like this patch would be more correct in handling this: diff --git a/drivers/mailbox/mailbox.c

Re: [PATCH RESEND V4 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-10-29 Thread Thierry Reding
On Tue, Oct 28, 2014 at 03:27:49PM -0700, Andrew Bresticker wrote: [...] diff --git a/drivers/mailbox/tegra-xusb-mailbox.c b/drivers/mailbox/tegra-xusb-mailbox.c [...] +struct tegra_xusb_mbox { + struct mbox_controller mbox; + int irq; It seems like this is unused outside of

Re: [PATCH RESEND V4 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-10-29 Thread Andrew Bresticker
+ for (i = 0; i ARRAY_SIZE(mbox-vchan_allocated); i++) { + if (mbox-vchan_allocated[i]) + mbox_chan_received_data(mbox-mbox.chans[i], msg); + } It seems like the only reason why you need to explicitly check for an allocated channel is that

[PATCH RESEND V4 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-10-28 Thread Andrew Bresticker
The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single physical channel, messages sent by the controller can be divided into two groups: those intended for the PHY driver and those intended for the host-controller