Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-29 Thread Mauro Carvalho Chehab
Em Wed, 29 Mar 2017 11:57:22 +0200 Greg Kroah-Hartman escreveu: > On Tue, Mar 28, 2017 at 06:48:02AM -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 17 Mar 2017 10:24:15 +0900 > > Greg Kroah-Hartman escreveu: > > > > > On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab wrote: >

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-29 Thread Greg Kroah-Hartman
On Tue, Mar 28, 2017 at 06:48:02AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 17 Mar 2017 10:24:15 +0900 > Greg Kroah-Hartman escreveu: > > > On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab wrote: > > > The dwc2 hardware doesn't like to do DMA transfers without > > > aligning d

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-28 Thread Mauro Carvalho Chehab
Em Fri, 17 Mar 2017 10:24:15 +0900 Greg Kroah-Hartman escreveu: > On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab wrote: > > The dwc2 hardware doesn't like to do DMA transfers without > > aligning data in DWORD. The driver also assumes that, even > > when there's no DMA, at dwc2_r

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-18 Thread Alan Stern
On Fri, 17 Mar 2017, Michael Zoran wrote: > On Fri, 2017-03-17 at 10:24 +0900, Greg Kroah-Hartman wrote: > > On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab > > wrote: > > > The dwc2 hardware doesn't like to do DMA transfers without > > > aligning data in DWORD. The driver also ass

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-17 Thread Greg Kroah-Hartman
On Fri, Mar 17, 2017 at 04:25:21PM -0700, Michael Zoran wrote: > On Fri, 2017-03-17 at 10:24 +0900, Greg Kroah-Hartman wrote: > > On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab > > wrote: > > > The dwc2 hardware doesn't like to do DMA transfers without > > > aligning data in DWORD.

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-17 Thread Michael Zoran
On Fri, 2017-03-17 at 10:24 +0900, Greg Kroah-Hartman wrote: > On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab > wrote: > > The dwc2 hardware doesn't like to do DMA transfers without > > aligning data in DWORD. The driver also assumes that, even > > when there's no DMA, at dwc2_read

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-17 Thread Mauro Carvalho Chehab
Hi Greg, (c/c media ML) Em Fri, 17 Mar 2017 10:24:15 +0900 Greg Kroah-Hartman escreveu: > On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab wrote: > > The dwc2 hardware doesn't like to do DMA transfers without > > aligning data in DWORD. The driver also assumes that, even > > when

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab wrote: > The dwc2 hardware doesn't like to do DMA transfers without > aligning data in DWORD. The driver also assumes that, even > when there's no DMA, at dwc2_read_packet(). > > That cause buffer overflows, preventing some drivers to

[PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-16 Thread Mauro Carvalho Chehab
The dwc2 hardware doesn't like to do DMA transfers without aligning data in DWORD. The driver also assumes that, even when there's no DMA, at dwc2_read_packet(). That cause buffer overflows, preventing some drivers to work. In the specific case of uvc_driver, it uses an array where it caches the