Re: [PATCH RFC 1/3] usb: phy: fix the error check

2012-09-14 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Sep 13, 2012 at 7:44 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: The functions pm_runtime_get_sync and clk_enable return a signed value. So the variable used to store should be signed otherwise a negative value may be wrongly interpreted. While at it also remove the

[PATCH RFC 1/3] usb: phy: fix the error check

2012-09-13 Thread Shubhrajyoti D
The functions pm_runtime_get_sync and clk_enable return a signed value. So the variable used to store should be signed otherwise a negative value may be wrongly interpreted. While at it also remove the initialisation of ret to zero. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- untested