Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Heikki Krogerus
Hi, On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus I think setup instead of tune is much more clear and reusable. I think setup will look more like first time setting up the phy, which is rather served by init callback. This

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Kishon Vijay Abraham I
On Wednesday 11 December 2013 12:08 PM, Vivek Gautam wrote: Hi, On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus heikki.kroge...@linux.intel.com wrote: Hi, Thanks for reviewing this. On Tue, Dec 10, 2013 at 04:25:23PM +0530, Vivek Gautam wrote: Some PHY controllers may need to tune

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Vivek Gautam
Hi, On Wed, Dec 11, 2013 at 1:39 PM, Heikki Krogerus heikki.kroge...@linux.intel.com wrote: Hi, On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus I think setup instead of tune is much more clear and reusable. I think setup will

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Vivek Gautam
Hi Kishon, On Wed, Dec 11, 2013 at 1:47 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Wednesday 11 December 2013 12:08 PM, Vivek Gautam wrote: Hi, On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus heikki.kroge...@linux.intel.com wrote: Hi, Thanks for reviewing this. On Tue, Dec

[PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-10 Thread Vivek Gautam
Some PHY controllers may need to tune PHY post-initialization, so that the PHY consumers can call phy-tuning at appropriate point of time. Signed-off-by: vivek Gautam gautam.vi...@samsung.com --- drivers/phy/phy-core.c | 20 include/linux/phy/phy.h |7 +++ 2 files

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-10 Thread Heikki Krogerus
Hi, On Tue, Dec 10, 2013 at 04:25:23PM +0530, Vivek Gautam wrote: Some PHY controllers may need to tune PHY post-initialization, so that the PHY consumers can call phy-tuning at appropriate point of time. Signed-off-by: vivek Gautam gautam.vi...@samsung.com --- drivers/phy/phy-core.c |

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-10 Thread Vivek Gautam
Hi, On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus heikki.kroge...@linux.intel.com wrote: Hi, Thanks for reviewing this. On Tue, Dec 10, 2013 at 04:25:23PM +0530, Vivek Gautam wrote: Some PHY controllers may need to tune PHY post-initialization, so that the PHY consumers can call