[PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Pratyush Anand
Synopsys says: The HIRD Threshold field must be set to ‘0’ when the device core is operating in super speed mode. This patch implements above statement. Signed-off-by: Pratyush Anand pratyush.an...@st.com --- drivers/usb/dwc3/gadget.c | 31 ++- 1 files changed, 18

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 03:59:31PM +0530, Pratyush Anand wrote: Synopsys says: The HIRD Threshold field must be set to ‘0’ when the device core is operating in super speed mode. This patch implements above statement. why move HIRD settings to another part of the code ? Patch otherwise

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Pratyush Anand
I think, Paul can comment better. What I got feedback from SNPS that if HIRD settings are programmed in SS mode, it might result in some weird issue. However, our issue was resolved with some other fix in application and this patch did not had any effect. Since SNPS suggests to follow it so I

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 04:36:11PM +0530, Pratyush Anand wrote: I think, Paul can comment better. What I got feedback from SNPS that if HIRD settings are programmed in SS mode, it might result in some weird issue. However, our issue was resolved with some other fix in application and

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Pratyush Anand
Hi, On 1/14/2013 4:42 PM, Felipe Balbi wrote: Hi, On Mon, Jan 14, 2013 at 04:36:11PM +0530, Pratyush Anand wrote: I think, Paul can comment better. What I got feedback from SNPS that if HIRD settings are programmed in SS mode, it might result in some weird issue. However, our issue was

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 04:52:58PM +0530, Pratyush Anand wrote: Hi, On 1/14/2013 4:42 PM, Felipe Balbi wrote: Hi, On Mon, Jan 14, 2013 at 04:36:11PM +0530, Pratyush Anand wrote: I think, Paul can comment better. What I got feedback from SNPS that if HIRD settings are programmed in SS