Re: [PATCH resend 2/2] usb: phy: mxs: add usb charger type detection

2017-09-18 Thread Felipe Balbi
Hi, Peter Chen writes: > On Mon, Sep 04, 2017 at 11:14:02PM +0800, Li Jun wrote: >> } >> >> +#define MXS_USB_CHARGER_DATA_CONTACT_TIME_OUT 100 > > How about using "DATA_CONTACT_TIMEOUT_LOOP"? this really doesn't change anything. The only thing is that TIMEOUT is more common than TIME_O

Re: [PATCH resend 2/2] usb: phy: mxs: add usb charger type detection

2017-09-18 Thread Peter Chen
On Mon, Sep 04, 2017 at 11:14:02PM +0800, Li Jun wrote: > } > > +#define MXS_USB_CHARGER_DATA_CONTACT_TIME_OUT100 How about using "DATA_CONTACT_TIMEOUT_LOOP"? > +static int mxs_charger_data_contact_detect(struct mxs_phy *x) > +{ > + struct regmap *regmap = x->regmap_anatop; > +

Re: [PATCH resend 2/2] usb: phy: mxs: add usb charger type detection

2017-09-04 Thread Baolin Wang
Hi, On 4 September 2017 at 23:14, Li Jun wrote: > mxs phy has data pin contact and usb charger detector blocks which > can be controlled by software to detect charger type for SDP, CDP and > DCP. > > Signed-off-by: Li Jun For USB charger part: Reviewed-by: Baolin Wang -- Baolin.wang Best Reg

[PATCH resend 2/2] usb: phy: mxs: add usb charger type detection

2017-09-04 Thread Li Jun
mxs phy has data pin contact and usb charger detector blocks which can be controlled by software to detect charger type for SDP, CDP and DCP. Signed-off-by: Li Jun --- drivers/usb/phy/phy-mxs-usb.c | 154 ++ 1 file changed, 154 insertions(+) diff --git a/