Re: [PATCH v1] usb: misc: usbsevseg: Use __sysfs_match_string() helper

2017-06-11 Thread Andy Shevchenko
On Sun, 2017-06-11 at 09:46 +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 09, 2017 at 03:08:45PM +0300, Andy Shevchenko wrote: > > Use __sysfs_match_string() helper instead of open coded variant. > > __ functions shouldn't be exported, are you _sure_ this is a function > you should be using?

Re: [PATCH v1] usb: misc: usbsevseg: Use __sysfs_match_string() helper

2017-06-11 Thread Greg Kroah-Hartman
On Fri, Jun 09, 2017 at 03:08:45PM +0300, Andy Shevchenko wrote: > Use __sysfs_match_string() helper instead of open coded variant. __ functions shouldn't be exported, are you _sure_ this is a function you should be using? If so, shouldn't the api be fixed up instead? And kbuild is having a

Re: [PATCH v1] usb: misc: usbsevseg: Use __sysfs_match_string() helper

2017-06-09 Thread kbuild test robot
Hi Andy, [auto build test WARNING on usb/usb-testing] [also build test WARNING on v4.12-rc4 next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v1] usb: misc: usbsevseg: Use __sysfs_match_string() helper

2017-06-09 Thread kbuild test robot
Hi Andy, [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.12-rc4 next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v1] usb: misc: usbsevseg: Use __sysfs_match_string() helper

2017-06-09 Thread Andy Shevchenko
Use __sysfs_match_string() helper instead of open coded variant. Cc: Greg Kroah-Hartman Signed-off-by: Andy Shevchenko --- drivers/usb/misc/usbsevseg.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff