Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-30 Thread Krzysztof Opasiak
On 11/30/2015 05:16 PM, Alan Stern wrote: On Fri, 27 Nov 2015, Krzysztof Opasiak wrote: I run through your code and as far as I understand above is not exactly true. Your patch allows only to prevent userspace from accessing interfaces which has kernel drivers, there is no way to stop an

Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-30 Thread Greg KH
On Mon, Nov 30, 2015 at 06:12:22PM +0100, Krzysztof Opasiak wrote: > > > On 11/30/2015 05:16 PM, Alan Stern wrote: > >On Fri, 27 Nov 2015, Krzysztof Opasiak wrote: > > > I run through your code and as far as I understand above is not exactly > true. Your patch allows only to prevent

Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-30 Thread Alan Stern
On Fri, 27 Nov 2015, Krzysztof Opasiak wrote: > >> I run through your code and as far as I understand above is not exactly > >> true. Your patch allows only to prevent userspace from accessing interfaces > >> which has kernel drivers, there is no way to stop an application from > >> taking > >>

Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-30 Thread Krzysztof Opasiak
On 11/30/2015 06:20 PM, Greg KH wrote: On Mon, Nov 30, 2015 at 06:12:22PM +0100, Krzysztof Opasiak wrote: On 11/30/2015 05:16 PM, Alan Stern wrote: On Fri, 27 Nov 2015, Krzysztof Opasiak wrote: I run through your code and as far as I understand above is not exactly true. Your patch

Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-30 Thread Oliver Neukum
On Fri, 2015-11-27 at 18:39 -0800, Greg KH wrote: > Yes, it's tough, I know, good luck. > > Also deal with multiple devices, busses that are ordered differently > depending on the phase of the moon, and other fun things with dynamic > devices and ioctls. It's a loosing battle :) IMHO the

Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-27 Thread Greg KH
On Fri, Nov 27, 2015 at 09:44:45AM +0100, Krzysztof Opasiak wrote: > > > On 11/26/2015 06:29 PM, Greg KH wrote: > >On Thu, Nov 26, 2015 at 10:19:29AM +0100, Krzysztof Opasiak wrote: > >> > >> > >>On 11/25/2015 04:45 PM, Emilio López wrote: > >>>Hi everyone, > >>> > >>>This patch introduces a new

Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-27 Thread Krzysztof Opasiak
On 11/26/2015 06:29 PM, Greg KH wrote: On Thu, Nov 26, 2015 at 10:19:29AM +0100, Krzysztof Opasiak wrote: On 11/25/2015 04:45 PM, Emilio López wrote: Hi everyone, This patch introduces a new ioctl, USBDEVFS_DROP_PRIVILEGES, to voluntarily forgo the ability to issue ioctls which may

Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-26 Thread Krzysztof Opasiak
On 11/25/2015 04:45 PM, Emilio López wrote: Hi everyone, This patch introduces a new ioctl, USBDEVFS_DROP_PRIVILEGES, to voluntarily forgo the ability to issue ioctls which may interfere with other users of the USB device. This feature allows a privileged process (in the case of Chrome OS,

Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-26 Thread Greg KH
On Thu, Nov 26, 2015 at 10:19:29AM +0100, Krzysztof Opasiak wrote: > > > On 11/25/2015 04:45 PM, Emilio López wrote: > >Hi everyone, > > > >This patch introduces a new ioctl, USBDEVFS_DROP_PRIVILEGES, > >to voluntarily forgo the ability to issue ioctls which may > >interfere with other users of

[PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-25 Thread Emilio López
Hi everyone, This patch introduces a new ioctl, USBDEVFS_DROP_PRIVILEGES, to voluntarily forgo the ability to issue ioctls which may interfere with other users of the USB device. This feature allows a privileged process (in the case of Chrome OS, permission_broker) to open a USB device node and